From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F2AE840E80 for ; Fri, 11 Mar 2022 14:04:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CBD41689B6B; Fri, 11 Mar 2022 16:04:43 +0200 (EET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-oln040092069080.outbound.protection.outlook.com [40.92.69.80]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B6A66680BD4 for ; Fri, 11 Mar 2022 16:04:35 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h3aYCIPzPMp10duvptsvUTEWlk7s2EG6638QZLH7EvLbLHlZBNMi0Jhu3xIq8oTOczn4e67XwsyVdWQpu/Fka/H/PSzIKioIGvBJvqCvpFWKKfdxoEcR2kxFpVCEsNLkOv42uUYr/c7kW86ToOGxeSbfNA3DTZU51EkCSflxeM6h9HbjwKMV4y1FIjPuT2qJPXuo55op9trx8kAtk6Ion00FjfXL3b6YOxw4Vy0nlwfBIjaQy0/nPAItun2FaVhayV04NYDVMhE7ejTtuV2FmTdFGnwXo90xhlQS7s7w0zb8AjyjmC3PzraWjvaeVfOBKATTxNrTxtXOPVTjhf6cjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2QyMISzh3Hy02zBKwgicDChPsKvVZWt2U1w7kqBUbPg=; b=ntyFBFwewHyEi+quTivX6B/RGzrm3o3YPCNBuIX23oDEtPqyHD64nrlCJLzFFKqJV2P3ERSCtAa24TAVLn3oW1TcBH00e5AI+ab7zUNnuYWoSZbudnYxFFEcwTrgJpf/v6i2+El/tOktkA+k3IFAsUNPnJuvbS5CahL3qq9dOON8eF3uCGRY7WsB/Sfqottz/tAPsxz6ERUCuShH66CucMCbOszTT33LcgvktMeEHLh6hnUyMbF+nM8mXlgTR/SLkmVL2DHHk16CWwums0/4cQxM6EKaB0ywnt4qTxCxxiCfgSAh/JSvLiERY+zqE4ZD35DNojXhA7eyjX9+J4HSag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2QyMISzh3Hy02zBKwgicDChPsKvVZWt2U1w7kqBUbPg=; b=f+LmJh0sFkdJNIA6oHQSRqEplEGX8+8ccp7R6ukBu1XbOFtAOR7yHkfLfr77RPx4L4L7I5o3v06tTkwr4nXRP1ecjCuGi0avIInkW5uwDK/iBWyqwqrXrFBFQNMe1N7ncbH9mnVPiFJNMoO1V3UPJl5LIA66pcEIGkqDlfaTp4gjCGdZo6wq7t0y895PFWnmzfHRxhw6t3M+dERCjVigHW6CVEI6Ou9M9futABAbCnZXTo2lY57n/Icqwk0UzFOJT03c1KRVJ2bqhDbn2KnxeIlrrOEkx2faImOHTYvKD8k9ZhMqgzx27H2rZquorDmz1MhLjRs9vFb5VacmYsVSJg== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM0PR03MB3697.eurprd03.prod.outlook.com (2603:10a6:208:4d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22; Fri, 11 Mar 2022 14:04:34 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::bc6c:af66:7adb:7a3d]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::bc6c:af66:7adb:7a3d%7]) with mapi id 15.20.5061.022; Fri, 11 Mar 2022 14:04:34 +0000 Message-ID: Date: Fri, 11 Mar 2022 15:04:32 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <1646229512-12103-1-git-send-email-lance.lmwang@gmail.com> <20220311135854.GA24038@gmail.com> From: Andreas Rheinhardt In-Reply-To: <20220311135854.GA24038@gmail.com> X-TMN: [YN9mSBMrRjza+XnkwwhcsOVA4Kxod5Z6] X-ClientProxiedBy: AM5PR0402CA0020.eurprd04.prod.outlook.com (2603:10a6:203:90::30) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <380f2fc2-26b9-34ba-cd5a-d6f6aae4f2df@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b7113dbe-e13a-4783-3e2d-08da036811e2 X-MS-TrafficTypeDiagnostic: AM0PR03MB3697:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FyRV2lLTT7U3F7h8DhfQG8H6kBsbN70bbuhuR+i6lRBhBuWdUHticHagc/RCpYIjdSTdF/Tb/DWboCsNVlzyEFrrOPpTff+SsFTdsMui7G+FRN13/zXjdxDMQDXjQ8aXjF+adWgz2TF4DQvIlc0Xf9RNDGDMPXqV3G+NXOyUYfKtILaLwy+i2glLOjQCryBp/EMwrwFwPc5oQ6Ul1POUaxbX9lf2ZL51/jlVsEJ2iEIQ/O9Lb50opMBwHofBz6OmOCUvdBtdYNLzBc5aDDttCunV3A4hRoypo/w2R+Wib/fFAf13cHGeViamRehDD9uQp75ADiFkOfMcC6pJkc/OSkMvTJ+sRZh45w+EuLffIoW55dgxKsYR1dszu3kPXasExrXPV+uQfAcrZUsTauXTds6zrq64zg1nF4Aj44t19ithQAU/e8+wgPD2XUnMP/4fspnAMOfQtN9gVN+w0OYeiKtcKlXBlgcqNcJtsiX9z+BpdF+SZBWtYCfB8osGTK5pYm6AoX9kkuDk5OW2pbPmVd4EqjumAr8O88OMIo6hgLRBFKzKXJ2nbQS3/CIEZ0wxBOXlFVuWgTMm7CAtW7RYAw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZER4M2lVNnRBTTRUYlBVenFnZUNhMzNISFdLVnZkZFpsdFQ5clpDZFY5cS93?= =?utf-8?B?T2l3VnhIUnNNYkRTRG9KUlVnNG5Fb3BOdTYrYU9Ja2tPNDBEWUNmdWF4WUs1?= =?utf-8?B?M2kwUTc0aS9UdnUvTnExUXNOQUNGWitRVG9XK3lrWXFBSWpkaS9aWG5zUmpI?= =?utf-8?B?aUpxcmxIY2NYNmlkQk1hbU5OcnhMU1UxRWkyT3BWZkt6V29aMDdVSHZOeXdS?= =?utf-8?B?a2kwdStuN2I5MEExTUFiUng1emVuQU96b0YyWC80eUNNNW5JMVVobUttdGNB?= =?utf-8?B?ZG4yTUUrQ2ZtNFE1bDNyOXZzWUVDMXdhb1daMWhBNk9DQWtvcEREVHI1cEJQ?= =?utf-8?B?U01FMlBVYlB2RDg4SVRQNUN4eFVUVUZaMnEvV1U3TXdqKzk0ZzhVUldyaTRs?= =?utf-8?B?WDZLWmxoNzJNMU9DMDdMOWgySzk1d0lHa3dQb0x2a1hBMWZsLzNueE1qcnFV?= =?utf-8?B?REt2ek9JU01GVHYxTUxlYTFRdm9VTGNiZDBLOVh5ZXNONDJRZEVONkV4bkRS?= =?utf-8?B?WUViVzEzaFFiZFNGaUg2QTN3WWYvYWYvSTl4V243QVpJMnY5anZwV2RiRUcy?= =?utf-8?B?czRjTHRaUUVyMi8xYmh6S3lleEkrblBzZFErTGcrUU8vZ1FHbis5ZXJLSDQz?= =?utf-8?B?cEFnWkw0MTVsejJEVThFQUdVY1ZzbDA3eXJUVTBUR1lMcDkrQk1TYm55aHFY?= =?utf-8?B?US91L1FkSFBUOVZHdHhvZDJ5dnZDamtjN2w3RzY2dUpEaVBSWHkrT3ZHZW1j?= =?utf-8?B?RmZUNVhhZEJJdkd6WkRRdVJmYVFHZHRZTlpqRGRCbjQ4S3ExOVYwYWhScG1M?= =?utf-8?B?WTZGTVl1YjRzaEFSZURjMGh6SFNlbVFaT3VnamFubkxFckg0Y0FMZ0JkellV?= =?utf-8?B?aWVFSFhCOUlxcWc1N25Bek54STZ1azRKUzVkNDhuVGpyWk9nbXlsWkJKbWli?= =?utf-8?B?azk3T3RWZWNlUnAvMGZISGpYZ3dzS3p3UUg2cGdsWmEyRG1VUU8rV1oxMktC?= =?utf-8?B?dU1pQVkyRnk2MmdaNW55THZCaHNacUtFSGpEN0xUS2g4RldFQnM3Wjlwc2pI?= =?utf-8?B?T2l2KzcwTitTa2pXaUUwN1owYWlSU2ZtWHJpbk1aUEFzR1BaWDJ2VXE0c2pS?= =?utf-8?B?RVVqeXBBcHh6YW9INHRNUkdOWnlONXpvYlNIOW0xTUQwODlkZndvTDB3ZHlH?= =?utf-8?B?ODZuaVBzV0owd1NMWGswZTI4Mjh0T0tsT2xlNFV6WngvZTZOaENmTUxTUUtD?= =?utf-8?B?cEN2S3QyYlk5eUl3dnBHcktUU1hHYVRaeWUvWTRsZXhyaFVGM0d6Ynprem5M?= =?utf-8?B?QmlMR2lNR0tpTDZVWmhtcTRCSkgvYXBLTVZ4MHB1ZXgwZCtnZkZpbTJzaHpH?= =?utf-8?B?dHdCb08vOTNIb1VWNEozZzFJRHVoY1I5MGhDRVBGS2FvdGNROTlOV1BLZXJF?= =?utf-8?B?QXNpZ2RiUDM3TUtKaXgrTlkrT0x5TkNMMnBEem4vOXNZQ0hXQm44Nm9IYXNi?= =?utf-8?B?alU1VDdqenZVVVdMdTYrdERKdHBWSUFtUVB4MUFsbzRNOVYrZHNwUnRKUmV2?= =?utf-8?Q?vb0lxVZPkRtyuf1u/zMJySqdJBRxyKMrAurZxUAvW1XNvn?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7113dbe-e13a-4783-3e2d-08da036811e2 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2022 14:04:34.4429 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB3697 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/movenc: initialize pts/dts/duration of timecode packet X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: lance.lmwang@gmail.com: > On Wed, Mar 02, 2022 at 09:58:31PM +0800, lance.lmwang@gmail.com wrote: >> From: Limin Wang >> >> Fix below error message when timecode packet is written. >> "Application provided duration: -9223372036854775808 / timestamp: -9223372036854775808 is out of range for mov/mp4 format" >> >> try to reproduce by: >> ffmpeg -y -f lavfi -i color -metadata "timecode=00:00:00:00" -t 1 test.mov >> >> Note although error message is printed, the timecode packet will be written anyway. So >> the patch 2/2 will try to change the log level to warning. >> >> The first two test case of fate-lavf-ismv have timecode setting, so the crc of ref data is different. >> Fixes ticket #9488 >> >> Signed-off-by: Limin Wang >> --- >> libavformat/movenc.c | 2 ++ >> tests/ref/lavf/ismv | 4 ++-- >> 2 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/libavformat/movenc.c b/libavformat/movenc.c >> index 4c86891..74b94cd 100644 >> --- a/libavformat/movenc.c >> +++ b/libavformat/movenc.c >> @@ -6383,6 +6383,8 @@ static int mov_create_timecode_track(AVFormatContext *s, int index, int src_inde >> pkt->data = data; >> pkt->stream_index = index; >> pkt->flags = AV_PKT_FLAG_KEY; >> + pkt->pts = pkt->dts = av_rescale_q(tc.start, av_inv_q(rate), (AVRational){1,mov->movie_timescale}); >> + pkt->duration = av_rescale_q(1, av_inv_q(rate), (AVRational){1,mov->movie_timescale}); >> pkt->size = 4; >> AV_WB32(pkt->data, tc.start); >> ret = ff_mov_write_packet(s, pkt); >> diff --git a/tests/ref/lavf/ismv b/tests/ref/lavf/ismv >> index ac7f72b..723b432 100644 >> --- a/tests/ref/lavf/ismv >> +++ b/tests/ref/lavf/ismv >> @@ -1,7 +1,7 @@ >> -48fb8d7a5d19bd60f3a49ccf4b7d6593 *tests/data/lavf/lavf.ismv >> +7a24b73c096ec0f13f0f7a2d9101c4c1 *tests/data/lavf/lavf.ismv >> 313169 tests/data/lavf/lavf.ismv >> tests/data/lavf/lavf.ismv CRC=0x9d9a638a >> -d19cd8e310a2e94fe0a0d11c5dc29217 *tests/data/lavf/lavf.ismv >> +79646383fd099d45ad0d0c2791c601dd *tests/data/lavf/lavf.ismv >> 322075 tests/data/lavf/lavf.ismv >> tests/data/lavf/lavf.ismv CRC=0xe8130120 >> 3b6023766845b51b075aed474c00f73c *tests/data/lavf/lavf.ismv >> -- >> 1.8.3.1 >> > > will apply the patch set tomorrow unless there are any objections. > You have not really answered whether the current files or the new files are spec-incompliant; you have just reported that one byte is different. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".