From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F0C1342941 for ; Mon, 10 Jan 2022 08:57:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 47ECD68AEC5; Mon, 10 Jan 2022 10:57:14 +0200 (EET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20047.outbound.protection.outlook.com [40.107.2.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DC0C968A78A for ; Mon, 10 Jan 2022 10:57:07 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GwuKgCKG3L97HGVgLz98pZqefNKxaQczGHkgFPivctAhf/XvFt79HC0hkO7ao4nsgcFKeECi3yF3c1/CYckgg8ntumjGns3aP7YmAO3shfQ0hm4jLNOo7KIcZRKN6rDqiPqCMnWNJ4735dO1uiF5u0gZ98NauoRkAi3BedN4wu5sI5k9zdWtN3WDndhBwSHTWyhkhnXjNeOwJ/zNL5sB03lhMKQ2IuiWfCS3KXMBgQdeJoFEI1edmrdGQy//6mq166jGP3tBAhRoazj1FIvgkruKJdBfBEjXPEdxKbUl3SBCXMgllM3klK9T8Hpgu93uRfdiODwd6QzjePUvzEru8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a0vvnFudTYe8tcx+7EWikTJN8P1DuO4VY9r8QMAAABQ=; b=Bt4OrRjSaSAoQ2MstnZNX8tv754IPCfMdiyAnrZgIrZcMkTu5xCqJYOVdf3XW+W4KXfwQYnmgza/LYfCpf4SmigLa+PNEuk5yrwDzpGZKlea+YfARzUIb3am+W4Vm1IyaOYA9iaVIVBZcD+SdEVNzDOLp7hN1nipruCtrUaxIRmbmWHn4nSaZXZVjT9VxJ7bRG2ECdqnZEaoyY5bPgEicd9Vn+E6w7Z6jesaLuXGBpybQeSPD3m374gotnXTum15SxMOfXeyOZ/wV69wfT0aPiRg7YApdmcql5c8CwNbIHI3Et6nrqtzRH3vyrjaumSiyTPXBzT8GII6Qb4+YudlBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a0vvnFudTYe8tcx+7EWikTJN8P1DuO4VY9r8QMAAABQ=; b=Q4ptZaAErt4VLYnBH/p6OoUTVW+zD2Ka9ioLWemh/vBZwxn9Ppmf7eY6Ozke9q1QfvHfiNJfvjxaLZ/W3tUCf26UDVCnIOpi+ww4LRggKhPei+rTqHahnNoJMx8YtE4UrDak55wmjIW2cUyVrXdyiE3nCqqY3DakIBDWEYdExH8= Received: from AM6PR04MB6341.eurprd04.prod.outlook.com (2603:10a6:20b:d8::14) by AM6PR04MB6472.eurprd04.prod.outlook.com (2603:10a6:20b:f8::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.7; Mon, 10 Jan 2022 08:57:04 +0000 Received: from AM6PR04MB6341.eurprd04.prod.outlook.com ([fe80::b9f1:7371:3484:95b2]) by AM6PR04MB6341.eurprd04.prod.outlook.com ([fe80::b9f1:7371:3484:95b2%4]) with mapi id 15.20.4867.012; Mon, 10 Jan 2022 08:57:04 +0000 From: Ming Qian To: Andriy Gelman Thread-Topic: [EXT] Re: [FFmpeg-devel] [PATCH v4 2/3] avcodec/v4l2_context: resume the decoding process after source change event received. Thread-Index: AQHXlNgCOvJtJxiGT0qM+qlJCD//uaxQxWMAgAKOqaCAAPySgIAAAr8AgAXo/oCAApl+wA== Date: Mon, 10 Jan 2022 08:57:04 +0000 Message-ID: References: <20210819085533.1174-1-ming.qian@nxp.com> <20210819085533.1174-2-ming.qian@nxp.com> <20220102164106.ptu4eet7rmwla7bg@jackie> <20220104224813.cfsz6oafoi7a2qwp@jackie> <20220104225802.btiwwikprkeaqf2e@jackie> <20220108171315.zpuxgjxvu7lxswxa@jackie> In-Reply-To: <20220108171315.zpuxgjxvu7lxswxa@jackie> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8d4753e5-14c9-4090-8071-08d9d4172c74 x-ms-traffictypediagnostic: AM6PR04MB6472:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:751; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FO2wmP223WWRV5RQ7mRsYhCwau4Ddw4AZBKzlSmUDtRSKfMU9m2odjmaF6tXkrXrwuhSdoUwKIfet3LWTaj0Iot9uVmIICTUFp7E/RzcKh0HVw41youFPmljjhZDBZXVcVJUV8GFXRNEZaOwT30aRLfeUo6n/L3we277epq/EpXx5Ag0vDYJ7EQxCHhjatLtwq44/Tafx4SvMlhCFRaGTE6fuKnNSLoghmctMHr/WvAhtD9P4OycPJb8BtYeGaH2yKrChlBIrY1EQ2eA+3ZittW5ySoGHJzTTA+fECmFZJaswID5grmVmc50IpP9c8PlHw8HQhJ1rOQ++L4B95o7be9ZRO4YdtKh/R48X6zeqFKqgJtujMJcfz9ou5yG1GjzSj9an3kCGmTMOm+yj4CB3Pag6cqC48+R3kZcYK+oUILQm136YfUR4j8qi/Q+7AUpj3GZRumMNx1Foehw7MBcvF3nodaNo+M6ZXl7GpARGn/RR1mFzurBSPJOE+37siWRDrfSvjAkhGCM+zoBKEAiDclRe95+3RkFs8NJzKmPluQc3tGlkSW5lPHatl0KHIWjx5Izjge55tzhN6M7WYppAXy6/XFVMZi1sJEdD99T+6QXDSzi/pt9A+i14Gk0m83/lAsLTKQ8+b6Jt4FhgrPYB3+VqTaszTmKGh/AJzCBCt9zQZS/W2izbp4/X+BYwb63cTr+eoWRveK7OnmLWSnIasRf6+fIH45SYJ6g6Cp9cu0t8YeeK1MFNeJlR6QiIitO1obUmg6Qd4H/azECyMaUjSssAVLXjvvw+y+1bN0qWKGKoT5gECljjJFC8WZjE9/nbX/J4qqBB69bED8aO1SXCA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB6341.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(83380400001)(4326008)(76116006)(38100700002)(33656002)(38070700005)(71200400001)(122000001)(2906002)(44832011)(9686003)(186003)(55016003)(7696005)(6506007)(53546011)(26005)(86362001)(8936002)(966005)(316002)(508600001)(45080400002)(64756008)(66556008)(66946007)(66476007)(5660300002)(6916009)(52536014)(66446008)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WDkTgEoCaJkwJ4UhkKkZospGE6W2L3QFZtYLmwa0ouRBYaNIykKF5fAXPPkC?= =?us-ascii?Q?3aMHw2CHf+dxr+jZyLcB5GUAhMjPZ7K6BHjJ8pZp7u0y9CkUAwzAzmLwKyRn?= =?us-ascii?Q?T4U8+YW14C33RfWLWU7dxkG36+W2si40v6wC49OzIR79zZ/1DMKfuBiqk6G1?= =?us-ascii?Q?EJ+BEtR+i8ANY2SasIxu1us5HHGrszN7lZSn4k2O902ICeB2bTvV5h/EADtS?= =?us-ascii?Q?OgsanwCj30i1BSAqBDLzeMG5704Ku238bK8xinG5EYwxYrrng3K4rZ+VTtYF?= =?us-ascii?Q?NTxqAD+BR877Oob8eZ2R8a2wt5Bf4fvgPpxSHEg8/So07cdx7ZOduiw60zon?= =?us-ascii?Q?NBVeskwHf7bF0a3mF12wUtoCMPuNXrnzRQSAqjJTzKAkc3PtOueSMuH72Nk0?= =?us-ascii?Q?nW4q6Q06ZuM6kSPYv6hzlACtIBxAtyj99ICLuZtycx7zKh/8Hc9uAQYvurEM?= =?us-ascii?Q?vHLhzf+tUEv85YKpPYe2jnWkgluGkprTUVrwF6Ge2MoNgLpkoYlOthTy1KTS?= =?us-ascii?Q?t9QHzMPTIgldH+3YDF31KeQcCBlt9HfpgavKF8Dhwmrt7JI0iGXP0/E8T+hZ?= =?us-ascii?Q?sCuiMZUGSLbvEJdY0tIanbUkOE7d9o9P7aW7oO4lwlh8FM+jvAdQHPpz4vdA?= =?us-ascii?Q?EHBdN3gA83PhtS+dwJZw43sb9aQhbY2arTGhPj+UOMZbgqZivZAwNdGVTKXM?= =?us-ascii?Q?gmXDmDdyJHuXIHhTCf+twv+kHSnzxPCl9xj4SorjoTw8sdvxpVjKKG9mXs5m?= =?us-ascii?Q?iidm9RLC8qbzWZbB0GzSjOeo3cEeyMaQzcOhmTmGUR+iaYD/mmUNjJS+ZQXb?= =?us-ascii?Q?YG20p9BcFI/716SklraHQMhORHQA4htfWT/ib+EnFP4gBEYKGrEnI2jhb6+J?= =?us-ascii?Q?F2fYa2Yo0FZ73P+MtXg3stFHxxxvbfm8wrR7eQpUQsUT5Q/FjKTCF1O/AT2b?= =?us-ascii?Q?DPl2w3cXm2aXRU/DOd6NWfH+TAI0itY5u5mBCRaN5vNERcbKTpIE3wqJPbnD?= =?us-ascii?Q?3yE7btSIGlBLRhZ5S4qR3YzO6GFoM/CAEtscaV2hq4KfBl4dw/NrdcQy1u3/?= =?us-ascii?Q?PrQ65g4/d5Qg9Q6P3TWJsz8HptjqeC+ok30iahoCXv1MFalEGLbLtl1KXKlP?= =?us-ascii?Q?AAsQsDXVFKtG/cBW+loVEUtERqZtNl5oxiZQPXePasFSYCyr894/KLIvywyf?= =?us-ascii?Q?i/UmZCNFgZ4fNqrQ7Ew62OHxlwCb/9pnp+VY7VREYDUtH1xDY10NSeb+oiAK?= =?us-ascii?Q?fbDd1JwHytdhX/NyE1a51G3LEiOje2+ItSOBUkRvy7uNDOG/5rluWV7M16nQ?= =?us-ascii?Q?vI/1zYvYDrro4NLzHkEaQoxqvTGcPjahtzvVjaQlbPSnsgqEpAgCB1Ex+lBe?= =?us-ascii?Q?GgZMDOnMQi29gw6oryIxH9zOY9GoB4eB3t6xxDqMVVxLK8GDozzhDfUQCmVW?= =?us-ascii?Q?7ODQLVXFvsKuU+toLkKWbN1oZYyxqXTVggAD8xbvqiw2bF63wglNWElxoJhO?= =?us-ascii?Q?tZUsu2/2x50NuHsOT6bVzYd+3P+Bj4CPTLQai9OXnu2OmikiIEaWljUjF4hn?= =?us-ascii?Q?85uU0qw+gLpuN1ct2WXRi6FrJFRlARqm3AXZCNRS67PWd6VxZha/g01prCBR?= =?us-ascii?Q?JA=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6341.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d4753e5-14c9-4090-8071-08d9d4172c74 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2022 08:57:04.3867 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lU4i3pUwK51qWPipF28GGN9KHEscBVCyMLv/xfd1XhvavmQtkCJDeHju/LOrsmkY47Y+cK4iOiCs6f6nK+j78w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6472 Subject: Re: [FFmpeg-devel] [EXT] Re: [PATCH v4 2/3] avcodec/v4l2_context: resume the decoding process after source change event received. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: Andriy Gelman [mailto:andriy.gelman@gmail.com] > Sent: Sunday, January 9, 2022 1:13 AM > To: Ming Qian > Cc: FFmpeg development discussions and patches > Subject: Re: [EXT] Re: [FFmpeg-devel] [PATCH v4 2/3] avcodec/v4l2_context: > resume the decoding process after source change event received. > > Caution: EXT Email > > On Tue, 04. Jan 17:58, Andriy Gelman wrote: > > On Tue, 04. Jan 17:48, Andriy Gelman wrote: > > > Hi Ming, > > > > > > On Tue, 04. Jan 07:51, Ming Qian wrote: > > > > > > > > > -----Original Message----- > > > > > From: Andriy Gelman [mailto:andriy.gelman@gmail.com] > > > > > Sent: Monday, January 3, 2022 12:41 AM > > > > > To: FFmpeg development discussions and patches > > > > > > > > > > Cc: Ming Qian > > > > > Subject: [EXT] Re: [FFmpeg-devel] [PATCH v4 2/3] > avcodec/v4l2_context: > > > > > resume the decoding process after source change event received. > > > > > > > > > > Caution: EXT Email > > > > > > > > > > On Thu, 19. Aug 16:55, Ming Qian wrote: > > > > > > client need to resume the decoding process after it dequeues > > > > > > the source change event. > > > > > > no matter what's the return value of v4l2_resolution_changed(). > > > > > > if the client doesn't resume the decoding process, the decoder > > > > > > may keep waiting > > > > > > > > > > > > in documentation of v4l2 stateful decoder, we can see the > > > > > > following > > > > > > description: > > > > > > The client must continue the sequence as described below to > > > > > > continue the decoding process. > > > > > > 1. Dequeue the source change event. > > > > > > Important > > > > > > A source change triggers an implicit decoder drain, > > > > > > similar to the explicit Drain sequence. The decoder is > > > > > > stopped after it completes. The decoding process > must be > > > > > > resumed with either a pair of calls to > > > > > > VIDIOC_STREAMOFF() and VIDIOC_STREAMON() on > the > > > > > CAPTURE > > > > > > queue, or a call to VIDIOC_DECODER_CMD() with the > > > > > > V4L2_DEC_CMD_START command. > > > > > > 2. Continue with the Capture Setup sequence. > > > > > > > > > > Please also add that this fixes decoding of > > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F% > > > > > 2Fstreams > > > > > .videolan.org%2Fffmpeg%2Fincoming%2F720p60.mp4&data=04% > 7C01% > > > > > > 7Cming.qian%40nxp.com%7Cea94a9c4cc0643b0a41f08d9ce0eadc5%7C686e > > > > > > a1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637767384703207931%7CU > > > > > > nknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI > > > > > 6 > Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=X4rKQX19MQg1gO3ILiBCQ > > > > > qSLIvqovZLA95KKiyoVNzI%3D&reserved=0 on RPi4. > > > > > > > > > > > > > > > > Hi Andriy, > > > > What's wrong with this stream? Everything is normal on my side > when I play it using ffplay. > > > > > > > > > > > > I couldn't decode the file on the Raspberry Pi4. After enqueuing the > > > first few packets there was a dynamic resolution change event, and > > > the start decode command was not sent. This is fixed by your patch. > > > > > Also you may have to upgrade kernel to reproduce. It may have been > > working fine before this commit: > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > > > ub.com%2Fraspberrypi%2Flinux%2Fcommit%2Fb7e6b495eff31298ba4665f71 > b2414 > > > cc9a8f99c2%23diff-93defb6da917ce9bb43cb195d0e61f81673c5183ac75d63 > 1f3e1 > > > ee475a810dd6&data=04%7C01%7Cming.qian%40nxp.com%7Ce6b24805 > 32c6458d > > > 185b08d9d2ca2a81%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7 > C63777258 > > > 8014789133%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj > oiV2luMzI > > > iLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=RtRg%2Fu1ZggLSEf > lGvxy > > MutZv6Q%2B%2BX89O%2BE8DvXK0RHk%3D&reserved=0 > > > > I confirmed the above. > > I'll apply patches 1 and 3 from this series later tonight if no one objects. > > -- > Andriy Hi Andriy, What to do with the rest of the patches? Ming _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".