From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4D9D042541 for ; Wed, 5 Jan 2022 02:02:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9F6E368A883; Wed, 5 Jan 2022 04:02:26 +0200 (EET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown [40.107.20.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E0E3A689EC9 for ; Wed, 5 Jan 2022 04:02:20 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WB49diceoC2WKTa9vwOw1jPNrx0WoWBeJzsp3Yl1RSDnS1TVQNw0DlYA8NoN3cTbs/RCV97m1YUqYaJWbhRq+R52HVgP5R6gWgERazSePx8cGBVLvxOtuJMYjYcs4CaD25xDPgL3WJpFhEtIr+5AAityzoNXybE98NQxwC99fZRWF6lPAlK/e9A0Ca4ZhBVDAs7Lgoa2RTXK4C/M6sfvn88AIdVliPjEUu/RiDt9LJNSDXfUAKNBkBOUUweOF10ArNjkK7uftq6h+VrkJP9MQbq3+y6wOw3bS55AhyzIoR5Sj+k72IZ4Z42PhVF3fxI4A4Og3eeGowkfupfNo6UYMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gA6xARus5DZBIzL5GPcfWQuJS7OKodNbuR8/6YlEygk=; b=hXZbb8WdwLPSntch8ei8QT1lVDOowIYAEqJ9voNM+hpLUZej9Z94dGC5vY7HdAD1hsFq85ERZUSMI+n2iOHHFYtO9gp2f1snzFVXX64TK1CjiaORZkb3M2VXM6O9e1mYBQ83ta+lCMz7E1uphsjfi92X2AMg06gatDgczr3Pm3knAzXKFfpFB3vNUaYvKKtgWPBJ5kIuSP7Y486BJJSze+FZK5aFQd47oLt74ZS9Dq/wB2PNX0aoY4GinK0EhA8du3gaR6fuNcXrr/RzchiXiBx0GrIR9pLqUhsutDcTpckaOAsohblwA5LMTDhWSCCzfL0BnP7qhdV6ZGxd/saKrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gA6xARus5DZBIzL5GPcfWQuJS7OKodNbuR8/6YlEygk=; b=AlJUxAuMMxAgrC8jk6WPI5piFGO1+pp9YPCW61TUsM5UCZWjoueiNRlQNOblhOl+XE30BF3W80CV2T4WTvGDfHeOaqbw2Xm8I+6V7xDQhaRq0ENMlDH/sLVrUsVJ1Q3CFj9OYhy85idxXkNjQxyHN1jp3o5GIwJ8voMJYjrz4NU= Received: from AM6PR04MB6341.eurprd04.prod.outlook.com (2603:10a6:20b:d8::14) by AM6PR0402MB3927.eurprd04.prod.outlook.com (2603:10a6:209:19::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.15; Wed, 5 Jan 2022 02:02:08 +0000 Received: from AM6PR04MB6341.eurprd04.prod.outlook.com ([fe80::b9f1:7371:3484:95b2]) by AM6PR04MB6341.eurprd04.prod.outlook.com ([fe80::b9f1:7371:3484:95b2%4]) with mapi id 15.20.4867.007; Wed, 5 Jan 2022 02:02:02 +0000 From: Ming Qian To: Andriy Gelman Thread-Topic: [EXT] Re: [FFmpeg-devel] [PATCH v4 2/3] avcodec/v4l2_context: resume the decoding process after source change event received. Thread-Index: AQHXlNgCOvJtJxiGT0qM+qlJCD//uaxQxWMAgAKOqaCAAPySgIAAAr8AgAAyTSA= Date: Wed, 5 Jan 2022 02:02:02 +0000 Message-ID: References: <20210819085533.1174-1-ming.qian@nxp.com> <20210819085533.1174-2-ming.qian@nxp.com> <20220102164106.ptu4eet7rmwla7bg@jackie> <20220104224813.cfsz6oafoi7a2qwp@jackie> <20220104225802.btiwwikprkeaqf2e@jackie> In-Reply-To: <20220104225802.btiwwikprkeaqf2e@jackie> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0d33a1a7-77d2-4b12-244e-08d9cfef5de9 x-ms-traffictypediagnostic: AM6PR0402MB3927:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:605; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QaRQkB2ZeU7II28hz2ki0n7zjn4mncD6lqZPtWj7C96eohR4hTIUbVko55RySArBobKvlpEKeL3Mq7vsk6OMgVew2GG4GMe2Uq/OWClzxhxgYRaYO3mOdSx+G2zjTk4OsnsX7wW0jwEwCZHpo4fqLMFeEUxxskFNBo1bnEjSoRuFj6ZfCRlAO9rrVUYIKefrRytw6miGlmbAbayPfTx8JBkoZft5iisHtaW1Ckf5TMbaoqkJMfRdReZxH1/T+i0p0iWUBVOLINBnm9j0rIXUHpk5xnigdNIUWHz3/fQ3omDsKTineSPYMwgJT6Km1sVQX+AHdm1P2qk2be1JWVq5jGTmOJqjGvZGPR4y5O8d9/LRj2ALIrEqZaqPzIqtuM6/mqPkfEvq1HwzWO83wWz9DfhVxm9RcM6wQAk7bnJsNaX7tsCWVXb/GEyxGRJ+ILcZWrBTn7MHucPSPkrYej5FVlYhWrX/IRQTMv5QfsQMuPNrfzPtmb07Nk+3ZbU78f6KEzLs68NaaLBfYtd8V1trSZ6cy6EMboLyjlZARpxn5I60YJwd8L2mULoWB9o+247hopFeKO6sUtEMgk3xOPaOtVZanRsE8Curab73Yz6Ge5bP2EhsF7psU/Kepwb5FqDWVj1P+uHjwBuzzVymWZAjJeARusysi3yghy8kRhpLExsxLy3esOj6smMGso41ewlF2lQVQja0rN3u6lIN3ejBydlPUBhweJ6av2uL5F/GxpkmNpVZpm2iyzTQwnZ94U5qwuwdNPUworD0c4Ng7AfnpDYHrXLhTBU0uDewUrP2VlKxytfIpLYChAc7b/kiLyypp/i1LebWckdFZ3HDDqPtQQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB6341.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(44832011)(55016003)(5660300002)(38070700005)(33656002)(6506007)(8936002)(86362001)(316002)(66446008)(9686003)(71200400001)(45080400002)(966005)(7696005)(66946007)(122000001)(2906002)(52536014)(508600001)(8676002)(186003)(64756008)(66476007)(26005)(66556008)(53546011)(6916009)(38100700002)(83380400001)(76116006)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eKRXSCj/y49/xu2ZLLH33nDvslrDtz/LFCC3oJavR/3jJRfNKkg7BHa0t7Rp?= =?us-ascii?Q?ksWrZ/yzZeL360FGUFLDZYe21CR9Y7z1x+PDxuoH5YhZZbL6fDOlHPcYm4yL?= =?us-ascii?Q?WmjbZR2z3ntlXWHMjb2DUsOsoXI0psHOVZDBITEbS40we1miRXvYg3jNUhE1?= =?us-ascii?Q?8jVe8zFMe3QgEeyBdL5Re+dC1Yv6XwhLIDE8J/BZGjiN795jDNxmzm1o91UN?= =?us-ascii?Q?g0crCok3kLKOgL1WqiQz9rDCBustFpPn/VceESGtRz8B5lahvyDFxD99A7Hj?= =?us-ascii?Q?5fBiwc6CoFKopCk8IvpQkp25I7kByj6Lzg8AN63IZl2FFuJoy3Oac9rq7FOT?= =?us-ascii?Q?oQcg/QUBrokCelJPiRRhuFDhPr3LO/VW0uIcrTXpb0hNbeJGGSQUqFyu/EmU?= =?us-ascii?Q?HgWDq0i6ebT0H2jhg2xK6Eh3YxXrMyiPPvEDWlNZUG216voPqMajEDkDLyO5?= =?us-ascii?Q?BIdcVxBsYEsTfrvb7FcbAgNoFALWfPi/QXruky0c1MjHWt0W0hICMj3eESbX?= =?us-ascii?Q?LYKg84atC8UdmN11d0SOlA2+4Tk8yjlV32XGmSLcD4byyecCctelZqvTlIE4?= =?us-ascii?Q?fegQFQwoPjpDser5MFMHQ9r9zSlkPc+itiwWxQxd38qdQbsL06ZJot2vJ8GM?= =?us-ascii?Q?X2B+73ulJZdzq7koe2Xa1sqMjseBKgcWmBoveLBu0Nvs8kqIUn/OxKFK162l?= =?us-ascii?Q?T+X2fq/p8ao76spRXbaDDr8UPTH9K3vV20qOiemKXsMhfcjS3RqnvlxHLTnF?= =?us-ascii?Q?K/kW9o7nZ6MhPYTLrUz2pwLU0ee4OQ/bopVQZ8DzIc8HnYD/HnhOm2TPVJUQ?= =?us-ascii?Q?KUk1oY6QkYWD/TWcIpeXWQGCW8z7Qh/lDGXvjwTsdE6npf2eVAnAxDCd6l39?= =?us-ascii?Q?hXXxr/Um39DPBgl4QeSYPqIjDYY5/8Xv1jOOGTJHTcpXBtyedD/azarm9/JF?= =?us-ascii?Q?AcBekQz69xHzCxjMPHsSdh7RrrJUd3XdEYmTrMONtrMw0BX9ycwjP2tty9q6?= =?us-ascii?Q?2bEDYOnVDCe7b9gWQs5hPHBcBxtSBuLaLkyIYHnORziBvoi5uTR1pKGMBTP/?= =?us-ascii?Q?pDxVu/ljprbqBUa6ETx2Lu0tm1R0WM4FcMXL2X+BNwTz0zLuAhDmskt0EkNC?= =?us-ascii?Q?jpk6EHWeuV/mWDeFfC7I/wYaQarA0tkUmPwEpg+VyMGdPLYjuj8Ttk736X6g?= =?us-ascii?Q?+MYs7G3PRuBMO3tSzhSlEJDs+jal2PRwqqlDuWBC0b1OfFhkUpc6rmx8STIy?= =?us-ascii?Q?VBKThxXi/LZTECsA9/YOzh6/0BDUhHI5EeYly9Lp/5Q/w21HBLKRe7RABsCp?= =?us-ascii?Q?qJ4Ns6FjeA9haQuOqWi/7ZY7ctWYGNvytfp5uPP6+3zZc0JwA/E2x/bRcMTd?= =?us-ascii?Q?YvGBAu6VK/OMdFT8MDNzKTJRkn/gSCRLMSO52sLOKicKarzO5Xplm9s8RbNV?= =?us-ascii?Q?7lUyQMxzXe9g40sUgI2Fnj0EUgdIp+rApv0kLNjoKIgG9KYqAVpLOxhPH7Gn?= =?us-ascii?Q?Y8nw0pSNLHEX6XmSJ6q1XInk7jomsR94Pk9QpugN9LlZ5tqALhpBP0GGjjLQ?= =?us-ascii?Q?Z2U5ktEFKRRr8dheRrkjNnItaP2581zVwcfPug4SST9TIUQo1kwz2S64/9Lj?= =?us-ascii?Q?wfZcqsHfdeXAG03dW4U3D0c=3D?= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6341.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d33a1a7-77d2-4b12-244e-08d9cfef5de9 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2022 02:02:02.8548 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mkBysy+v3Meojzver9GaPGop7XJtEUiyVkUx0E8PpCrN7Yf61XTVvjvPgu/8ZMjSX1bGOPj6Hcbv5Q5d1OMMsw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3927 Subject: Re: [FFmpeg-devel] [EXT] Re: [PATCH v4 2/3] avcodec/v4l2_context: resume the decoding process after source change event received. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: Andriy Gelman [mailto:andriy.gelman@gmail.com] > Sent: Wednesday, January 5, 2022 6:58 AM > To: Ming Qian > Cc: FFmpeg development discussions and patches > Subject: Re: [EXT] Re: [FFmpeg-devel] [PATCH v4 2/3] avcodec/v4l2_context: > resume the decoding process after source change event received. > > Caution: EXT Email > > On Tue, 04. Jan 17:48, Andriy Gelman wrote: > > Hi Ming, > > > > On Tue, 04. Jan 07:51, Ming Qian wrote: > > > > > > > -----Original Message----- > > > > From: Andriy Gelman [mailto:andriy.gelman@gmail.com] > > > > Sent: Monday, January 3, 2022 12:41 AM > > > > To: FFmpeg development discussions and patches > > > > > > > > Cc: Ming Qian > > > > Subject: [EXT] Re: [FFmpeg-devel] [PATCH v4 2/3] avcodec/v4l2_context: > > > > resume the decoding process after source change event received. > > > > > > > > Caution: EXT Email > > > > > > > > On Thu, 19. Aug 16:55, Ming Qian wrote: > > > > > client need to resume the decoding process after it dequeues the > > > > > source change event. > > > > > no matter what's the return value of v4l2_resolution_changed(). > > > > > if the client doesn't resume the decoding process, the decoder > > > > > may keep waiting > > > > > > > > > > in documentation of v4l2 stateful decoder, we can see the > > > > > following > > > > > description: > > > > > The client must continue the sequence as described below to > > > > > continue the decoding process. > > > > > 1. Dequeue the source change event. > > > > > Important > > > > > A source change triggers an implicit decoder drain, > > > > > similar to the explicit Drain sequence. The decoder is > > > > > stopped after it completes. The decoding process must > be > > > > > resumed with either a pair of calls to > > > > > VIDIOC_STREAMOFF() and VIDIOC_STREAMON() on > the > > > > CAPTURE > > > > > queue, or a call to VIDIOC_DECODER_CMD() with the > > > > > V4L2_DEC_CMD_START command. > > > > > 2. Continue with the Capture Setup sequence. > > > > > > > > Please also add that this fixes decoding of > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F > > > > streams > > > > .videolan.org%2Fffmpeg%2Fincoming%2F720p60.mp4&data=04%7 > C01% > > > > > 7Cming.qian%40nxp.com%7Cea94a9c4cc0643b0a41f08d9ce0eadc5%7C686e > > > > > a1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637767384703207931%7CU > > > > > nknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6 > > > > > Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=X4rKQX19MQg1gO3ILiBCQ > > > > qSLIvqovZLA95KKiyoVNzI%3D&reserved=0 on RPi4. > > > > > > > > > > > > Hi Andriy, > > > What's wrong with this stream? Everything is normal on my side > when I play it using ffplay. > > > > > > > > I couldn't decode the file on the Raspberry Pi4. After enqueuing the > > first few packets there was a dynamic resolution change event, and the > > start decode command was not sent. This is fixed by your patch. > > Also you may have to upgrade kernel to reproduce. It may have been working > fine before this commit: > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. > com%2Fraspberrypi%2Flinux%2Fcommit%2Fb7e6b495eff31298ba4665f71b2 > 414cc9a8f99c2%23diff-93defb6da917ce9bb43cb195d0e61f81673c5183ac75 > d631f3e1ee475a810dd6&data=04%7C01%7Cming.qian%40nxp.com%7C > 64fa84ae1325497b2b4408d9cfd5aabd%7C686ea1d3bc2b4c6fa92cd99c5c301 > 635%7C0%7C1%7C637769338865335050%7CUnknown%7CTWFpbGZsb3d8e > yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D% > 7C3000&sdata=ZCuu2FL5EusXxilM%2BkdpLjQDXnvVhFIXsKeIVHPKWHY% > 3D&reserved=0 > I got it, but I didn't have a Raspberry Pi4 on hand right now, maybe I can test it again after I get one. I make this patch according the v4l2 decoder specification and test it on NXP i.MX 8Q and i.MX8M > -- > Andriy _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".