[FFmpeg-devel] [PATCH] Fix failure to initialize ddagrab if adapter ID is specified

["Jøger Hansegård" <joger.hansegard@qt.io>]

[-- Attachment #1.1: Type: text/plain, Size: 2064 bytes --]

Fix failure to initialize ddagrab if adapter ID is specified.

If an adapter ID is specified when initializing hw device for d3d11va,
ddagrab does not work on Windows 11. This prevents capturing screens
connected to a secondary adapter.

Failing command:
    ffmpeg -init_hw_device d3d11va:0 -filter_complex ddagrab=0,hwdownload,format=bgra -c:v h264_mf output.mkv

The reason is that d3d11va_device_create uses CreateDXGIFactory to
create a DXGIFactory 1.0. This causes init_dxgi_dda's call to
IDXGIOutput5_DuplicateOutput1 to fail because it is only supported on
DXGI 1.1 and higher.

The fix is to always crate DXGI factory using CreateDXGIFactory1 as
proposed in this patch.

Fixes: #10385
---
 libavutil/hwcontext_d3d11va.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/hwcontext_d3d11va.c
index aa50538d64..fa8d5410f2 100644
--- a/libavutil/hwcontext_d3d11va.c
+++ b/libavutil/hwcontext_d3d11va.c
@@ -62,7 +62,7 @@ static av_cold void load_functions(void)
         return;

     mD3D11CreateDevice = (PFN_D3D11_CREATE_DEVICE) GetProcAddress(d3dlib, "D3D11CreateDevice");
-    mCreateDXGIFactory = (PFN_CREATE_DXGI_FACTORY) GetProcAddress(dxgilib, "CreateDXGIFactory");
+    mCreateDXGIFactory = (PFN_CREATE_DXGI_FACTORY) GetProcAddress(dxgilib, "CreateDXGIFactory1");
 #else
     // In UWP (which lacks LoadLibrary), CreateDXGIFactory isn't available,
     // only CreateDXGIFactory1
--
2.40.1.windows.1



Jøger Hansegård
PhD
Senior R&D Manager
The Qt Company
Sandakerveien 116
0484 Oslo
Norway
joger.hansegard@qt.io<mailto:joger.hansegard@qt.io>
+4792642127
www.qt.io<https://www.qt.io>

[cid:image001.png@01D9CA31.9D2C6180]<https://www.qt.io/>
[cid:image002.png@01D9CA31.9D2C6180]<https://www.facebook.com/qt/>
[cid:image003.png@01D9CA31.9D2C6180]<https://twitter.com/qtproject>
[cid:image004.png@01D9CA31.9D2C6180]<https://www.linkedin.com/company/qtgroup/>
[cid:image005.png@01D9CA31.9D2C6180]<https://www.youtube.com/QtStudios>



[-- Attachment #1.2: image001.png --]
[-- Type: image/png, Size: 3186 bytes --]

[-- Attachment #1.3: image002.png --]
[-- Type: image/png, Size: 460 bytes --]

[-- Attachment #1.4: image003.png --]
[-- Type: image/png, Size: 890 bytes --]

[-- Attachment #1.5: image004.png --]
[-- Type: image/png, Size: 626 bytes --]

[-- Attachment #1.6: image005.png --]
[-- Type: image/png, Size: 656 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".