From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BBFDC40247 for ; Tue, 21 Dec 2021 00:06:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F1F0868AFD9; Tue, 21 Dec 2021 02:06:49 +0200 (EET) Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BA1FB688384 for ; Tue, 21 Dec 2021 02:06:43 +0200 (EET) Received: by mail-il1-f172.google.com with SMTP id b1so3003567ilj.2 for ; Mon, 20 Dec 2021 16:06:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rcombs.me; s=google; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=6DGxIwmNBsCfWhCPHRZjqLDI6bXuur/4LByh01kEbGs=; b=AT2Q4gyX4/yYska9JTuQNZUku+y4pW+TLtZD+sdrWAb3vUAom3o3eAu22zIdWEd+ut lMZpAFUB6WtyxK4VPBV3dQr43eZwqHqV4KjXaSQi8IV6AUETwCCBgAsOmWeSAxT8qTX7 GRFWnxw0J2nroOiIfzMmQmt1bY5bHs5cXtNONA8pUt+fikZMw5hAc4Imc+U6krNoTrZk DmvVeP/A8WK+x1Jk2tOgEBcOtT19WA269W2+v3AdKS9W8w+7BTFXY9en7zpuYAcDawEP EloqyotW3mmOwt1h3HpPK9X5QctI89bwH2jBkzDY0lIEbkj8kAMVeedXL4ahWxZriyKc DIMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=6DGxIwmNBsCfWhCPHRZjqLDI6bXuur/4LByh01kEbGs=; b=bJA5eRFezbXWNpsNXPkjdiTbyrIc53JAS4yp6EMq+fEI++1XuUdxlaBYnFR5h9DLjI x7OHp514QItN0Vf8qcpyUC0/5pcQ0zHtgR9iKTNKlFGgpMLXqx3lrSeGohibtokdv8p7 xY97hDVCOwxblWqSbJgUJ+7JDy+oexMXfy6nMORwA54H9RyMArk6CkVX0RGg3JsX9cRw z2MFECqccOkII1yRPr9U/RP/p/drkBHjXNIAbRAeS3wlQYzilIfO/pv7lpSCSyqpDYgU 1qXBvzobwkkZDcgde0NknUsrAa1feOY3arDCTLq2PM7K4SNk9HLREExRdnlk5HsR2SSz Cg3A== X-Gm-Message-State: AOAM5330wYnnm3ELsEWsRgXPqDje54azGLBN3dHjVt9465lu7IxEZHEV gNha35/LBw0cysuMA0Smqmz/ X-Google-Smtp-Source: ABdhPJxhE4ZfXGHOgGZxTYnUMIhWbaKeFg7NSH//YVzcdB5mh08V1umcNM1ndynfFwAd7c4awS+gtw== X-Received: by 2002:a92:c609:: with SMTP id p9mr253639ilm.49.1640045202063; Mon, 20 Dec 2021 16:06:42 -0800 (PST) Received: from smtpclient.apple ([2601:243:2000:5ac:f02b:6c4e:f1fb:3dd6]) by smtp.gmail.com with ESMTPSA id o12sm11630069ilu.82.2021.12.20.16.06.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Dec 2021 16:06:41 -0800 (PST) From: Ridley Combs Message-Id: Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) Date: Mon, 20 Dec 2021 18:06:40 -0600 In-Reply-To: To: "Helmut K. C. Tessarek" References: <5fb60616-5ded-1b3a-255c-14deb44924d9@evermeet.cx> X-Mailer: Apple Mail (2.3693.40.0.1.81) X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: ffmpeg-devel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Try with this as well: https://gist.github.com/499380d8ea03a86fc89eb48803ff7b2e > On Dec 20, 2021, at 17:49, Helmut K. C. Tessarek wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > Thanks for the rwply. > > On 2021-12-20 18:25, Ridley Combs wrote: >> Could you try with this patch and let me know if it works for you then? >> https://gist.github.com/7362df8a689c41b9174ac50fdeda3e43 > > I've applied your patch and get the following now: > > CC libavfilter/scale_eval.o > CC libavfilter/scene_sad.o > libavfilter/metal/vf_yadif_videotoolbox.metal:47:1: error: constant sampler > must be declared constexpr > const sampler s(coord::pixel); > ^ > constexpr > libavfilter/metal/vf_yadif_videotoolbox.metal:122:14: error: use of > undeclared identifier 'max3' > T diff = max3(tdiff0, tdiff1, tdiff2); > ^ > libavfilter/metal/vf_yadif_videotoolbox.metal:152:9: note: in instantiation > of function template specialization 'temporal_predictor' requested here > temporal_predictor(A.x, B.x, C.x, D.x, E.x, F.x, > ^ > libavfilter/metal/vf_yadif_videotoolbox.metal:125:18: error: use of > undeclared identifier 'max3' > T maxi = max3(p2 - p3, p2 - p1, min(p0 - p1, p4 - p3)); > ^ > libavfilter/metal/vf_yadif_videotoolbox.metal:126:18: error: use of > undeclared identifier 'min3' > T mini = min3(p2 - p3, p2 - p1, max(p0 - p1, p4 - p3)); > ^ > libavfilter/metal/vf_yadif_videotoolbox.metal:217:12: error: no matching > function for call to 'temporal_predictor' > return temporal_predictor(A, B, C, D, E, F, G, H, I, J, K, L, > ^~~~~~~~~~~~~~~~~~ > libavfilter/metal/vf_yadif_videotoolbox.metal:233:16: note: in instantiation > of function template specialization 'yadif_compute_temporal' > requested here > return yadif_compute_temporal(cur, prev, cur, next, next, > spatial_pred, params.skip_spatial_check, pos); > ^ > libavfilter/metal/vf_yadif_videotoolbox.metal:265:23: note: in instantiation > of function template specialization 'yadif' requested here > pred = float2(yadif(dst, prev, cur, next, params, pos)); > ^ > libavfilter/metal/vf_yadif_videotoolbox.metal:108:3: note: candidate > template ignored: substitution failure [with T = float] > T temporal_predictor(T A, T B, T C, T D, T E, T F, > ^ > 5 errors generated. > make: *** [libavfilter/metal/vf_yadif_videotoolbox.metal.air] Error 1 > make: *** Waiting for unfinished jobs.... > libavfilter/metal/utils.m:33:21: warning: instance method '-supportsFamily:' > not found (return type defaults to 'id') [-Wobjc-method-access] > if ([device supportsFamily:MTLGPUFamilyCommon3]) { > ^~~~~~~~~~~~~~ > libavfilter/metal/utils.m:33:36: error: use of undeclared identifier > 'MTLGPUFamilyCommon3' > if ([device supportsFamily:MTLGPUFamilyCommon3]) { > ^ > 1 warning and 1 error generated. > make: *** [libavfilter/metal/utils.o] Error 1 > Error compiling ffmpeg... > >> If you can test actual deployment on a 10.9 or 10.10 system that'd be >> great. > > Unfortunately I don't have a 10.9 or 10.10 system. I compile on macOS 1.14 > with export MACOSX_DEPLOYMENT_TARGET=10.9 > > Cheers, > K. C. > > - -- > regards Helmut K. C. Tessarek KeyID 0x172380A011EF4944 > Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944 > > /* > Thou shalt not follow the NULL pointer for chaos and madness > await thee at its end. > */ > -----BEGIN PGP SIGNATURE----- > > iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmHBFpsACgkQvgmFNJ1E > 3QDapA//WmxnoAqIGCqliaSIUpRkL/KxhSpj9ULJzL1h9yw6Ls0DIYT39Pa66hTk > IABKgLiTNxe1hNTC9kbXf6HdNqJw7KGGUlCGu777RHhh7wySq355g7b89f1wrSJa > 1RwCkb9EoyC/DzeSnayDk6oOO7duJxCibkdTXEsYW9VgA9QGSriTHIRSG666UgXO > NC6EyjiOfGqlVkTr9Ott+r2t30H/0faihttbIhLwV6y/Dd/vx4mdG4y61B0PXLX1 > rAQwDP9GYkAa302XLeLSTTJ/IHzsV7xD1eE+I3QcB63gbzKlujfbSBiOf9Czv6Vs > M1xoRbcqYkTi7zK45t7w+FuAMn/her/P5cCjmXbEQIHBZEfX3r2MKtkdIAhHsUPl > vDvR7Zmi90gRorQnyQ1fy/LaIcZt6E6CFPKQrIVkBsOnIuXvnrx4fxsvo4rYO32p > goyhtmBMyg9zIZy4eSUn/3M5NKMifgSQrYdUIIKrJZr4ENesKTGB/EZXS30v5VF4 > 7GrObWDT1oR+VoUiMSYrGPSBlF8R/NHJGU/BL7iVFtF7CfFRnHmfgzyII8RlS6G+ > V5stD8eKNr/8fzI3sjQfiROEMtLFKJz4Zkf6qmBT7zeDizNJp/xaGc2egsC7LMzX > or7vCtN6YKPXhQimhsrxDvIXLdvt2ZsCwcbNpq5ZzEMi8mDgwCs= > =DJOy > -----END PGP SIGNATURE----- _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".