From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 2E74B5028B for ; Thu, 10 Jul 2025 11:12:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 2AD9268F1AB; Thu, 10 Jul 2025 14:12:05 +0300 (EEST) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id C7B0968F1A5 for ; Thu, 10 Jul 2025 14:11:57 +0300 (EEST) Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-ae3ec622d2fso136920766b.1 for ; Thu, 10 Jul 2025 04:11:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752145917; x=1752750717; darn=ffmpeg.org; h=mime-version:references:in-reply-to:message-id:date:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=iDWih/9VLO437/Jv0x/n7p2jlOg+o8KDOQkYm0fQ+Ck=; b=mOIDw1oABXwMmr613ewQ8LCIElUNVVOy1GKzQB1wkdoYBechO5m2R0UVTquSXPcJSw 5x5RUERBmDWz+enE+P7GDguHr2CLQocItobIj7Qs/Fo7tQKt/pHEUCN/i8H2Hu13IMxh F1RxxD7gznKOt+3558veeJZpRC+tnDdbrQfKLWfiNr4O3/3p6Q2ih0Z4Nk+YfClequSG osS7TK3fhLXvEA7RYI3mnHNlIrisTHemocagf8pyTNcmoW6J5i0tC6g/jh7SdtlO65iS DqbVYaueyjj/hlhy8D4EpT7L6wyVR0xXSheCmHl425Oh97uukg/3kZRuCWeIk69QiKHs x1ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752145917; x=1752750717; h=mime-version:references:in-reply-to:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iDWih/9VLO437/Jv0x/n7p2jlOg+o8KDOQkYm0fQ+Ck=; b=aKoYaHhtXPceafTOQ7tavVPtRN9kUyMwdG6+8WLKtVLcmyMD4gKzfm/qkpahP1JU0M MrD68ese8FARiX2JgvmyAclnJZJompN+nliYhEpdzY3m13Io+cKTF/q/acRFLuZdYcRq NaMKLEFhXkJvqsZm0tcb+doP0uXcNvNdogGgmHTZIvyrElKclNbRrAUx2LNHYFqB4oqZ tE3Y8ff4JQr0mejgwbADGOm/+HQNVmHivVkN8MzhAlVyvZSNSxVoC0i7fHkF4ej3egTS PMlwzVeAS7Rj7+cAteeg8lNyw05Fba7ZM0UQVQdedgs2Iot4eHxkIjGpENoY6d9OWZIF cMfw== X-Gm-Message-State: AOJu0YwMClbfuMGHJLzwpR/wtDuFWENuBqmxCQjdhikBJeODvq4Sc+0n TrhZvEbhzzFqnXQd+PC2mprx6ED4b/cH7aHD8dO/UUq97/LGbTMmeDRcGRnyKQ== X-Gm-Gg: ASbGncu/urkG6BOqjWe/iJbOJypP6iOzv/ZWBjxyJHbGy/pM3Gxr3WEJmxxAnHrxSgK 1RdzCg39j4CPzt+QQYEPV+8YgX8/O/YUnV3OdqTl/rmIr0LTgBoVI8MHn1pu+6SlsGxo1ytRCPk HeAZz3ZOcoBGam6ORwrw4rV+ttTIigg14UF/7R7QCABUz34/WMdtKrDygJmrI5xebHOlFrNndh4 nGHyVRuUQLm2tZelBp0tdSy9cSU2TLfv8K+uad5fVi02GT8zNcPIQa/U7tmksjg5uRtYjm6BWfA UeKnrapeM5ParmJkJco3OSTA0T6kaY5vgRS3nLn9B2wBkfxYrz4QM5nHj+ZDiQxKDDnqs2hpslc CZTxBM89o7iBPqJELYZQAIz1o48MlfyFzEeieTvE+nMaEe00ugFzl2o/L2PwNfvmcw+5Jg1HP4G s= X-Google-Smtp-Source: AGHT+IFj1wGhG6JA+1gL4uGImdFm60kFpFqpU5NIUSZwI+fRsuLEKAG5U+bcetVEyTp7ehC/xpYrYA== X-Received: by 2002:a17:907:1ca5:b0:ae3:24c:6a21 with SMTP id a640c23a62f3a-ae6e6f12c40mr214292466b.26.1752145916773; Thu, 10 Jul 2025 04:11:56 -0700 (PDT) Received: from [192.168.178.143] (p200301023701fa002500dc3b45b00394.dip0.t-ipconnect.de. [2003:102:3701:fa00:2500:dc3b:45b0:394]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e7e910d2sm113780066b.2.2025.07.10.04.11.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Jul 2025 04:11:56 -0700 (PDT) From: Marvin Scholz To: FFmpeg development discussions and patches Date: Thu, 10 Jul 2025 13:11:55 +0200 X-Mailer: MailMate Free Mode (2.0r6222) Message-ID: In-Reply-To: <7006F9A9-B3C3-402A-972A-14C5EBA7F601@gmail.com> References: <3b06ac6e75c04d1cd160c91902aab8901f5c7dda.1751964469.git.pross@xvid.org> <7006F9A9-B3C3-402A-972A-14C5EBA7F601@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCHv2] avcodec/adpcm: squelch uninitialized variable warnings X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 8 Jul 2025, at 21:16, Marvin Scholz wrote: > On 8 Jul 2025, at 10:49, Peter Ross wrote: > >> Fixes CID1655273 and CID1655274. >> --- >> v2: Use the new av_unreachable() macro >> >> libavcodec/adpcm.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c >> index 92ab248f3d..83ef7c780a 100644 >> --- a/libavcodec/adpcm.c >> +++ b/libavcodec/adpcm.c >> @@ -877,6 +877,8 @@ static int adpcm_sanyo_expand3(ADPCMChannelStatus *c, int bits) >> add = (11 * c->step) >> 1; >> c->step = 3 * c->step; >> break; >> + default: >> + av_unreachable("There are cases for all control paths when bits is 3-bit"); >> } >> >> if (sign) >> @@ -934,6 +936,8 @@ static int adpcm_sanyo_expand4(ADPCMChannelStatus *c, int bits) >> add = (25 * c->step) >> 1; >> c->step = 5 * c->step; >> break; >> + default: >> + av_unreachable("There are cases for all control paths when bits is 4-bit"); >> } >> >> if (sign) >> -- >> 2.47.2 >> >> -- Peter >> (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) > > LGTM, thanks! > Pushed as 853ad9e77e1d6c2585aaff80ea371bc4dbf4bfa2 >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".