From: Marvin Scholz <epirat07-at-gmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCHv2] avcodec/adpcm: squelch uninitialized variable warnings
Date: Thu, 10 Jul 2025 13:11:55 +0200
Message-ID: <A32CA120-3D8A-4260-842F-C69FA74088F0@gmail.com> (raw)
In-Reply-To: <7006F9A9-B3C3-402A-972A-14C5EBA7F601@gmail.com>
On 8 Jul 2025, at 21:16, Marvin Scholz wrote:
> On 8 Jul 2025, at 10:49, Peter Ross wrote:
>
>> Fixes CID1655273 and CID1655274.
>> ---
>> v2: Use the new av_unreachable() macro
>>
>> libavcodec/adpcm.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c
>> index 92ab248f3d..83ef7c780a 100644
>> --- a/libavcodec/adpcm.c
>> +++ b/libavcodec/adpcm.c
>> @@ -877,6 +877,8 @@ static int adpcm_sanyo_expand3(ADPCMChannelStatus *c, int bits)
>> add = (11 * c->step) >> 1;
>> c->step = 3 * c->step;
>> break;
>> + default:
>> + av_unreachable("There are cases for all control paths when bits is 3-bit");
>> }
>>
>> if (sign)
>> @@ -934,6 +936,8 @@ static int adpcm_sanyo_expand4(ADPCMChannelStatus *c, int bits)
>> add = (25 * c->step) >> 1;
>> c->step = 5 * c->step;
>> break;
>> + default:
>> + av_unreachable("There are cases for all control paths when bits is 4-bit");
>> }
>>
>> if (sign)
>> --
>> 2.47.2
>>
>> -- Peter
>> (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
>
> LGTM, thanks!
>
Pushed as 853ad9e77e1d6c2585aaff80ea371bc4dbf4bfa2
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-07-10 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 8:49 Peter Ross
2025-07-08 19:16 ` Marvin Scholz
2025-07-10 11:11 ` Marvin Scholz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A32CA120-3D8A-4260-842F-C69FA74088F0@gmail.com \
--to=epirat07-at-gmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git