From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D643242551 for ; Fri, 18 Mar 2022 13:57:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 90A9868B159; Fri, 18 Mar 2022 15:57:08 +0200 (EET) Received: from shout02.mail.de (shout02.mail.de [62.201.172.25]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2015068B0C3 for ; Fri, 18 Mar 2022 15:57:02 +0200 (EET) Received: from postfix01.mail.de (postfix02.bt.mail.de [10.0.121.126]) by shout02.mail.de (Postfix) with ESMTP id 984E4A0D1A for ; Fri, 18 Mar 2022 14:57:01 +0100 (CET) Received: from smtp04.mail.de (smtp04.bt.mail.de [10.0.121.214]) by postfix01.mail.de (Postfix) with ESMTP id 7EDFFA03C1 for ; Fri, 18 Mar 2022 14:57:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mail.de; s=mailde202009; t=1647611821; bh=3xYI3WIdEDPnwjg1lyzwpamDpYAPJ1jWOmJ2MEQovCg=; h=From:To:Subject:Date:Message-ID:From:To:CC:Subject:Reply-To; b=RWw4HbS9QD0hePt7qJYcXtvkrFn8+GWBD1YQYWqQIkkp7rvdYOuMCCi5L5feLAbwt vwDFNeS1am/K9bZpiHJr4xs3guTzS5LMEescJxi34go1jf3hGycqMrSJcdQAUhCUHi ImSlUzMu74ewCQeRiMGXKWe9oi5qBVHWxozWOLLPnOVMba9KwMtwi7HyUroH6Upuz5 5VvKZooZiGX/pa2bWC08hsIdFXdTYKtmUD69CZD28faXBFzkAr5Z5+DuZcFnpk4g/P gJYnbz62Y8tFbOgPyC+6zwgQr/Dd6AMHCZoa2xycPtvzNAdXFXyz5xOAXv4vSYVe2i xCD1WZWDJrHoQ== Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp04.mail.de (Postfix) with ESMTPSA id CADA2C0064 for ; Fri, 18 Mar 2022 14:57:00 +0100 (CET) From: "Thilo Borgmann" To: ffmpeg-devel@ffmpeg.org Date: Fri, 18 Mar 2022 14:56:59 +0100 Message-ID: In-Reply-To: <00b63948-b610-bd38-81fb-95c85235e2f3@mail.de> References: <20210115045832.76405-1-borbarak@fb.com> <3fa8e9b2-6824-eb3a-2390-22fd024efa9f@mail.de> <164363001951.23111.4989616914372511566@lain.red.khirnov.net> <14fa7592-4acc-2186-335b-56ea500f9663@mail.de> <2621fec9-555f-c977-b378-dbfd7a6d115e@mail.de> <18f95a99-7efd-1d0c-a824-468ef9b83caa@mail.de> <00b63948-b610-bd38-81fb-95c85235e2f3@mail.de> MIME-Version: 1.0 X-purgate: clean X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate: clean X-purgate-size: 3204 X-purgate-ID: 154282::1647611821-000016C9-D5A641D4/0/0 Subject: Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12 Mar 2022, at 10:06, Thilo Borgmann wrote: > Am 09.03.22 um 18:31 schrieb Paul B Mahol: >> On 3/8/22, Thilo Borgmann wrote: >>> Am 07.03.22 um 20:06 schrieb Paul B Mahol: >>>> On 3/7/22, Thilo Borgmann wrote: >>>>> Am 06.03.22 um 22:25 schrieb Paul B Mahol: >>>>>> On 3/6/22, Thilo Borgmann wrote: >>>>>>> Am 22.02.22 um 12:30 schrieb Thilo Borgmann: >>>>>>>> Am 18.02.22 um 17:08 schrieb Paul B Mahol: >>>>>>>>> On Sat, Feb 12, 2022 at 11:55 AM Thilo Borgmann >>>>>>>>> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Am 31.01.22 um 12:55 schrieb James Almer: >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On 1/31/2022 8:53 AM, Anton Khirnov wrote: >>>>>>>>>>>> Quoting Thilo Borgmann (2022-01-18 14:58:07) >>>>>>>>>>>>>>> Violations of code style. >>>>>>>>>>>>> >>>>>>>>>>>>> Enhanced. >>>>>>>>>>>> >>>>>>>>>>>> Not enough. There are still many remaining, e.g. >>>>>>>>>>>> * opening brace of a function definition should be on its own >>>>>>>>>>>> line >>>>>>>>>>>> * the context should generally be the first argument >>>>>>>>>>>> * unsigned char* should be uint8_t* >>>>>>>>>>>> * mixed declarations and code (the compiler should warn about >>>>>>>>>>>> that) >>>>>>>>>>> >>>>>>>>>>> I think someone said that clang (or some versions) is apparently >>>>>>>>>>> not >>>>>>>>>> warning about this, hence why so many of these end up being missed >>>>>>>>>> in >>>>>>>>>> reviews or even by the patch author. >>>>>>>>>> >>>>>>>>>> This and all of Anton's comments in v3. Also removed some more >>>>>>>>>> obviously >>>>>>>>>> useless doubles. >>>>>>>>>> >>>>>>>>> >>>>>>>>> Why it uses doubles in so many places? >>>>>>>>> Is there any real benefit in that, except extra slowdown? >>>>>>>> >>>>>>>> I guess because it's originating in some c&p Matlab code. >>>>>>>> I did %s#double#float#g for v4, loosing some precision we can ignore >>>>>>>> IMHO. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> v3: >>>>>>>> >>>>>>>> Total frames: 2 >>>>>>>> >>>>>>>> Spatial Information: >>>>>>>> Average: 165.451985 >>>>>>>> Max: 165.817542 >>>>>>>> Min: 165.086427 >>>>>>>> >>>>>>>> Temporal Information: >>>>>>>> Average: 1.007263 >>>>>>>> Max: 2.014525 >>>>>>>> Min: 0.000000 >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> v4: >>>>>>>> >>>>>>>> Total frames: 2 >>>>>>>> >>>>>>>> Spatial Information: >>>>>>>> Average: 164.385895 >>>>>>>> Max: 164.742325 >>>>>>>> Min: 164.029480 >>>>>>>> >>>>>>>> Temporal Information: >>>>>>>> Average: 1.007241 >>>>>>>> Max: 2.014483 >>>>>>>> Min: 0.000000 >>>>>>>> >>>>>>> >>>>>>> Ping. >>>>>> >>>>>> Into wrong section of changelog added entry. >>>>>> >>>>>> Useless cast of allocation results. >>>>>> >>>>>> Does filter changes pixels? If not, add metadata flag to appropriate >>>>>> place. >>>>> >>>>> All addressed in v5, thx! >>>>> >>>> >>>> Changelog entry is still in wrong, 5.0, section. >>> >>> Fixed in v6. >>> >>>>> Also added a FATE test for it. >>> >>> >> >> Could use fminf/ float functions instead of double variants. > > v7. Going to push soon if there are no more comments. -Thilo _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".