* [FFmpeg-devel] [PATCHv5] checkasm/lpc: test compute_autocorr
@ 2024-05-30 15:58 Rémi Denis-Courmont
2024-05-30 21:56 ` James Almer
0 siblings, 1 reply; 3+ messages in thread
From: Rémi Denis-Courmont @ 2024-05-30 15:58 UTC (permalink / raw)
To: ffmpeg-devel
Also restrict length to even values as per (questionable) assumption in
the reference C code.
---
tests/checkasm/lpc.c | 59 +++++++++++++++++++++++++++++++++++++++++---
1 file changed, 56 insertions(+), 3 deletions(-)
diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c
index 592e34c03d..f9f3d84080 100644
--- a/tests/checkasm/lpc.c
+++ b/tests/checkasm/lpc.c
@@ -16,6 +16,7 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
+#include "libavutil/avassert.h"
#include "libavutil/mem_internal.h"
#include "libavcodec/lpc.h"
@@ -30,7 +31,7 @@
} \
} while (0)
-#define EPS 0.005
+#define EPS 0.0001
static void test_window(int len)
{
@@ -57,10 +58,51 @@ static void test_window(int len)
bench_new(src, len, dst1);
}
+#if !ARCH_X86
+static void test_compute_autocorr(ptrdiff_t len, int lag)
+{
+ const double eps = EPS * (double)len;
+ LOCAL_ALIGNED(32, double, src, [5000 + 2 + MAX_LPC_ORDER]);
+ LOCAL_ALIGNED(16, double, dst0, [MAX_LPC_ORDER + 1]);
+ LOCAL_ALIGNED(16, double, dst1, [MAX_LPC_ORDER + 1]);
+
+ declare_func(void, const double *in, ptrdiff_t len, int lag, double *out);
+
+ av_assert0(lag >= 0 && lag <= MAX_LPC_ORDER);
+
+ for (int i = 0; i < MAX_LPC_ORDER; i++)
+ src[i] = 0.;
+
+ src += MAX_LPC_ORDER;
+
+ for (int i = 0; i < 5000 + 2; i++) {
+ src[i] = (double)rnd() / (double)UINT_MAX;
+ }
+
+ call_ref(src, len, lag, dst0);
+ call_new(src, len, lag, dst1);
+
+ for (size_t i = 0; i <= lag; i++) {
+ if (!double_near_abs_eps(dst0[i], dst1[i], eps)) {
+ fprintf(stderr, "%zu: %- .12f - %- .12f = % .12g\n",
+ i, dst0[i], dst1[i], dst0[i] - dst1[i]);
+ fail();
+ break;
+ }
+ }
+
+ bench_new(src, 4608, lag, dst1);
+}
+#endif
+
void checkasm_check_lpc(void)
{
LPCContext ctx;
- int len = rnd() % 5000;
+ int len = 2000 + rnd() % 3000;
+#if !ARCH_X86
+ static const int lags[] = { 8, 12, };
+#endif
+
ff_lpc_init(&ctx, 32, 16, FF_LPC_TYPE_DEFAULT);
if (check_func(ctx.lpc_apply_welch_window, "apply_welch_window_even")) {
@@ -72,6 +114,17 @@ void checkasm_check_lpc(void)
test_window(len | 1);
}
report("apply_welch_window_odd");
-
ff_lpc_end(&ctx);
+
+#if !ARCH_X86
+ for (size_t i = 0; i < FF_ARRAY_ELEMS(lags); i++) {
+ ff_lpc_init(&ctx, len, lags[i], FF_LPC_TYPE_DEFAULT);
+ if (check_func(ctx.lpc_compute_autocorr, "autocorr_%d", lags[i])) {
+ test_compute_autocorr(len & ~1, lags[i]);
+ /*TODO: test_compute_autocorr(len | 1, lags[i]);*/
+ }
+ ff_lpc_end(&ctx);
+ }
+ report("compute_autocorr");
+#endif
}
--
2.45.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCHv5] checkasm/lpc: test compute_autocorr
2024-05-30 15:58 [FFmpeg-devel] [PATCHv5] checkasm/lpc: test compute_autocorr Rémi Denis-Courmont
@ 2024-05-30 21:56 ` James Almer
2024-05-31 6:09 ` Rémi Denis-Courmont
0 siblings, 1 reply; 3+ messages in thread
From: James Almer @ 2024-05-30 21:56 UTC (permalink / raw)
To: ffmpeg-devel
On 5/30/2024 12:58 PM, Rémi Denis-Courmont wrote:
> Also restrict length to even values as per (questionable) assumption in
> the reference C code.
> ---
> tests/checkasm/lpc.c | 59 +++++++++++++++++++++++++++++++++++++++++---
> 1 file changed, 56 insertions(+), 3 deletions(-)
>
> diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c
> index 592e34c03d..f9f3d84080 100644
> --- a/tests/checkasm/lpc.c
> +++ b/tests/checkasm/lpc.c
> @@ -16,6 +16,7 @@
> * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> */
>
> +#include "libavutil/avassert.h"
> #include "libavutil/mem_internal.h"
>
> #include "libavcodec/lpc.h"
> @@ -30,7 +31,7 @@
> } \
> } while (0)
>
> -#define EPS 0.005
> +#define EPS 0.0001
Wont this end up in failures for some targets?
>
> static void test_window(int len)
> {
> @@ -57,10 +58,51 @@ static void test_window(int len)
> bench_new(src, len, dst1);
> }
>
> +#if !ARCH_X86
> +static void test_compute_autocorr(ptrdiff_t len, int lag)
> +{
> + const double eps = EPS * (double)len;
> + LOCAL_ALIGNED(32, double, src, [5000 + 2 + MAX_LPC_ORDER]);
> + LOCAL_ALIGNED(16, double, dst0, [MAX_LPC_ORDER + 1]);
> + LOCAL_ALIGNED(16, double, dst1, [MAX_LPC_ORDER + 1]);
> +
> + declare_func(void, const double *in, ptrdiff_t len, int lag, double *out);
> +
> + av_assert0(lag >= 0 && lag <= MAX_LPC_ORDER);
> +
> + for (int i = 0; i < MAX_LPC_ORDER; i++)
> + src[i] = 0.;
> +
> + src += MAX_LPC_ORDER;
> +
> + for (int i = 0; i < 5000 + 2; i++) {
> + src[i] = (double)rnd() / (double)UINT_MAX;
> + }
> +
> + call_ref(src, len, lag, dst0);
> + call_new(src, len, lag, dst1);
> +
> + for (size_t i = 0; i <= lag; i++) {
> + if (!double_near_abs_eps(dst0[i], dst1[i], eps)) {
> + fprintf(stderr, "%zu: %- .12f - %- .12f = % .12g\n",
> + i, dst0[i], dst1[i], dst0[i] - dst1[i]);
> + fail();
> + break;
> + }
> + }
> +
> + bench_new(src, 4608, lag, dst1);
> +}
> +#endif
> +
> void checkasm_check_lpc(void)
> {
> LPCContext ctx;
> - int len = rnd() % 5000;
> + int len = 2000 + rnd() % 3000;
> +#if !ARCH_X86
> + static const int lags[] = { 8, 12, };
> +#endif
> +
> ff_lpc_init(&ctx, 32, 16, FF_LPC_TYPE_DEFAULT);
>
> if (check_func(ctx.lpc_apply_welch_window, "apply_welch_window_even")) {
> @@ -72,6 +114,17 @@ void checkasm_check_lpc(void)
> test_window(len | 1);
> }
> report("apply_welch_window_odd");
> -
> ff_lpc_end(&ctx);
> +
> +#if !ARCH_X86
> + for (size_t i = 0; i < FF_ARRAY_ELEMS(lags); i++) {
> + ff_lpc_init(&ctx, len, lags[i], FF_LPC_TYPE_DEFAULT);
> + if (check_func(ctx.lpc_compute_autocorr, "autocorr_%d", lags[i])) {
> + test_compute_autocorr(len & ~1, lags[i]);
> + /*TODO: test_compute_autocorr(len | 1, lags[i]);*/
> + }
> + ff_lpc_end(&ctx);
> + }
> + report("compute_autocorr");
> +#endif
> }
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCHv5] checkasm/lpc: test compute_autocorr
2024-05-30 21:56 ` James Almer
@ 2024-05-31 6:09 ` Rémi Denis-Courmont
0 siblings, 0 replies; 3+ messages in thread
From: Rémi Denis-Courmont @ 2024-05-31 6:09 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Le 31 mai 2024 00:56:21 GMT+03:00, James Almer <jamrial@gmail.com> a écrit :
>On 5/30/2024 12:58 PM, Rémi Denis-Courmont wrote:
>> Also restrict length to even values as per (questionable) assumption in
>> the reference C code.
>> ---
>> tests/checkasm/lpc.c | 59 +++++++++++++++++++++++++++++++++++++++++---
>> 1 file changed, 56 insertions(+), 3 deletions(-)
>>
>> diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c
>> index 592e34c03d..f9f3d84080 100644
>> --- a/tests/checkasm/lpc.c
>> +++ b/tests/checkasm/lpc.c
>> @@ -16,6 +16,7 @@
>> * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>> */
>> +#include "libavutil/avassert.h"
>> #include "libavutil/mem_internal.h"
>> #include "libavcodec/lpc.h"
>> @@ -30,7 +31,7 @@
>> } \
>> } while (0)
>> -#define EPS 0.005
>> +#define EPS 0.0001
>
>Wont this end up in failures for some targets?
Not that I know. That was an awful high value for double precision.
>> static void test_window(int len)
>> {
>> @@ -57,10 +58,51 @@ static void test_window(int len)
>> bench_new(src, len, dst1);
>> }
>> +#if !ARCH_X86
>> +static void test_compute_autocorr(ptrdiff_t len, int lag)
>> +{
>> + const double eps = EPS * (double)len;
>> + LOCAL_ALIGNED(32, double, src, [5000 + 2 + MAX_LPC_ORDER]);
>> + LOCAL_ALIGNED(16, double, dst0, [MAX_LPC_ORDER + 1]);
>> + LOCAL_ALIGNED(16, double, dst1, [MAX_LPC_ORDER + 1]);
>> +
>> + declare_func(void, const double *in, ptrdiff_t len, int lag, double *out);
>> +
>> + av_assert0(lag >= 0 && lag <= MAX_LPC_ORDER);
>> +
>> + for (int i = 0; i < MAX_LPC_ORDER; i++)
>> + src[i] = 0.;
>> +
>> + src += MAX_LPC_ORDER;
>> +
>> + for (int i = 0; i < 5000 + 2; i++) {
>> + src[i] = (double)rnd() / (double)UINT_MAX;
>> + }
>> +
>> + call_ref(src, len, lag, dst0);
>> + call_new(src, len, lag, dst1);
>> +
>> + for (size_t i = 0; i <= lag; i++) {
>> + if (!double_near_abs_eps(dst0[i], dst1[i], eps)) {
>> + fprintf(stderr, "%zu: %- .12f - %- .12f = % .12g\n",
>> + i, dst0[i], dst1[i], dst0[i] - dst1[i]);
>> + fail();
>> + break;
>> + }
>> + }
>> +
>> + bench_new(src, 4608, lag, dst1);
>> +}
>> +#endif
>> +
>> void checkasm_check_lpc(void)
>> {
>> LPCContext ctx;
>> - int len = rnd() % 5000;
>> + int len = 2000 + rnd() % 3000;
>> +#if !ARCH_X86
>> + static const int lags[] = { 8, 12, };
>> +#endif
>> +
>> ff_lpc_init(&ctx, 32, 16, FF_LPC_TYPE_DEFAULT);
>> if (check_func(ctx.lpc_apply_welch_window, "apply_welch_window_even")) {
>> @@ -72,6 +114,17 @@ void checkasm_check_lpc(void)
>> test_window(len | 1);
>> }
>> report("apply_welch_window_odd");
>> -
>> ff_lpc_end(&ctx);
>> +
>> +#if !ARCH_X86
>> + for (size_t i = 0; i < FF_ARRAY_ELEMS(lags); i++) {
>> + ff_lpc_init(&ctx, len, lags[i], FF_LPC_TYPE_DEFAULT);
>> + if (check_func(ctx.lpc_compute_autocorr, "autocorr_%d", lags[i])) {
>> + test_compute_autocorr(len & ~1, lags[i]);
>> + /*TODO: test_compute_autocorr(len | 1, lags[i]);*/
>> + }
>> + ff_lpc_end(&ctx);
>> + }
>> + report("compute_autocorr");
>> +#endif
>> }
>_______________________________________________
>ffmpeg-devel mailing list
>ffmpeg-devel@ffmpeg.org
>https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>To unsubscribe, visit link above, or email
>ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-31 6:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-30 15:58 [FFmpeg-devel] [PATCHv5] checkasm/lpc: test compute_autocorr Rémi Denis-Courmont
2024-05-30 21:56 ` James Almer
2024-05-31 6:09 ` Rémi Denis-Courmont
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git