From: "Rémi Denis-Courmont" <remi@remlab.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/4] checkasm/rv34dsp: add rv34_inv_transform_dc test
Date: Fri, 02 Feb 2024 14:08:29 +0200
Message-ID: <A2630F53-973A-4417-BE77-18941DC46687@remlab.net> (raw)
In-Reply-To: <20240201234220.GG6420@pb2>
Le 2 février 2024 01:42:20 GMT+02:00, Michael Niedermayer <michael@niedermayer.cc> a écrit :
>On Wed, Jan 31, 2024 at 08:00:18PM +0800, flow gg wrote:
>>
>
>> checkasm/Makefile | 1
>> checkasm/checkasm.c | 3 ++
>> checkasm/checkasm.h | 1
>> checkasm/rv34dsp.c | 65 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>> fate/checkasm.mak | 1
>> 5 files changed, 71 insertions(+)
>> e7eed6e25de9f313ddb3c0f3066f02f0671d3271 0001-checkasm-rv34dsp-add-rv34_inv_transform_dc-test.patch
>> From 46a81051f49f6b4032815d5f123be8ff614033e2 Mon Sep 17 00:00:00 2001
>> From: sunyuechi <sunyuechi@iscas.ac.cn>
>> Date: Wed, 31 Jan 2024 19:00:23 +0800
>> Subject: [PATCH 1/4] checkasm/rv34dsp: add rv34_inv_transform_dc test
>
>seems to fail here
Do you mean that the test is wrong or that it exposes a bug in the x86 optimisations (which wouldn't be the first occurrence)?
It's painful enough that RVV optimisations need to add checkasm tests for existing code. We can't be expected to fix x86 bugs on top.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-02 12:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 12:00 flow gg
2024-02-01 23:42 ` Michael Niedermayer
2024-02-02 0:47 ` flow gg
2024-02-12 19:36 ` Rémi Denis-Courmont
2024-02-13 2:37 ` flow gg
2024-02-13 9:58 ` flow gg
2024-02-02 12:08 ` Rémi Denis-Courmont [this message]
2024-02-02 13:26 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2630F53-973A-4417-BE77-18941DC46687@remlab.net \
--to=remi@remlab.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git