From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id AE7814AF82 for ; Fri, 20 Jun 2025 11:30:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 4F57A68D384; Fri, 20 Jun 2025 14:29:58 +0300 (EEST) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id D445668C306 for ; Fri, 20 Jun 2025 14:29:51 +0300 (EEST) Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4530921461aso14673285e9.0 for ; Fri, 20 Jun 2025 04:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750418991; x=1751023791; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pNZapKA2DJqXuv1akKXUI3g6HUlaPTYWjORLXy/8XB0=; b=e+XEBvBD/bCBjsG4eteVKMul+MQ7nWx9/0VVmFDC5LD4botqOfKjhAXLk0cdYaZcrf FIwQKId/Z2euJ7vo6Oh8xzEiNPe7gosU6K/gyL7ds39v1QPXWrsSoc6JNVBMAzAxXGYw d98bdh54peabg6/1IAaw0t8ESVOmkJ1VEwr+NTwU9rBmusdRvWe0jM4EDRduCzT5zIGU /bm5CMKH1KO9W/NgezjjsGJnPymUQl16ChDZBj5upWjZoYFdYdvU1i78wkfDFo0h8Fjp +B6GZy9pdoUgFE3FVQo9I5AGcuDrZxos5+bXl35WO9Byd0Lik6LZ9cInMXf3suTTD60D XdFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750418991; x=1751023791; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pNZapKA2DJqXuv1akKXUI3g6HUlaPTYWjORLXy/8XB0=; b=OM1ejFYxvziipw8iuSzMJFTBDZMpHONlXjQPIGByKt82jIq8fLcNc6P/gE5R9jEhPc CM9vb8yU8YTemDhgSbkqvW5FlbJbhn+JHZLatj99lFwO/ReNqPQIb75uXVUQjWwYlcYT 5s8VYauOINJ08230/Pz9Z/E49kywtulBeqbx5QJ8incRZsxvZbyV8HAB1sp3a6E2krtg AJJmzs+lerFEPIQMdtAoyhJSr6m++Ww801RMXdm7FT6vPVgJkes0ax7ei+H2pLozW5s9 beNRpON+xnGA4e1wVf5YmDfY541IOM93fAPZViiju8wiUiCdmHlx37mnBXohiSWyZ0uz FX9w== X-Gm-Message-State: AOJu0YxkemDqaNHNU7ju/+283OUzxxlL3UHkWkzARYo2hFfF195U1Z3o /QbTUcyCg90uhYNTgU0fRyOAuxcSCV4wAAWj/uyqT2rJcMyhI1TagT/Wq9o5cg== X-Gm-Gg: ASbGncv68G9SWkmBVrbNLv4gCIvs0oKBniq5TlZL5ylkbEgKZyJwWk908h7XINy5eZn IhdJeungLXvxe5ZMujjpF5ONT2lpAqNt2qaFSdv0u5nveun5vwulMSeDv8cdsaBLNqPnj8+eh0M HwJfHr+AHxZMb3+xJeBh957FvTIEUTdqT3hbY+5NVfxVsZop7i4YeJbdVYtpkc4J28mHzJQxr3X 4RId5O7IRtkwhk2/8HGQ0Z/Mq4epfUvSwwXtsvWkVnrP4uUf3ySlc2xvWsPNFJEk4fzpE1Uq2fH 1PQH5R8gMOqO+GiDbeRG7q8mbjVcO+6D/yjeaCgNbUOBNFP7SYivB+K0DtkFYk+w/RAIe6cKDAt DEt3YYf3Hc5ua3D2xmW7BVzIkexf2/nUZvgbG0MVtBXfgnFMzj9kCBcMmRWQj92ujTqr9YNnyez Q= X-Google-Smtp-Source: AGHT+IHouIqRXaIt8dXM3dg+WFyCent/B4cuV3ZNHQMyv2nT0R0vtAGPzRK0XjLQa+LTc51fdRW5vg== X-Received: by 2002:a05:600c:3f18:b0:453:697:6f08 with SMTP id 5b1f17b1804b1-453655c2a03mr18316065e9.26.1750418990762; Fri, 20 Jun 2025 04:29:50 -0700 (PDT) Received: from [192.168.178.57] (p20030102370045001d71edff2c9e568e.dip0.t-ipconnect.de. [2003:102:3700:4500:1d71:edff:2c9e:568e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453646dc66fsm22138875e9.18.2025.06.20.04.29.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Jun 2025 04:29:49 -0700 (PDT) From: Marvin Scholz To: FFmpeg development discussions and patches Date: Fri, 20 Jun 2025 13:29:49 +0200 X-Mailer: MailMate (2.0r6222) Message-ID: In-Reply-To: <20250620110853.1448602-1-nicolas.gaullier@cji.paris> References: <20250620110853.1448602-1-nicolas.gaullier@cji.paris> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/2] fftools/textformat: fix print 64 bit integers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Nicolas Gaullier Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 20 Jun 2025, at 13:07, Nicolas Gaullier wrote: > Regression in ffprobe since textformat introduction > in d7a3f68feae0b1c3718f9d2671c6d41c60a40680. > > Fixes #11638 > > Signed-off-by: Nicolas Gaullier > --- > fftools/textformat/avtextformat.c | 2 +- > fftools/textformat/avtextformat.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fftools/textformat/avtextformat.c b/fftools/textformat/avtextformat.c > index 14779e6f0c..14bad9022b 100644 > --- a/fftools/textformat/avtextformat.c > +++ b/fftools/textformat/avtextformat.c > @@ -437,7 +437,7 @@ static char *value_string(const AVTextFormatContext *tctx, char *buf, int buf_si > } > > > -void avtext_print_unit_int(AVTextFormatContext *tctx, const char *key, int value, const char *unit) > +void avtext_print_unit_int(AVTextFormatContext *tctx, const char *key, int64_t value, const char *unit) > { > char val_str[128]; > struct unit_value uv; > diff --git a/fftools/textformat/avtextformat.h b/fftools/textformat/avtextformat.h > index cf23d93871..8316829af5 100644 > --- a/fftools/textformat/avtextformat.h > +++ b/fftools/textformat/avtextformat.h > @@ -169,7 +169,7 @@ void avtext_print_integer(AVTextFormatContext *tctx, const char *key, int64_t va > > int avtext_print_string(AVTextFormatContext *tctx, const char *key, const char *val, int flags); > > -void avtext_print_unit_int(AVTextFormatContext *tctx, const char *key, int value, const char *unit); > +void avtext_print_unit_int(AVTextFormatContext *tctx, const char *key, int64_t value, const char *unit); > > void avtext_print_rational(AVTextFormatContext *tctx, const char *key, AVRational q, char sep); > > -- > 2.47.2 > Looks good. Would it be possible to add a test for this to make sure we catch such a regression next time? (I can also give it a try if you don't want to) > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".