Re: [FFmpeg-devel] [PATCH 1/2] fftools/textformat: fix print 64 bit integers

From: Marvin Scholz <epirat07-at-gmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Nicolas Gaullier <nicolas.gaullier@cji.paris>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] fftools/textformat: fix print 64 bit integers
Date: Fri, 20 Jun 2025 13:29:49 +0200
Message-ID: <A02CF37B-08A5-49CF-B6CF-7D2F94206FB0@gmail.com> (raw)
In-Reply-To: <20250620110853.1448602-1-nicolas.gaullier@cji.paris>

On 20 Jun 2025, at 13:07, Nicolas Gaullier wrote:

> Regression in ffprobe since textformat introduction
> in d7a3f68feae0b1c3718f9d2671c6d41c60a40680.
>
> Fixes #11638
>
> Signed-off-by: Nicolas Gaullier <nicolas.gaullier@cji.paris>
> ---
>  fftools/textformat/avtextformat.c | 2 +-
>  fftools/textformat/avtextformat.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fftools/textformat/avtextformat.c b/fftools/textformat/avtextformat.c
> index 14779e6f0c..14bad9022b 100644
> --- a/fftools/textformat/avtextformat.c
> +++ b/fftools/textformat/avtextformat.c
> @@ -437,7 +437,7 @@ static char *value_string(const AVTextFormatContext *tctx, char *buf, int buf_si
>  }
>
>
> -void avtext_print_unit_int(AVTextFormatContext *tctx, const char *key, int value, const char *unit)
> +void avtext_print_unit_int(AVTextFormatContext *tctx, const char *key, int64_t value, const char *unit)
>  {
>      char val_str[128];
>      struct unit_value uv;
> diff --git a/fftools/textformat/avtextformat.h b/fftools/textformat/avtextformat.h
> index cf23d93871..8316829af5 100644
> --- a/fftools/textformat/avtextformat.h
> +++ b/fftools/textformat/avtextformat.h
> @@ -169,7 +169,7 @@ void avtext_print_integer(AVTextFormatContext *tctx, const char *key, int64_t va
>
>  int avtext_print_string(AVTextFormatContext *tctx, const char *key, const char *val, int flags);
>
> -void avtext_print_unit_int(AVTextFormatContext *tctx, const char *key, int value, const char *unit);
> +void avtext_print_unit_int(AVTextFormatContext *tctx, const char *key, int64_t value, const char *unit);
>
>  void avtext_print_rational(AVTextFormatContext *tctx, const char *key, AVRational q, char sep);
>
> -- 
> 2.47.2
>

Looks good.

Would it be possible to add a test for this to make sure we catch such
a regression next time?

(I can also give it a try if you don't want to)

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".