From: Scott Theisen <scott.the.elm@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/dvdsubdec: fix incorrect yellow appearance of dvd subtitles
Date: Thu, 3 Feb 2022 18:14:47 -0500
Message-ID: <9fe5001f-18bd-2fbd-b9f6-984ecdaf2ef7@gmail.com> (raw)
In-Reply-To: <DM8P223MB036559ADEBC5BE6610CF596FBA289@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
On 2/3/22 17:57, Soft Works wrote:
> My suspicion is that 0xffff00 was written assuming RGBA order instead
> of ARGB.
You are missing a byte for either RGBA or ARGB. RGBA would be cyan.
> I'm pretty sure that it's a mistake and it hasn't been an intentional
> choice, because even when you would consider a yellow color to for
> whatever reason, it wouldn't have been exactly this yellow (#ff0),
> because its lightness/saturation values are not in a range of what
> is suitable for colored subtitles.
I think using yellow for debugging purposes is more likely, i.e. it is
obvious if the pallet was missing/not detected. However, it shouldn't
have been committed like that, if that was the reason.
Regards,
Scott
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-02-03 23:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 2:19 ffmpegagent
2022-02-03 22:10 ` Soft Works
2022-02-03 22:16 ` Scott Theisen
2022-02-03 22:57 ` Soft Works
2022-02-03 23:14 ` Scott Theisen [this message]
2022-02-04 0:05 ` Soft Works
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fe5001f-18bd-2fbd-b9f6-984ecdaf2ef7@gmail.com \
--to=scott.the.elm@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git