Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: fix (a)buffer src names
Date: Fri, 21 Jan 2022 09:05:50 -0300
Message-ID: <9f778ac3-a472-1603-4514-b08f813573cd@gmail.com> (raw)
In-Reply-To: <20220121081515.14847-1-anton@khirnov.net>



On 1/21/2022 5:15 AM, Anton Khirnov wrote:
> ---
> Grmbl, could have sworn I tested this
> ---
>   fftools/ffmpeg_filter.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c
> index 1f6cba2c04..7b6fcc36de 100644
> --- a/fftools/ffmpeg_filter.c
> +++ b/fftools/ffmpeg_filter.c
> @@ -949,8 +949,8 @@ static void cleanup_filtergraph(FilterGraph *fg)
>   static int filter_is_buffersrc(const AVFilterContext *f)
>   {
>       return f->nb_inputs == 0 &&
> -           (!strcmp(f->filter->name, "buffersrc") ||
> -            !strcmp(f->filter->name, "abuffersrc"));
> +           (!strcmp(f->filter->name, "buffer") ||
> +            !strcmp(f->filter->name, "abuffer"));

Curious no fate test was affected by this. I see gcov shows this 
function is called a bunch of times.

LGTM.

>   }
>   
>   static int graph_is_meta(AVFilterGraph *graph)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2022-01-21 12:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-21  8:15 Anton Khirnov
2022-01-21 12:05 ` James Almer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f778ac3-a472-1603-4514-b08f813573cd@gmail.com \
    --to=jamrial@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git