From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/movenc: disallow buggy flags combination
Date: Mon, 26 May 2025 15:47:52 +0300 (EEST)
Message-ID: <9f74ff58-fb8b-563b-28cd-a1eb14e1190@martin.st> (raw)
In-Reply-To: <20250526124604.18404-1-ffmpeg@gyani.pro>
On Mon, 26 May 2025, Gyan Doshi wrote:
> Usage of hybrid_fragmented and faststart together can result in files with
> loss of sync and bitstream parsing errors upon playback.
> ---
> libavformat/movenc.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 4bc8bd1b2a..9392ba5370 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -7731,6 +7731,12 @@ static int mov_init(AVFormatContext *s)
> FF_MOV_FLAG_FRAG_EVERY_FRAME))
> mov->flags |= FF_MOV_FLAG_FRAGMENT;
>
> + if (mov->flags & FF_MOV_FLAG_HYBRID_FRAGMENTED &&
> + mov->flags & FF_MOV_FLAG_FASTSTART) {
> + av_log(s, AV_LOG_ERROR, "Setting both hybrid_fragmented and faststart is not supported.\n");
> + return AVERROR(EINVAL);
> + }
> +
Ok
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-05-26 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 12:46 Gyan Doshi
2025-05-26 12:47 ` Martin Storsjö [this message]
2025-05-26 17:15 ` Gyan Doshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f74ff58-fb8b-563b-28cd-a1eb14e1190@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git