From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3973746B36 for ; Sun, 3 Sep 2023 16:02:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BD5A168C71A; Sun, 3 Sep 2023 19:02:02 +0300 (EEST) Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5230E68C21B for ; Sun, 3 Sep 2023 19:01:57 +0300 (EEST) Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-1d4daca8edcso157036fac.2 for ; Sun, 03 Sep 2023 09:01:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693756915; x=1694361715; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=IUzAkOwEDN0RcoOw+gNKtspy6e3z3v0w0A0t3JRsyqo=; b=WhGxzz9BsBA7mmVuFGIpx3JVlcmuB5wk4ZVc7r7DwZtaDEu6F7S4i9FyeZoY9EGPMW rFZPFJQ2TYsGucSz5JtXw5hmI0CUpvOXc3Zdnbh10cIBzBZOAhFhgX1i1SVeaVbjYwxJ glLGtbF1gJ4rpRn/UT62da5gge5HmusT8n9/Zet12lzJdwZ7Lqjm5h3ItSAJLgOoihXn 26l/rmB6hizADiGuVeY2Tn7ndzLhOvw6m80LOZ0Wmy0Xjoe7tI0JtGXGd6upbNgS+hWj Iyp0LSgg8LMKk/AIrKvfQWIApFvWLSlbaX5L/+N8/3YSZ9gCHWqgcoChryM0dnGtZ22V hC5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693756915; x=1694361715; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IUzAkOwEDN0RcoOw+gNKtspy6e3z3v0w0A0t3JRsyqo=; b=H+pcJ3am39KuFDPN/4WoqLOSkbSDcTsZQdJ6OGMCzpO+9J6GR4SBmc8OINeAvnwZL9 HX9V+UFyHGMTEjgTTdJMbUs1xagb3xV0kSb0RFYhRy0WEcPf8+gyT+1olcWPxzPfhVDk mNveobVyZHbb2PjgEXHTg04mAc2zZgB2cUHgiaAxTuw/Yn4UzOaIuoFk4uUuKejCXWs5 6HOaJxICKnfqZvkjhssF0p9XmxVOl4ZW6C+l8TdLCZNzBEjq1w5mkWr/FWJPO4CROCZj YJ7Zwv0mEUhMxycAbz6ScANkvoukYVbcQ+wew1p+dnVLd3O+VHR/ERef9ZlAi24SEFj2 3gAA== X-Gm-Message-State: AOJu0YwGj2L8k2+C4soQbUp8YW5ykqERmtAQqzRzP9NvhjSeoVV00xNN YCgG2LPXzpdaUI7g4UhvUJ2tw/3MmDM= X-Google-Smtp-Source: AGHT+IGbGwPnRA75jT59t4SOB3z+YBea5v8XzKLjEuvaDM/ZuOPIJJr/eRQAhNSvO24yNX62sM+hZA== X-Received: by 2002:a05:6870:7083:b0:1bb:933b:e6da with SMTP id v3-20020a056870708300b001bb933be6damr10555146oae.27.1693756915083; Sun, 03 Sep 2023 09:01:55 -0700 (PDT) Received: from [192.168.0.10] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id g5-20020a9d6485000000b006b1570a7674sm3812398otl.29.2023.09.03.09.01.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Sep 2023 09:01:54 -0700 (PDT) Message-ID: <9f409f1d-12cd-bc1d-3df0-50ee14486881@gmail.com> Date: Sun, 3 Sep 2023 13:01:56 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 To: ffmpeg-devel@ffmpeg.org References: <20230903160013.833742-1-aler9.dev@gmail.com> Content-Language: en-US From: James Almer In-Reply-To: <20230903160013.833742-1-aler9.dev@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/vpcc: fix VP9 metadata in FLV and RTMP X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/3/2023 1:00 PM, Alessandro Ros wrote: > I integrated James A. comment and fixed patch format. I think you forgot to git add. > > In order to send VP9 tracks with FLV or RTMP, the enhanced RTMP > specification tells that VPCodecConfigurationRecord, a.k.a. vpcC > ISO-BMFF box, must be inserted into a metadata message. However, the > function responsible for generating vpcCs currently returns invalid > boxes, that are lacking the Version and Flag fields, inherited from > FullBox. For some reason, both flags were being added manually in > movenc. This patch fixes the issue. > > Signed-off-by: Alessandro Ros > --- > libavformat/movenc.c | 3 --- > libavformat/vpcc.c | 2 ++ > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 7ef6cef46a..696ae5a6c9 100644 > --- a/libavformat/movenc.c > +++ b/libavformat/movenc.c > @@ -1441,10 +1441,7 @@ static int mov_write_vpcc_tag(AVFormatContext *s, AVIOContext *pb, MOVTrack *tra > > avio_wb32(pb, 0); > ffio_wfourcc(pb, "vpcC"); > - avio_w8(pb, 1); /* version */ > - avio_wb24(pb, 0); /* flags */ > ff_isom_write_vpcc(s, pb, track->vos_data, track->vos_len, track->par); > - > return update_size(pb, pos); > } > > diff --git a/libavformat/vpcc.c b/libavformat/vpcc.c > index ea66959abf..256407dd6d 100644 > --- a/libavformat/vpcc.c > +++ b/libavformat/vpcc.c > @@ -208,6 +208,8 @@ int ff_isom_write_vpcc(AVFormatContext *s, AVIOContext *pb, > if (ret < 0) > return ret; > > + avio_w8(pb, 1); /* version */ > + avio_wb24(pb, 0); /* flags */ > avio_w8(pb, vpcc.profile); > avio_w8(pb, vpcc.level); > avio_w8(pb, (vpcc.bitdepth << 4) | (vpcc.chroma_subsampling << 1) | vpcc.full_range_flag); _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".