Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Mark Thompson <sw@jkqxz.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 1/2] cbs_av1: Add tracing headers for metadata types
Date: Tue, 17 Jan 2023 22:21:28 +0000
Message-ID: <9f33d721-b3a5-dc8d-6048-4bc096d9abfe@jkqxz.net> (raw)

Make it a little easier to interpret metadata in trace output.
---
  libavcodec/cbs_av1_syntax_template.c | 10 ++++++++++
  1 file changed, 10 insertions(+)

diff --git a/libavcodec/cbs_av1_syntax_template.c b/libavcodec/cbs_av1_syntax_template.c
index d98d3d42de..46f4c5a6b8 100644
--- a/libavcodec/cbs_av1_syntax_template.c
+++ b/libavcodec/cbs_av1_syntax_template.c
@@ -1843,6 +1843,8 @@ static int FUNC(metadata_hdr_cll)(CodedBitstreamContext *ctx, RWContext *rw,
  {
      int err;

+    HEADER("HDR CLL Metadata");
+
      fb(16, max_cll);
      fb(16, max_fall);

@@ -1854,6 +1856,8 @@ static int FUNC(metadata_hdr_mdcv)(CodedBitstreamContext *ctx, RWContext *rw,
  {
      int err, i;

+    HEADER("HDR MDCV Metadata");
+
      for (i = 0; i < 3; i++) {
          fbs(16, primary_chromaticity_x[i], 1, i);
          fbs(16, primary_chromaticity_y[i], 1, i);
@@ -1923,6 +1927,8 @@ static int FUNC(metadata_scalability)(CodedBitstreamContext *ctx, RWContext *rw,
  {
      int err;

+    HEADER("Scalability Metadata");
+
      fb(8, scalability_mode_idc);

      if (current->scalability_mode_idc == AV1_SCALABILITY_SS)
@@ -1937,6 +1943,8 @@ static int FUNC(metadata_itut_t35)(CodedBitstreamContext *ctx, RWContext *rw,
      int err;
      size_t i;

+    HEADER("ITU-T T.35 Metadata");
+
      fb(8, itu_t_t35_country_code);
      if (current->itu_t_t35_country_code == 0xff)
          fb(8, itu_t_t35_country_code_extension_byte);
@@ -1964,6 +1972,8 @@ static int FUNC(metadata_timecode)(CodedBitstreamContext *ctx, RWContext *rw,
  {
      int err;

+    HEADER("Timecode Metadata");
+
      fb(5, counting_type);
      flag(full_timestamp_flag);
      flag(discontinuity_flag);
-- 
2.39.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

             reply	other threads:[~2023-01-17 22:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17 22:21 Mark Thompson [this message]
2023-01-17 22:23 ` [FFmpeg-devel] [PATCH 2/2] cbs_av1: Don't reject unknown metadata Mark Thompson
2023-01-18 20:35 ` [FFmpeg-devel] [PATCH 3/2] cbs_av1: Remove constraint on MDCV luminance values Mark Thompson
2023-01-18 20:38   ` James Almer
2023-01-24 22:29     ` Mark Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f33d721-b3a5-dc8d-6048-4bc096d9abfe@jkqxz.net \
    --to=sw@jkqxz.net \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git