From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 6D02E41A43
	for <ffmpegdev@gitmailbox.com>; Wed, 20 Apr 2022 11:49:36 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2479468B3A8;
	Wed, 20 Apr 2022 14:49:34 +0300 (EEST)
Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A23E568A83B
 for <ffmpeg-devel@ffmpeg.org>; Wed, 20 Apr 2022 14:49:27 +0300 (EEST)
Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21])
 by mail8.parnet.fi  with ESMTP id 23KBnR45027668-23KBnR46027668
 for <ffmpeg-devel@ffmpeg.org>; Wed, 20 Apr 2022 14:49:27 +0300
Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187])
 by mail9.parnet.fi (Postfix) with ESMTPS id 163B1A1513
 for <ffmpeg-devel@ffmpeg.org>; Wed, 20 Apr 2022 14:49:27 +0300 (EEST)
Date: Wed, 20 Apr 2022 14:49:26 +0300 (EEST)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <20220415080953.18753-1-nil-admirari@mailo.com>
Message-ID: <9f1ef01d-bde5-897-23aa-8f60db78566d@martin.st>
References: <20220415080953.18753-1-nil-admirari@mailo.com>
MIME-Version: 1.0
X-FE-Policy-ID: 3:14:2:SYSTEM
Subject: Re: [FFmpeg-devel] [PATCH v9 6/6] fftools: Use UTF-8 on Windows
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/9f1ef01d-bde5-897-23aa-8f60db78566d@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Fri, 15 Apr 2022, Nil Admirari wrote:

> ---
> fftools/fftools.manifest | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fftools/fftools.manifest b/fftools/fftools.manifest
> index 30b7d8fe..d1ac1e4e 100644
> --- a/fftools/fftools.manifest
> +++ b/fftools/fftools.manifest
> @@ -3,8 +3,10 @@
> <assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
>   <assemblyIdentity type="win32" name="FFmpeg" version="1.0.0.0"/>
>   <application xmlns="urn:schemas-microsoft-com:asm.v3">
> -    <windowsSettings xmlns:ws2016="http://schemas.microsoft.com/SMI/2016/WindowsSettings">
> +    <windowsSettings xmlns:ws2016="http://schemas.microsoft.com/SMI/2016/WindowsSettings"
> +                     xmlns:ws2019="http://schemas.microsoft.com/SMI/2019/WindowsSettings">
>       <ws2016:longPathAware>true</ws2016:longPathAware>
> +      <ws2019:activeCodePage>UTF-8</ws2019:activeCodePage>
>     </windowsSettings>
>   </application>
> </assembly>
> -- 
> 2.32.0

This needs a similar commit message as what I suggested for the previous 
commit, explaining what it does, when, why, and clarifying that this is a 
noop for older versions.

In particular, it'd be interesting to know why we actually need this; we 
normally should be doing all the conversions between wchar_t and utf8 
everywhere anyway, so the exact codepage used shouldn't really matter 
much? I presume the main noticable benefit is that it improves the path 
name compatibility with avisynth which is stuck on using CP_ACP pathnames?

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".