From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8CCCE44FFC for ; Wed, 19 Apr 2023 12:59:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 33EBA68BF17; Wed, 19 Apr 2023 15:59:56 +0300 (EEST) Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 47D7068B8D3 for ; Wed, 19 Apr 2023 15:59:50 +0300 (EEST) Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-1878f1ebf46so884466fac.1 for ; Wed, 19 Apr 2023 05:59:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681909188; x=1684501188; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=cOIpy0am5ag9h1cAnZmtP+fcUJwNWxf/C7ZWIbdU5ng=; b=X7l3ZbsRAq9aymg7CaZmZ7yZ9s+jZj6/LUpp63e9fwfh3dI+zOOQbyp1L7Th5BrG2+ NwVnCjNIs98aqAdOnnDdacDBa2HN5CtPheloSqqvZTDwo7uFBmSkzwRBQ7gvxNJRkePS yRyP5qH14c3LL/4kBMIt61zOlsB0N2c9xmAMEUJJ9AgmcaZfKWyG5UWnGZGqtkmaWGDd gcHQEXBeelYU5z5TP0+dl5RYmqmOBjOZCDq+Yq0uctU+lvzABxyeB6jYK6nzSRGn5O5Q Iu1KOQ5Etwsxi6veOSOeBkEs+qk/5uOGO8+g1K8zS9xTKEekyJ+iid1qZcj6VSVfhdCV TVEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681909188; x=1684501188; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cOIpy0am5ag9h1cAnZmtP+fcUJwNWxf/C7ZWIbdU5ng=; b=AeQ5hb9mAb85xWcraJLrcs9+RNh3ZaW8xe89a7DOEY5DG6wJYtrBRoeC3cSySiu42c uGFMbdPrmC3KeiWcncdxK8y1/s10iiPNsSw0p9S7gtW0q6pATdj6+VXsNwZIdCTYx4Sz vjhpyll5uPVjwTvYInEd93A6X4VMHWI2B2cfYiijiy5yyIoVqKSnGTfBeCY+kDvd9IG1 RDOZ04qnALFP+mI8R0LYg8/6Z3olLsaYe1I+jdKgyMlOSMrdIqgz0RDAxj5VhBOfNgb6 a2CF6SGrqZJy6LeWEg7QwQk0h74w6Az5GhhSyGGH95gQamDHX9CijD3ANaBLSF8s+bfs R0ng== X-Gm-Message-State: AAQBX9f721rYPP8VMXsgiZngodwRpd1Gtdm9S7WFmXznBpriWpR3S6pa /jDubQb0pwpr2zz18I5Mm8IVF3W2i0E= X-Google-Smtp-Source: AKy350amOUeDiI0HQk97/Od4d0KvQvfth3ROlkdjOHohU5CoPKDkM2Ia0V7CvkAcZQXVEB4YIvpIsQ== X-Received: by 2002:a05:6870:1f95:b0:184:7e77:b107 with SMTP id go21-20020a0568701f9500b001847e77b107mr3402660oac.57.1681909188314; Wed, 19 Apr 2023 05:59:48 -0700 (PDT) Received: from [192.168.0.15] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id f14-20020a9d5e8e000000b00690c80741e3sm6561262otl.66.2023.04.19.05.59.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Apr 2023 05:59:47 -0700 (PDT) Message-ID: <9ea7583f-5fd6-de7b-f5e5-c7f46edcd661@gmail.com> Date: Wed, 19 Apr 2023 09:59:49 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 To: ffmpeg-devel@ffmpeg.org References: <20230418103257.374-1-d.kozinski@samsung.com> Content-Language: en-US From: James Almer In-Reply-To: <20230418103257.374-1-d.kozinski@samsung.com> Subject: Re: [FFmpeg-devel] [PATCH v20 08/10] avformat/mov_demuxer: Extended MOV demuxer to handle EVC video content X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/18/2023 7:32 AM, Dawid Kozinski wrote: > - Added evc extension to the list of extensions for ff_mov_demuxer > > Signed-off-by: Dawid Kozinski > --- > libavformat/demux.c | 1 + > libavformat/mov.c | 3 ++- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/demux.c b/libavformat/demux.c > index 06de71cd6e..912413c6a8 100644 > --- a/libavformat/demux.c > +++ b/libavformat/demux.c > @@ -120,6 +120,7 @@ static int set_codec_from_probe_data(AVFormatContext *s, AVStream *st, > { "mp3", AV_CODEC_ID_MP3, AVMEDIA_TYPE_AUDIO }, > { "mpegvideo", AV_CODEC_ID_MPEG2VIDEO, AVMEDIA_TYPE_VIDEO }, > { "truehd", AV_CODEC_ID_TRUEHD, AVMEDIA_TYPE_AUDIO }, > + { "evc", AV_CODEC_ID_EVC, AVMEDIA_TYPE_VIDEO }, > { 0 } > }; > int score; > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 057fd872b1..3d5c432697 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -2647,6 +2647,7 @@ static int mov_finalize_stsd_codec(MOVContext *c, AVIOContext *pb, > case AV_CODEC_ID_VP9: > sti->need_parsing = AVSTREAM_PARSE_FULL; > break; > + case AV_CODEC_ID_EVC: You should also parse the evcC atom to get the extradata, same as h26*, mapping it to the generic mov_read_glbl() function in mov_default_parse_table[]. > case AV_CODEC_ID_AV1: > /* field_order detection of H264 requires parsing */ > case AV_CODEC_ID_H264: > @@ -9305,7 +9306,7 @@ const AVInputFormat ff_mov_demuxer = { > .long_name = NULL_IF_CONFIG_SMALL("QuickTime / MOV"), > .priv_class = &mov_class, > .priv_data_size = sizeof(MOVContext), > - .extensions = "mov,mp4,m4a,3gp,3g2,mj2,psp,m4b,ism,ismv,isma,f4v,avif", > + .extensions = "mov,mp4,m4a,3gp,3g2,mj2,psp,m4b,ism,ismv,isma,f4v,avif,evc", Isn't this the raw format extension? Why add it to the mp4 demuxer? > .flags_internal = FF_FMT_INIT_CLEANUP, > .read_probe = mov_probe, > .read_header = mov_read_header, _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".