Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Marton Balint <cus@passwd.hu>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 12/12] avfilter/ffmpeg_filter: rate control all filter graphs
Date: Thu, 26 Jun 2025 21:21:16 +0200 (CEST)
Message-ID: <9e026df0-2732-bb53-101b-d781036c4539@passwd.hu> (raw)
In-Reply-To: <20250625182311.GZ29660@pb2>



On Wed, 25 Jun 2025, Michael Niedermayer wrote:

> On Tue, Jun 24, 2025 at 09:23:10PM +0200, Marton Balint wrote:
>> It was never reliable to detect if a filtergraph have sources, because a filter
>> can act as a source only after some time, for example the loop filter.
>>
>> So it is better to remove the source detection entirely and always give the
>> scheduler an oppurtunity to stop processing.
>>
>> Fixes ticket #11604.
>>
>> Signed-off-by: Marton Balint <cus@passwd.hu>
>> ---
>>  fftools/ffmpeg_filter.c | 25 ++++---------------------
>>  1 file changed, 4 insertions(+), 21 deletions(-)
>
> breaks: (infinite loop)
>
> ./ffmpeg -y -i tickets//507/avdesync_cut.avi -bitexact -af aresample=first_pts=-50000 -r 24000/1001 -t 145 out.avi
>
> sample seems attached to the ticket: https://trac.ffmpeg.org/ticket/507

Seems like an issue already present before the patch series if "sources" 
were used, because this hangs for me even without the patch series:

ffmpeg -threads 16 -i avdesync_cut.avi -bitexact -af aresample=first_pts=100,apad=pad_len=1000 -f null none

I have no better idea than to drop this patch until this is figured out, 
because this issue would become more common if all filters are going to be 
treated as sources...

Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-06-26 19:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-24 19:22 [FFmpeg-devel] [PATCH 01/12] avfilter: factorize requesting an input frame from multi output filters Marton Balint
2025-06-24 19:23 ` [FFmpeg-devel] [PATCH 02/12] avfilter/filters: simplify FF_FILTER_FORWARD_WANTED_ANY Marton Balint
2025-06-24 19:23 ` [FFmpeg-devel] [PATCH 03/12] avfilter/avfilter: fix forwarding EOF for simple API filters in filter_activate_default Marton Balint
2025-06-24 19:23 ` [FFmpeg-devel] [PATCH 04/12] fate/filter-video: add ffprobe test for dual output select filter Marton Balint
2025-06-24 19:23 ` [FFmpeg-devel] [PATCH 05/12] avfilter/avfilter: always forward request frame in filter_activate_default Marton Balint
2025-06-24 19:23 ` [FFmpeg-devel] [PATCH 06/12] avfilter/avfilter: make filter_activate_default request frames on behalf of sinks Marton Balint
2025-06-24 19:23 ` [FFmpeg-devel] [PATCH 07/12] tests/fate/filter-audio: add anullsink test Marton Balint
2025-06-24 19:23 ` [FFmpeg-devel] [PATCH 08/12] avfilter: signal an empty buffersrc with an explicit activate error code Marton Balint
2025-06-24 19:23 ` [FFmpeg-devel] [PATCH 09/12] avfilter/buffersink: keep requesting frames if one activation of the graph does not provide one Marton Balint
2025-06-24 19:23 ` [FFmpeg-devel] [PATCH 10/12] avfilter/f_select: port to activate Marton Balint
2025-06-24 19:23 ` [FFmpeg-devel] [PATCH 11/12] fftools/ffmpeg_filter: always reap all available frames before requesting new ones Marton Balint
2025-06-24 19:23 ` [FFmpeg-devel] [PATCH 12/12] avfilter/ffmpeg_filter: rate control all filter graphs Marton Balint
2025-06-25 18:23   ` Michael Niedermayer
2025-06-26 19:21     ` Marton Balint [this message]
2025-07-03 19:24       ` Marton Balint
2025-06-25 13:53 ` [FFmpeg-devel] [PATCH 01/12] avfilter: factorize requesting an input frame from multi output filters Nicolas George

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e026df0-2732-bb53-101b-d781036c4539@passwd.hu \
    --to=cus@passwd.hu \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git