From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 9F5294DEA1 for ; Tue, 4 Mar 2025 22:56:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A490368EB6A; Wed, 5 Mar 2025 00:55:57 +0200 (EET) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CCFA368EB3A for ; Wed, 5 Mar 2025 00:55:51 +0200 (EET) Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4394345e4d5so42194905e9.0 for ; Tue, 04 Mar 2025 14:55:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741128951; x=1741733751; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=PiimQCWExs3RFDY8XtEuz0TXJMeN+0U0tGr3SunuhRU=; b=mAqKzuqcWlzDSLczKCY+JDKCVppMCVVV0yWauxsSxEvkfYumlfVRQeSa2guZmWRHgr mq8jXRySVifamfP3b4Wee9gz68ooDeP0pGLMVNz5Oq/lRKTa/Q8GoHGTIQLQJjuhHdrr Iw1W3ZmaWYp6KqCyvaUEwYLhcXpJSWnUJjY6xqqitF2965Tsca+yBhVVHIwiCMOUqime 9yVWi5YZJYQDMYbumTvYt97OWNlcAzSaCjewVst9ytOnL2tyN8y6egi8FYtIXvZKUVcT q7mRT4G6O6FAJ52uRUyzjv+VtZbESRX9iEgLabucvzqgaIAoxp+bADp4v3kZjX716crg +0Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741128951; x=1741733751; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PiimQCWExs3RFDY8XtEuz0TXJMeN+0U0tGr3SunuhRU=; b=TPIJ+70SPCdNXCWTT+WUVyrsqgKRYLA3uySWoY04eLNG8XLZxxwjBfu4JTvIT6Pn+F NcL/SB9vFujbKPz/hqFeDiKM0BkEctWtZMO0uJFv5RhD+Kxf1BcfGOhfBF3rDyBNCPWo s/fVHR+zrrIXRB1nUO1oUKRYsfiiG96cpevy0MB86RasBR3TclkbGC9EsN/cCFC40miU 1xPvZydMwsWXxqGZTUUz1H55Fw/ElQSC+sHOb0ZxIFN1XSoG9zleoaFrJ/18F2zUpZJG EHKZMrS4IQcOPpqWzio36q9bJTps1Uv++pLQkxoTmODuA299YC0uVahXFegXTJXSSxn4 rvEA== X-Gm-Message-State: AOJu0YxeEqr+JOSTi0GEG2Ol3O4wqPQOAqSXWTV3CkmjA5n/J44pnH05 2Mz8WTaY4CwswsMrrm9YHW0BSiIK5pTVbTC5lY4+tlf1eWWSaQjqqCenNO+x X-Gm-Gg: ASbGncs4iRZAnRiCTfhqh6oOsq1YblqmJXjsrfRhXtl7WI11EtuHpLycSRawbzQ7BMg pr+AqfFTahWoZ90QyhbYJGCzD3nSnNf6PjtGyU/fP6ybzVu7UiEt+07MC0iaRPAi/M9iQ84rrcL J7ki/iNHkECqS1GyETvyULjhB5+15xVZP6Il3039HstMqq8s+BBbJKLre2ag+74kHJ4yp3hOd4J zUIhIZtCxXRMqaVYwCv939DP1W6BpGYMI+fjgvliS7azWEQpOcoXMXOVfKENXeHIJ6NslyhLlgB cqQrZr5JOOBTQgCZ/VAnMFrlnUC+J7Oh9lAY7gIQCflbw6NPi5Gh+ja3ImwYRCmB5+JKqZj2eOA lQA/mWzXq1z3O37C7 X-Google-Smtp-Source: AGHT+IGuNOTt63dpyzjO5cHf0ENcA5aeO1HcX7/mFFuXFEqign/FyMQEg/Q3sPzlsx8TPPq+1KAN4A== X-Received: by 2002:a05:600c:548a:b0:439:8e95:795b with SMTP id 5b1f17b1804b1-43bd29d8dbemr4375765e9.31.1741128950515; Tue, 04 Mar 2025 14:55:50 -0800 (PST) Received: from [192.168.1.42] (20.238-74-193.fia-dyn.isp.proximus.be. [193.74.238.20]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bd0483e80sm16710125e9.20.2025.03.04.14.55.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Mar 2025 14:55:49 -0800 (PST) Message-ID: <9dc9ece0-87c1-4bfe-ab86-beab02def09f@gmail.com> Date: Tue, 4 Mar 2025 23:55:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Ramiro Polla In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mpeg12dec: Use proper logcontext X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/4/25 23:11, Andreas Rheinhardt wrote: > Patch attached > diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c > index 843640edbf..14c028379e 100644 > --- a/libavcodec/mpeg12dec.c > +++ b/libavcodec/mpeg12dec.c > @@ -1655,11 +1655,11 @@ static int mpeg_decode_slice(MpegEncContext *s, int mb_y, > } > eos: // end of slice > if (get_bits_left(&s->gb) < 0) { > - av_log(s, AV_LOG_ERROR, "overread %d\n", -get_bits_left(&s->gb)); > + av_log(s->avctx, AV_LOG_ERROR, "overread %d\n", -get_bits_left(&s->gb)); > return AVERROR_INVALIDDATA; > } > *buf += (get_bits_count(&s->gb) - 1) / 8; > - ff_dlog(s, "Slice start:%d %d end:%d %d\n", s->resync_mb_x, s->resync_mb_y, s->mb_x, s->mb_y); > + ff_dlog(s->avctx, "Slice start:%d %d end:%d %d\n", s->resync_mb_x, s->resync_mb_y, s->mb_x, s->mb_y); > return 0; > } LGTM. We could also simplify mpeg_decode_slice() a bit more by using the local variables avctx, lowres, and field_pic (which have already been obtained from s). Ramiro _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".