Re: [FFmpeg-devel] [PATCH v4 0/2] use av_fopen_utf8() instead of plain fopen()

From: Tobias Rapp <t.rapp@noa-archive.com>
To: ffmpegagent <ffmpegagent@gmail.com>, ffmpeg-devel@ffmpeg.org
Cc: "Martin Storsjö" <martin@martin.st>,
	"Soft Works" <softworkz@hotmail.com>
Subject: Re: [FFmpeg-devel] [PATCH v4 0/2] use av_fopen_utf8() instead of plain fopen()
Date: Wed, 18 May 2022 09:01:25 +0200
Message-ID: <9dbea828-4cc9-0ab1-db1f-01571e9c9106@noa-archive.com> (raw)
In-Reply-To: <pull.26.v4.ffstaging.FFmpeg.1652790597.ffmpegagent@gmail.com>

On 17/05/2022 14:29, ffmpegagent wrote:
> Unify file access operations by replacing usages of direct calls to posix
> fopen()
> 
> v2: Remove changes to fftools for now
> v3: Add some additional replacements
> v4: Fix and improve commit messages
> 
> softworkz (2):
>    avfilter: use av_fopen_utf8() instead of plain fopen()
>    avcodec/dvdsubdec: use av_fopen_utf8() instead of plain fopen()
> 
>   libavcodec/dvdsubdec.c            | 2 +-
>   libavfilter/af_firequalizer.c     | 2 +-
>   libavfilter/vf_deshake.c          | 2 +-
>   libavfilter/vf_psnr.c             | 2 +-
>   libavfilter/vf_signature.c        | 4 ++--
>   libavfilter/vf_ssim.c             | 2 +-
>   libavfilter/vf_vidstabdetect.c    | 2 +-
>   libavfilter/vf_vidstabtransform.c | 2 +-
>   libavfilter/vf_vmafmotion.c       | 2 +-
>   9 files changed, 10 insertions(+), 10 deletions(-)
> 
> [...]

Commit messages look fine to me now. I will leave the decision to others 
about the order of changes -- whether this patch-set comes first, or the 
fix for the CRT linking issue (possibly replacing this public function 
with a private copy).

Regards,
Tobias

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".