From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3201F46D05 for ; Tue, 8 Aug 2023 21:55:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 36FE268C318; Wed, 9 Aug 2023 00:55:18 +0300 (EEST) Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3041568C124 for ; Wed, 9 Aug 2023 00:55:12 +0300 (EEST) Received: by mail-ed1-f66.google.com with SMTP id 4fb4d7f45d1cf-52256241c50so8749910a12.3 for ; Tue, 08 Aug 2023 14:55:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691531711; x=1692136511; h=content-transfer-encoding:in-reply-to:from:cc:content-language :subject:references:to:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=spRcHRT3aQq1KXPP/nEPa3RKtvA8l+FiRT0do53/zaI=; b=O7Nja6t98lEqL+c6EhZwyu5VkABB/GgZp4ZazcVXZYK3m9rxhqiKjHgoHhkFP+Buph DcmpaVN2aOLjDSlfTzNA2xkogOvccyN5Nd1xf87JA5Zd9rRLKVcf/msaXFA9uBe4rdhJ IJv3RJ3QLxuokkOIWGLrnuidQXp/hE7CGlNwNd1oV8el72NlQcFxMadVFqwR31t+coot doHVYH6bAZU+MQ4cHNKXV1okPzitR00o8RotWAntY9qIN03eSBExcJVQMaZDVmT5qqlf raO/uPWv2NimtmiV+wy6EW/inveipAUQh30avZHnyAEuie13vXvPErKb3qPJ7NEJkJ6P AU8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691531711; x=1692136511; h=content-transfer-encoding:in-reply-to:from:cc:content-language :subject:references:to:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=spRcHRT3aQq1KXPP/nEPa3RKtvA8l+FiRT0do53/zaI=; b=R90nRxKkq/ahrgv9rf9m18ZTMoG40DU2153MWesMTVmTnUgIgEg8fFkIQjmVO5fQLH bEGcQ5cSKD4VUrHforvA8N3axgnEH/d/aXoQ2Fy7HxddeCtvmLhFdM6VJNI2bFSbup2i 310+kNHvA++KvHnwpnVrMInn4WCSWkxsWCey+YZsDhQgJDIwLI+MSTd2RuGwD/Ijk36/ lPrEIa9sT9g4OP7f77XTwPbtlR3+EqsKrDI+9HPNgLy8BhwHh9UF4Yj6mrb7aSFBqDGv 9QIfpgPu0/s+ishSF9htyxPtC47cO43tce8L5NU5gInItCm7eJeQNBfJ5CLF5Se2j4C8 ObUA== X-Gm-Message-State: AOJu0YyTnizVhiMAbrirKkvUDJuWhGzCB5WX3WR3ivrTQYpY54MSRiFc buBZp8W3ENdHTYoOMS9I6BMfrbH3enSK/euEwA8= X-Google-Smtp-Source: AGHT+IF/Z6zqk0Tv60FeTwvABNNV+ERddHqA0wKt60cfd54JJgN0MbI9ZDmfS3IVGHyENRrnn5pKFQ== X-Received: by 2002:a17:907:1dc2:b0:99b:f820:5d0e with SMTP id og2-20020a1709071dc200b0099bf8205d0emr619124ejc.25.1691531711079; Tue, 08 Aug 2023 14:55:11 -0700 (PDT) Received: from [192.168.1.136] ([188.26.129.194]) by smtp.gmail.com with ESMTPSA id y16-20020a170906071000b00992d122af63sm7170996ejb.89.2023.08.08.14.55.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 14:55:10 -0700 (PDT) Message-ID: <9d6b8529-2623-4a8c-a5d1-6f72f709b37f@gmail.com> Date: Wed, 9 Aug 2023 00:55:09 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <4b2e5f71-f8b0-8abf-d3bc-daea4fbe3134@rothenpieler.org> Content-Language: en-US From: Michael Diesel In-Reply-To: <4b2e5f71-f8b0-8abf-d3bc-daea4fbe3134@rothenpieler.org> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: update amount of decoder surfaces from within sequence decode callback X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: r.arzumanyan@visionlabs.ai, timo@rothenpieler.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hello , after this patch I get stutter in the output video when using h264_cuvid as decoder With "surfaces" as -1 will result : CUVIDPARSERPARAMS::ulMaxNumDecodeSurfaces = 5 = CUVID_DEFAULT_NUM_SURFACES CUVIDDECODECREATEINFO::ulNumDecodeSurfaces = 8 = format->min_num_decode_surfaces + 3 As per NVDEC Video Decoder API Programming Guide / Creating a parser , the two values should be equal. cuvid_handle_video_sequence/pfnSequenceCallback should return a value : ">1: succeeded, and driver should override CUVIDPARSERPARAMS::ulMaxNumDecodeSurfaces with this return value" Something like: if(ctx->cuparseinfo.ulMaxNumDecodeSurfaces != cuinfo.ulNumDecodeSurfaces) return cuinfo.ulNumDecodeSurfaces; else return 1; This solves partially the problem , there's still occasional stutter , a value of 8 is not sufficient. On my test system 12 is the magic number. Timo Rothenpieler wrote: > applied with minor amendments. > > Turned the if-statements around, we don't do them that way around in > ffmpeg code. > And switched the surfaces option to have a default of -1, to not rely on > a magic value of 25. That could surprise users who happen to request 25 > surfaces. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".