Re: [FFmpeg-devel] [PATCH 7/7 v5] avcodec/hevcdec: export global side data in AVCodecContext

From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 7/7 v5] avcodec/hevcdec: export global side data in AVCodecContext
Date: Wed, 3 Apr 2024 08:31:15 -0300
Message-ID: <9d426b73-4ee3-4666-a3b4-4a473da7ce74@gmail.com> (raw)
In-Reply-To: <171213313946.28449.14791803443405725197@lain.khirnov.net>

On 4/3/2024 5:32 AM, Anton Khirnov wrote:
> Quoting James Almer (2024-03-28 17:52:50)
>> diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c
>> index fd356bd190..a693e12670 100644
>> --- a/libavcodec/pthread_frame.c
>> +++ b/libavcodec/pthread_frame.c
>> @@ -334,6 +334,15 @@ FF_ENABLE_DEPRECATION_WARNINGS
>>       if (for_user) {
>>           if (codec->update_thread_context_for_user)
>>               err = codec->update_thread_context_for_user(dst, src);
>> +
>> +        av_frame_side_data_free(&dst->decoded_side_data, &dst->nb_decoded_side_data);
>> +        for (int i = 0; i < src->nb_decoded_side_data; i++) {
>> +            int ret = av_frame_side_data_clone(&dst->decoded_side_data,
>> +                                               &dst->nb_decoded_side_data,
>> +                                               src->decoded_side_data[i], 0);
>> +            if (ret < 0)
>> +                return ret;
>> +        }
> 
> Seems wasteful to do this for every frame, when it only needs to be done
> once. Is there a reason not to put this code in init_thread()?

Hadn't thought about it. Will try that.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".