From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9BF364308B for ; Fri, 20 May 2022 11:37:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 274AD68B4A1; Fri, 20 May 2022 14:37:11 +0300 (EEST) Received: from btbn.de (btbn.de [136.243.74.85]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 032E368B235 for ; Fri, 20 May 2022 14:37:03 +0300 (EEST) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id A1F862D7085 for ; Fri, 20 May 2022 13:37:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1653046623; bh=TThcAF1htFuCCui7v+tQxj9xFb7MCQr3YqndPXLECxA=; h=Date:Subject:To:References:From:In-Reply-To; b=eOgS500z3crLV55w0DDIFe0kIQP/oyvbrjmxcrnMRF8f7VT+oW2VPhv0MWvXaAtbt ogD0+xN0domrX3OvKg0nG8tLGWDCOIkBURZiCmuqyugtCz4M4pdQKhUcYBcYdbjRB/ SShNTHDB5GPpDfoDqNdtU6VBeJBEWh5IxEvnPnXtbK9hSgwly3HHh64UrkYZkdfD3L ulc5vbVLfJ39p26gDyF24It4A+sHfS6IfbIBFB2QF1fvKTfugW074zaKCpgOkjtcim kZK0VVA+YOH/+7zmFB1jinSzoyoPxMetIQlHg4Afr8VM4hnxkdrRUBr5Vum5InaHyi fBfm/zmmmxo0A== Message-ID: <9d414f9e-0a17-b490-e54c-7ecace981af3@rothenpieler.org> Date: Fri, 20 May 2022 13:37:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <23cc0bf5-9cef-5b8d-7e4d-440776cd2e5f@rothenpieler.org> From: Timo Rothenpieler In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define X264_API_IMPORTS when compiling static X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 20/05/2022 12:39, Soft Works wrote: > > >> -----Original Message----- >> From: ffmpeg-devel On Behalf Of Timo >> Rothenpieler >> Sent: Friday, May 20, 2022 12:18 PM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define >> X264_API_IMPORTS when compiling static >> >> On 20/05/2022 00:52, softworkz wrote: >>> From: softworkz >>> >>> The definition of X264_API_IMPORTS is required for shared linking >>> (when MSVC is used) but it must not be defined in case of static >>> builds as is stated in x264.h: >> >> This doesn't seem right. It's about shared or static linking of >> libx264 >> itself, not ffmpeg. > > How about some custom macro like DISABLE_X264_API_IMPORTS that one > can set when desired? > > In that case there wouldn't be any logical irritation. > I'm still quite confused what the actual issue here is. Countless libraries ffmpeg depends on need those kind of macros to set the correct function import preamble. Why does x264 need special treatment? It correctly sets the desired flag via its pkg-config file. Is this some "pkg-config does not exist with msvc" thing? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".