From: Timo Rothenpieler <timo@rothenpieler.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define X264_API_IMPORTS when compiling static
Date: Fri, 20 May 2022 13:37:53 +0200
Message-ID: <9d414f9e-0a17-b490-e54c-7ecace981af3@rothenpieler.org> (raw)
In-Reply-To: <DM8P223MB03650416A5F23EC423D6B7AEBAD39@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
On 20/05/2022 12:39, Soft Works wrote:
>
>
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Timo
>> Rothenpieler
>> Sent: Friday, May 20, 2022 12:18 PM
>> To: ffmpeg-devel@ffmpeg.org
>> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define
>> X264_API_IMPORTS when compiling static
>>
>> On 20/05/2022 00:52, softworkz wrote:
>>> From: softworkz <softworkz@hotmail.com>
>>>
>>> The definition of X264_API_IMPORTS is required for shared linking
>>> (when MSVC is used) but it must not be defined in case of static
>>> builds as is stated in x264.h:
>>
>> This doesn't seem right. It's about shared or static linking of
>> libx264
>> itself, not ffmpeg.
>
> How about some custom macro like DISABLE_X264_API_IMPORTS that one
> can set when desired?
>
> In that case there wouldn't be any logical irritation.
>
I'm still quite confused what the actual issue here is.
Countless libraries ffmpeg depends on need those kind of macros to set
the correct function import preamble.
Why does x264 need special treatment? It correctly sets the desired flag
via its pkg-config file.
Is this some "pkg-config does not exist with msvc" thing?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-05-20 11:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 22:52 softworkz
2022-05-20 8:49 ` Derek Buitenhuis
2022-05-20 9:36 ` Soft Works
2022-05-20 10:18 ` Timo Rothenpieler
2022-05-20 10:39 ` Soft Works
2022-05-20 11:37 ` Timo Rothenpieler [this message]
2022-05-20 12:07 ` Soft Works
2022-05-20 12:49 ` Derek Buitenhuis
2022-05-20 12:51 ` Derek Buitenhuis
2022-05-20 12:54 ` Soft Works
2022-05-20 13:00 ` Derek Buitenhuis
2022-05-20 13:06 ` Soft Works
2022-05-20 13:13 ` Derek Buitenhuis
2022-05-20 13:24 ` Soft Works
2022-05-20 13:14 ` Soft Works
2022-05-20 15:23 ` [FFmpeg-devel] [PATCH v2] avcodec/libx264: allow to disable definition of X264_API_IMPORTS macro softworkz
2022-05-20 16:22 ` Derek Buitenhuis
2022-05-20 16:34 ` Hendrik Leppkes
2022-05-20 16:37 ` Soft Works
2022-05-20 16:47 ` Derek Buitenhuis
2022-05-20 16:51 ` Martin Storsjö
2022-05-20 16:55 ` Derek Buitenhuis
2022-05-20 17:47 ` Soft Works
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d414f9e-0a17-b490-e54c-7ecace981af3@rothenpieler.org \
--to=timo@rothenpieler.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git