From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BEE8F4323E for ; Sat, 25 Jun 2022 06:49:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A700568B7C4; Sat, 25 Jun 2022 09:49:48 +0300 (EEST) Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5F11768B6D1 for ; Sat, 25 Jun 2022 09:49:42 +0300 (EEST) Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4LVPjv6NxNz9sSd for ; Sat, 25 Jun 2022 08:49:39 +0200 (CEST) Message-ID: <9d0cdf7b-aa5b-328f-7085-c40bb7042715@gyani.pro> Date: Sat, 25 Jun 2022 12:19:36 +0530 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220625061156.11779-1-ffmpeg@gyani.pro> From: Gyan Doshi In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avfilter/Makefile: always make colorspace.o X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2022-06-25 12:16 pm, Andreas Rheinhardt wrote: > Gyan Doshi: >> Unbreaks libavfilter builds when configured with a subset of filters. >> >> drawutils added ff_draw_init2 in 6c3a82f043 which calls functions defined in >> colorspace.c. So the latter needs to be built alongside the former. >> --- > And why not just build it when it's needed? It's always needed. See the next line after my added line. Regards, Gyan > >> libavfilter/Makefile | 11 ++++++----- >> 1 file changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/libavfilter/Makefile b/libavfilter/Makefile >> index 7ba1c8a861..22b0a0ca15 100644 >> --- a/libavfilter/Makefile >> +++ b/libavfilter/Makefile >> @@ -13,6 +13,7 @@ OBJS = allfilters.o \ >> avfiltergraph.o \ >> buffersink.o \ >> buffersrc.o \ >> + colorspace.o \ >> drawutils.o \ >> fifo.o \ >> formats.o \ >> @@ -225,7 +226,7 @@ OBJS-$(CONFIG_COLORHOLD_FILTER) += vf_colorkey.o >> OBJS-$(CONFIG_COLORLEVELS_FILTER) += vf_colorlevels.o >> OBJS-$(CONFIG_COLORMAP_FILTER) += vf_colormap.o >> OBJS-$(CONFIG_COLORMATRIX_FILTER) += vf_colormatrix.o >> -OBJS-$(CONFIG_COLORSPACE_FILTER) += vf_colorspace.o colorspace.o colorspacedsp.o >> +OBJS-$(CONFIG_COLORSPACE_FILTER) += vf_colorspace.o colorspacedsp.o >> OBJS-$(CONFIG_COLORTEMPERATURE_FILTER) += vf_colortemperature.o >> OBJS-$(CONFIG_CONVOLUTION_FILTER) += vf_convolution.o >> OBJS-$(CONFIG_CONVOLUTION_OPENCL_FILTER) += vf_convolution_opencl.o opencl.o \ >> @@ -327,8 +328,8 @@ OBJS-$(CONFIG_HWMAP_FILTER) += vf_hwmap.o >> OBJS-$(CONFIG_HWUPLOAD_CUDA_FILTER) += vf_hwupload_cuda.o >> OBJS-$(CONFIG_HWUPLOAD_FILTER) += vf_hwupload.o >> OBJS-$(CONFIG_HYSTERESIS_FILTER) += vf_hysteresis.o framesync.o >> -OBJS-$(CONFIG_ICCDETECT_FILTER) += vf_iccdetect.o fflcms2.o colorspace.o >> -OBJS-$(CONFIG_ICCGEN_FILTER) += vf_iccgen.o fflcms2.o colorspace.o >> +OBJS-$(CONFIG_ICCDETECT_FILTER) += vf_iccdetect.o fflcms2.o >> +OBJS-$(CONFIG_ICCGEN_FILTER) += vf_iccgen.o fflcms2.o >> OBJS-$(CONFIG_IDENTITY_FILTER) += vf_identity.o >> OBJS-$(CONFIG_IDET_FILTER) += vf_idet.o >> OBJS-$(CONFIG_IL_FILTER) += vf_il.o >> @@ -492,8 +493,8 @@ OBJS-$(CONFIG_TLUT2_FILTER) += vf_lut2.o framesync.o >> OBJS-$(CONFIG_TMEDIAN_FILTER) += vf_xmedian.o framesync.o >> OBJS-$(CONFIG_TMIDEQUALIZER_FILTER) += vf_tmidequalizer.o >> OBJS-$(CONFIG_TMIX_FILTER) += vf_mix.o framesync.o >> -OBJS-$(CONFIG_TONEMAP_FILTER) += vf_tonemap.o colorspace.o >> -OBJS-$(CONFIG_TONEMAP_OPENCL_FILTER) += vf_tonemap_opencl.o colorspace.o opencl.o \ >> +OBJS-$(CONFIG_TONEMAP_FILTER) += vf_tonemap.o >> +OBJS-$(CONFIG_TONEMAP_OPENCL_FILTER) += vf_tonemap_opencl.o opencl.o \ >> opencl/tonemap.o opencl/colorspace_common.o >> OBJS-$(CONFIG_TONEMAP_VAAPI_FILTER) += vf_tonemap_vaapi.o vaapi_vpp.o >> OBJS-$(CONFIG_TPAD_FILTER) += vf_tpad.o > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".