From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AABEA48B10 for ; Thu, 2 May 2024 00:55:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2FAE768D76F; Thu, 2 May 2024 03:55:16 +0300 (EEST) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 69BC068D768 for ; Thu, 2 May 2024 03:55:09 +0300 (EEST) Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-2b346712919so614036a91.2 for ; Wed, 01 May 2024 17:55:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714611307; x=1715216107; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=vdlr2lqDphWMPdhwYU6TrfyBULKy5r6uL+IJQsKNAY8=; b=DkUv/Tz52VXxAztob2+5sqEadCj9f+AaGNhjawhdcH6J3v7Cayp5pXKqXBUK83+hCr 6/zO96O2/ZXJSbAvE5SrHYbfNwhngqyrOR1Va/o5lyzHM2WrAMtwURnFXQ+1Npy1Do+D sFdx8ICfvcZyuGf7SltYsQcW6KxXq1nw3+bQGxt324xGMXNUm58w6VcjxGBlrkQnPhS7 HU6s23Iy4QaZdaodx/KbcGWPJ8y8Qa6GzELgSB3dlBRELGK9MxmHtyV2z0N1sWdiXjSI SLPAlA5zZtanpcgUOtiLiQh3JMK69bRRqyH+ylEx/A4ENWE/E6qnDhYUfM1hhtlH7FiB 74zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714611307; x=1715216107; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vdlr2lqDphWMPdhwYU6TrfyBULKy5r6uL+IJQsKNAY8=; b=DzO83sx+sCwPRlGL78qwpLwsA8dZCjXbCc4yfsNcW0PmVakaAZ7hmwqCNOy7CnQJof jUQ0t0OGK9CUB2Sp3xwAxkxIzCEwHl/EZfNgflRIfmbgfws0vwc0ENxUeRVfXabl6NJ1 RyiJXn7YzBK3I1xUe1gfaRvtbh97NR59fVB4nbKPjQ4MqhQWGDFYjjJTuBsrytrnyynP WjNvMgC0+rWMY8n93etxz9pCX9yVX5qLz1T25X0Dr+5+Wn6qThal1qkxSR2HwuF4kKtG 3t58eXIgD+7S+NUEDvmNoOq/r/5BvuH4wtTAU4OBCHguLalkLEQ4jKX+vKb7dvVaTe9i Kwaw== X-Gm-Message-State: AOJu0YxCkMLM+bo/IrmcGGyqg2PzwKmgRDCY0bOfDIByJ2K0fenxl862 sFbuExdbeAOUrr+o8z2ttPL4fqoi2eK3ADkUmsC3NU62XFdYmdfaE9f8uw== X-Google-Smtp-Source: AGHT+IF7FfoU/MKmUd20QFtVZ4ej3AgK7IRV9BjCrZ0TojRzUEkNpBRkU6pJG7rGdKqhXkfU+//3Zw== X-Received: by 2002:a17:90b:81:b0:2ae:b8df:89e7 with SMTP id bb1-20020a17090b008100b002aeb8df89e7mr4521919pjb.38.1714611306758; Wed, 01 May 2024 17:55:06 -0700 (PDT) Received: from [192.168.0.10] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id fw14-20020a17090b128e00b002a2d4bf345bsm1935626pjb.55.2024.05.01.17.55.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 May 2024 17:55:06 -0700 (PDT) Message-ID: <9ceb515b-2e7c-49d4-802c-590052c99393@gmail.com> Date: Wed, 1 May 2024 21:55:04 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240502004150.3627661-1-michael@niedermayer.cc> <20240502004150.3627661-2-michael@niedermayer.cc> Content-Language: en-US From: James Almer In-Reply-To: <20240502004150.3627661-2-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 2/7] avcodec/av1dec: initialize ret in av1_receive_frame_internal() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5/1/2024 9:41 PM, Michael Niedermayer wrote: > Fixes: CID1596605 Uninitialized scalar variable > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/av1dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c > index 4f9222cca27..93ab04eb378 100644 > --- a/libavcodec/av1dec.c > +++ b/libavcodec/av1dec.c > @@ -1262,7 +1262,7 @@ static int av1_receive_frame_internal(AVCodecContext *avctx, AVFrame *frame) > { > AV1DecContext *s = avctx->priv_data; > AV1RawTileGroup *raw_tile_group = NULL; > - int i = 0, ret; > + int i = 0, ret = 0; > > for (i = s->nb_unit; i < s->current_obu.nb_units; i++) { > CodedBitstreamUnit *unit = &s->current_obu.units[i]; Should be ok. Alternatively, we could set ret to AVERROR_BUG here and to 0 in the places where it's missing (and that triggered coverity). _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".