Re: [FFmpeg-devel] [PATCH 2/7] avcodec/av1dec: initialize ret in av1_receive_frame_internal()

From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/7] avcodec/av1dec: initialize ret in av1_receive_frame_internal()
Date: Wed, 1 May 2024 21:55:04 -0300
Message-ID: <9ceb515b-2e7c-49d4-802c-590052c99393@gmail.com> (raw)
In-Reply-To: <20240502004150.3627661-2-michael@niedermayer.cc>

On 5/1/2024 9:41 PM, Michael Niedermayer wrote:
> Fixes: CID1596605 Uninitialized scalar variable
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>   libavcodec/av1dec.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
> index 4f9222cca27..93ab04eb378 100644
> --- a/libavcodec/av1dec.c
> +++ b/libavcodec/av1dec.c
> @@ -1262,7 +1262,7 @@ static int av1_receive_frame_internal(AVCodecContext *avctx, AVFrame *frame)
>   {
>       AV1DecContext *s = avctx->priv_data;
>       AV1RawTileGroup *raw_tile_group = NULL;
> -    int i = 0, ret;
> +    int i = 0, ret = 0;
>   
>       for (i = s->nb_unit; i < s->current_obu.nb_units; i++) {
>           CodedBitstreamUnit *unit = &s->current_obu.units[i];

Should be ok. Alternatively, we could set ret to AVERROR_BUG here and to 
0 in the places where it's missing (and that triggered coverity).
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".