From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3336845B03 for ; Sun, 16 Apr 2023 22:57:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 83A2F68BE45; Mon, 17 Apr 2023 01:57:05 +0300 (EEST) Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 041D6680341 for ; Mon, 17 Apr 2023 01:56:59 +0300 (EEST) Received: by mail-ot1-f54.google.com with SMTP id ds7-20020a0568306c0700b006a5cea70c02so1728638otb.8 for ; Sun, 16 Apr 2023 15:56:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681685818; x=1684277818; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xYa3rKMuPck2WlAesUIWBgyJs5nhI+lCUjubyomZix8=; b=ejwrAtFdO97uz1ngjtIkfiPH5YCxCBMF16GT4aRblbryRrikLBOyKY/VSJ1c8HQkba ugFDkuwjAEM+tmu3ome+9Xbm/duZu4hxIxbiX6Jg1RrQRDhDGQTVCTSsCt9UfYFVYPho pFUhLGDxlX4HjLuadBxgVhBzGadNOzdIXvkdVJxvuQYtGjyr6/xB1qK5XkySLyZWgpqv XKdIskHGUjQryPNeR55pUAFY/jmkoXsrL+miqJq7CVbiR/5Nvb6QlRPpwr8BFk7SwxW1 j1zTDC1lXCS2MmUYBEeRDWF5J8czC1uX9bysQ4HqWFez8c2fPCsomQ//O6BcUAukGaZc x+Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681685818; x=1684277818; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xYa3rKMuPck2WlAesUIWBgyJs5nhI+lCUjubyomZix8=; b=Z/FkB5lwYZOd3BGqYO5J3uIbVffTfxNnitFqTQ5TvF6lyD6GIc5tpwDpPCthZDfWcW E04aVB/Kv/GNfXH0e0LgbxntycxeYX2dB/hwEYlW+K48qFYBSVCHxa7jGHti6CksyaLX WeQqQE/4q5XgLkG+kx3OADrkPcJwc6ugR/KgArcZzcD7t0fd9Z6mXzfhqP2aTRKc/weE ttIx1noLvmmF/cQ56xCsMmnEEfcZrFDWT8b+mjO/rGVDANq4KjHpo56hlb/4CA97q5Zw HV9nnp6xtNtrOyvHl3UDgS8gs8geh4WiKsVp1FusYIAET+HeJwVO4HC+uENr+lGUeX0a pFOg== X-Gm-Message-State: AAQBX9fwwTq/mzTzAXASy/JmeSYTMlfQxqjxLPFAvZqCo3qZ/gYUEZnp e9RxvlsV5vKDtUhXhXvfhwtgbwcQfbU= X-Google-Smtp-Source: AKy350Zr2BvKjY1bPqwZOueQsEArtkhuQyUxpzEXElSW6kGkRoLWQ4p/cWnixfZAodPLjDOnHSAkog== X-Received: by 2002:a9d:6f0b:0:b0:6a1:3101:8e2e with SMTP id n11-20020a9d6f0b000000b006a131018e2emr5610886otq.29.1681685818135; Sun, 16 Apr 2023 15:56:58 -0700 (PDT) Received: from [192.168.0.15] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id z10-20020a9d7a4a000000b006a4244d2a7asm3868774otm.9.2023.04.16.15.56.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Apr 2023 15:56:57 -0700 (PDT) Message-ID: <9c9cb310-7c50-a400-4165-51468f5a9af5@gmail.com> Date: Sun, 16 Apr 2023 19:57:00 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230416222518.21308-1-michael@niedermayer.cc> From: James Almer In-Reply-To: <20230416222518.21308-1-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 1/5] avcodec/pcm_rechunk_bsf: unref packet before putting a new one in X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/16/2023 7:25 PM, Michael Niedermayer wrote: > Fixes: memleak > Fixes: 45982/clusterfuzz-testcase-minimized-ffmpeg_BSF_PCM_RECHUNK_fuzzer-5562089618407424 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/pcm_rechunk_bsf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/pcm_rechunk_bsf.c b/libavcodec/pcm_rechunk_bsf.c > index 108d9e90b99..3f43934fe9a 100644 > --- a/libavcodec/pcm_rechunk_bsf.c > +++ b/libavcodec/pcm_rechunk_bsf.c > @@ -153,6 +153,7 @@ static int rechunk_filter(AVBSFContext *ctx, AVPacket *pkt) > } > } > > + av_packet_unref(s->in_pkt); This could be pointing to a bug in the above code, and unreffing here like this would result in data loss. Does the following change also fix the memleak? > diff --git a/libavcodec/pcm_rechunk_bsf.c b/libavcodec/pcm_rechunk_bsf.c > index 108d9e90b9..032f914916 100644 > --- a/libavcodec/pcm_rechunk_bsf.c > +++ b/libavcodec/pcm_rechunk_bsf.c > @@ -151,7 +151,8 @@ static int rechunk_filter(AVBSFContext *ctx, AVPacket *pkt) > av_packet_move_ref(pkt, s->in_pkt); > return send_packet(s, nb_samples, pkt); > } > - } > + } else > + av_packet_unref(s->in_pkt); > > ret = ff_bsf_get_packet_ref(ctx, s->in_pkt); > if (ret == AVERROR_EOF && s->out_pkt->size) { If it does then a zero sized packet with either only side data or that went through the av_packet_make_refcounted() in av_bsf_send_packet() that left it with an allocated padding buffer was fed to this bsf. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".