From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B04F74A5E8 for ; Mon, 1 Apr 2024 19:37:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B63AF68CE36; Mon, 1 Apr 2024 22:37:51 +0300 (EEST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C4B7A68CAFF for ; Mon, 1 Apr 2024 22:37:44 +0300 (EEST) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1def3340682so38277425ad.1 for ; Mon, 01 Apr 2024 12:37:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712000262; x=1712605062; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=EHMaO+aeK7s8S05NsRyDk+Zk3pWwn6j4nVBlPa9WHdQ=; b=LVsXwSwE0aOd58R46Cv71M3VMU7xsRbJ8g4xOZzcaOlG5SX7tMfI3yymavlEN391GG t2M6UNYl+m4P7o1Mo8REWV9TZ1jdwabXYp//9aOpVs44fcz3dDV4eBBMYzqG4HbcAgzo gUYBjrppVFaA70XIa+ZX0Eb/MjudmlM6kCnrL9cF6yah3vlbbi8UJ1oWrX4Zj1l/UQOr mcd3OkxJk2wN6CxlIHOHxE2UZ7/gxDABWZ//qPdvTl4V7cOYfcvky3wk1pKVbzqSf06z 1OPxV0VCgiDfKtfDiW7gY5OZo3q2IV6NPKBxs0MlnuxX0baRtDoljpCkeKSkItnmUPb9 5/6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712000262; x=1712605062; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EHMaO+aeK7s8S05NsRyDk+Zk3pWwn6j4nVBlPa9WHdQ=; b=UEeE8JXzc5E5oQmFSvZMdwQydxYcE37kaFBdgvAXGXN7S6CpE0E9/rgaWtEe7f0Qhi PSZhJrCT1SW1IdvaecrWQeP5/5lDYGQHeoXraMCxsuC3seqvtPd8ApxUPQLPiycX+ZLL 6aYQT6Wj5nCLC3E+zCZRgInbJdWHdzzQfBlOmFmZ2ugvjKnr2+v+t5XRc/Ra34G1Ux5L kX3EGDOTvNNrqrTxJe4UnFzFWRQu5wcz24GcCkfKwOAs/JELkoskSXNCzSMKjCQXufJ0 kQ/wRHvFz3ZR09cpx4n/lQ36AtDkcNZm4pmKPVYXcUBc23H/Er6k8Vtm9D/7l65G76Ah 3yAQ== X-Gm-Message-State: AOJu0Yzs8eVAwkmjsnhYfa7GyT3bAgb1EoWYrGYCCs3firPNOBfH4CoL KsVNfFTI3EdOBTi7c8Q7kL3/zPedgnvlMiUvD0teV+BuvR0IB8K/dKPNisD+ X-Google-Smtp-Source: AGHT+IHnC7ba5GT7CVwHu1KT9436U8vsYbZMA0C9EVC5S2fISfINlQitaU07uGGHNhIcp9XTc41hXw== X-Received: by 2002:a17:903:40c7:b0:1e2:23b8:9880 with SMTP id t7-20020a17090340c700b001e223b89880mr15208993pld.35.1712000262051; Mon, 01 Apr 2024 12:37:42 -0700 (PDT) Received: from [192.168.0.15] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id im15-20020a170902bb0f00b001da15580ca8sm9512424plb.52.2024.04.01.12.37.40 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Apr 2024 12:37:41 -0700 (PDT) Message-ID: <9c53d6b4-eff3-4832-a87f-7896e177e998@gmail.com> Date: Mon, 1 Apr 2024 16:37:53 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240401185621.15297-1-cus@passwd.hu> <20240401185621.15297-3-cus@passwd.hu> Content-Language: en-US From: James Almer In-Reply-To: <20240401185621.15297-3-cus@passwd.hu> Subject: Re: [FFmpeg-devel] [PATCH 3/4] avformat/mov_chan: respect channel order when parsing and creating chnl atom X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/1/2024 3:56 PM, Marton Balint wrote: > Previously we always assumed that the channels are in native order, even if > they were not. The new channel layout API allows us to signal the proper > channel order, so let's do so. > > Signed-off-by: Marton Balint > --- > libavformat/mov_chan.c | 145 +++++++++++++++++++++---------------- > libavformat/mov_chan.h | 5 +- > tests/ref/fate/mov-mp4-pcm | 2 +- > 3 files changed, 86 insertions(+), 66 deletions(-) [...] > diff --git a/tests/ref/fate/mov-mp4-pcm b/tests/ref/fate/mov-mp4-pcm > index 6bae8f800b..19a978df95 100644 > --- a/tests/ref/fate/mov-mp4-pcm > +++ b/tests/ref/fate/mov-mp4-pcm > @@ -1,4 +1,4 @@ > -99ad26b4054794e84bd962a1124cdccf *tests/data/fate/mov-mp4-pcm.mp4 > +462668dd69e7ce4fde4934d1d5978531 *tests/data/fate/mov-mp4-pcm.mp4 What changes in the output? > 10587977 tests/data/fate/mov-mp4-pcm.mp4 > #tb 0: 1/44100 > #media_type 0: audio _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".