From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 289C3486C2 for ; Thu, 14 Dec 2023 10:34:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 36ABB68D250; Thu, 14 Dec 2023 12:34:19 +0200 (EET) Received: from shout01.mail.de (shout01.mail.de [62.201.172.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 134D068D21A for ; Thu, 14 Dec 2023 12:34:13 +0200 (EET) Received: from postfix01.mail.de (postfix01.bt.mail.de [10.0.121.125]) by shout01.mail.de (Postfix) with ESMTP id AC0C0245BD7 for ; Thu, 14 Dec 2023 11:34:12 +0100 (CET) Received: from smtp01.mail.de (smtp04.bt.mail.de [10.0.121.214]) by postfix01.mail.de (Postfix) with ESMTP id 94A448030F for ; Thu, 14 Dec 2023 11:34:12 +0100 (CET) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp01.mail.de (Postfix) with ESMTPSA id 6893A240A52 for ; Thu, 14 Dec 2023 11:34:12 +0100 (CET) Message-ID: <9c0f12c9-5131-4f92-aff9-d48f5020bdec@mail.de> Date: Thu, 14 Dec 2023 11:34:11 +0100 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20231211150725.46473-1-thilo.borgmann@mail.de> <20231211150725.46473-3-thilo.borgmann@mail.de> <170246885429.8914.10051704276943894799@lain.khirnov.net> <170246928230.8914.12754643765966025844@lain.khirnov.net> <170247117981.8914.16828787197695281420@lain.khirnov.net> <170248489636.8914.14641721027481345642@lain.khirnov.net> <170253142724.8914.2591211066924714059@lain.khirnov.net> In-Reply-To: <170253142724.8914.2591211066924714059@lain.khirnov.net> X-purgate: clean X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate: clean X-purgate-size: 908 X-purgate-ID: 154282::1702550052-077EF338-60158543/0/0 Subject: Re: [FFmpeg-devel] [PATCH 2/5] fftools/ffmpeg: move parsing of -stats_* specifiers to lavu/parseutils X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Thilo Borgmann via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Thilo Borgmann Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Am 14.12.23 um 06:23 schrieb Anton Khirnov: > Quoting Thilo Borgmann via ffmpeg-devel (2023-12-13 19:17:04) >> Am 13.12.23 um 17:28 schrieb Anton Khirnov: >>> It is bad practice to design library features around the needs and >>> limitations of a single specific caller. >> >> The callers here would be the CLI and this filter. > > First, public APIs should be designed for general classes of use cases, > not specific callers. Parsing a "...{var0}...{varN}..." string for its variables appears quite generic to me. IMO, especially for libavutil, you think a bit too ideological here. A) How about putting it under avpriv_ then? B) Not filibustering about lib design, nor contradictory support of this patch, but use a fixed format. IMHO just sad for the user and a drawback for us not being able to support the same format strings in the CLI & filters without redundant code. -Thilo _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".