From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id CCFA74F164
for <ffmpegdev@gitmailbox.com>; Mon, 16 Jun 2025 07:11:41 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id E0F6568DAAA;
Mon, 16 Jun 2025 10:11:36 +0300 (EEST)
Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com
[209.85.167.46])
by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 5243568C5D9
for <ffmpeg-devel@ffmpeg.org>; Mon, 16 Jun 2025 10:11:30 +0300 (EEST)
Received: by mail-lf1-f46.google.com with SMTP id
2adb3069b0e04-553b9eb2299so1183388e87.0
for <ffmpeg-devel@ffmpeg.org>; Mon, 16 Jun 2025 00:11:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=martin-st.20230601.gappssmtp.com; s=20230601; t=1750057889; x=1750662689;
darn=ffmpeg.org;
h=mime-version:references:message-id:in-reply-to:subject:cc:to:from
:date:from:to:cc:subject:date:message-id:reply-to;
bh=StwmyzqIxWAvMGORfZLFqzuwPTQZo6nDblE+wNRB+98=;
b=QFSTnorFxrL3joARzwEJZ0/B4VUzuuMV9ihANx3hkFmLHp212qM9LDi27ZjVNE8hU2
7Ubu8GPCYvyrbqR8FKA5pSn7unkKJUnQygmYvcuDNjl4L65oyLNPqLy4zxb6c1XZQP5a
ne2pqqmhY/HhU14fCBaVDYL0bitGit/w66uGgoQj9Zx4NXA/uyLZ0nAvPfaZODB47CQI
YKqodqt/cIvJxD8zxNz8o4nc1XPLzVQ61OWky5eO8Clrv3VpIKwq5CI/Uo2HwYAw0HVT
21HKPgUWDY5t2fK1Aapr5XwXQukEjn6DzYsETGJameXNIfhzSa/dskK0pS8ieMMMwT8k
pGvA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1750057889; x=1750662689;
h=mime-version:references:message-id:in-reply-to:subject:cc:to:from
:date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=StwmyzqIxWAvMGORfZLFqzuwPTQZo6nDblE+wNRB+98=;
b=von/OIJcXN7uz4PnjTFHqk3O6dHxGZUYnJZthHKHNQejM3zh6gCQPrfbNNYyENBajc
Qm2OJzUMMPS5odvclryN3GG/JP9W1JMXRI5Q4jGy+vv/0WbpTIZDL2F6Ky0yXORFXIwv
2cpy9W/TRPHvvec8esrcsbmuHRlPEczBsF6Py/0AP0vOZ1usM8WGhChXv2PsmxUrzHQW
WuoBm2Y1GDtuDStMJRmEt3EWA/9N2mHg0K5DEi32xMH/iLcd+9K369Oy3T4ktUaske6o
utJ0vdAvRgAI4HBzLlRzjgl5mBlT9YNGRV9B+F3VUaQX+HHB/Cr+8ouR6zcKSmrwe9Zq
yEag==
X-Gm-Message-State: AOJu0YxVDy/zAth/Cvzxv/+7CzUfnM2SxINELQ8fC+zrG7WMK/uq1vpu
N+y+O98/erKC8BRtCcMa5HVNSMzT7ULGANUxiqgdo5Ugj/hvryF+y/MrSHKuNEOjB2lIMCdm5Qu
XD0UtHg==
X-Gm-Gg: ASbGncuDMcxW6l0qNPMQz+OwULg4qGi6Sf5L/e4z2DA5sTBelr0HuriGhOD2yA1SkXl
HMFEEU/xbD8f/ntFZYx3Ws1iAkJGtL76LOloeXYOOfbSoHwXi2TcOXt7gpGa/5LD9zrkKEzY+6K
oSf2kbCfaC3OhesK5aItaQnHfuxzyxVHXr0METZ0EoJMlu3ZVUVGYuhoC6Q1dMHMso+nU67Nq01
L2SDwkFvKyPFMUUXt41Gq4ix9FGDv8I1CSQmLR700yTwxUSabx6Ja2i/w8evYlg1BCwgx0ev3cf
cc47/eGDfkJlqSOsGi66EFsotZXbrg4yo3TfeeoEOJeeOMSt059dNpQEeA2BiKHu0FA12ulLArM
m0e9VXwmldLpcv0MX5vG64ws3OErDnWyc/rX+T+/nCyaZ6mUD8TT3sia/FQ==
X-Google-Smtp-Source: AGHT+IGektDKIjP9wESWghLBOacdWFCbxmRKThYv8rFlyPG6nYAZn5dS55KPBUuYkXC9jy2p0r5xPA==
X-Received: by 2002:a05:6512:ad0:b0:552:21b9:8bae with SMTP id
2adb3069b0e04-553b548c4d6mr2266426e87.7.1750057889129;
Mon, 16 Jun 2025 00:11:29 -0700 (PDT)
Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net
(tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2])
by smtp.gmail.com with ESMTPSA id
2adb3069b0e04-553ac1e0c73sm1444688e87.198.2025.06.16.00.11.28
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 16 Jun 2025 00:11:28 -0700 (PDT)
Date: Mon, 16 Jun 2025 10:11:24 +0300 (EEST)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <tencent_8DE63D108866DFE7FE2AA293011C460BAA06@qq.com>
Message-ID: <9b96e57-4e79-96da-69a9-eba9a3a8c9b0@martin.st>
References: <tencent_8DE63D108866DFE7FE2AA293011C460BAA06@qq.com>
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH] checkasm/h264dsp: Fix stack overflow in
check_idct_dequant
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Zhao Zhili <zhilizhao@tencent.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/9b96e57-4e79-96da-69a9-eba9a3a8c9b0@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
On Mon, 16 Jun 2025, Zhao Zhili wrote:
> From: Zhao Zhili <zhilizhao@tencent.com>
>
> ---
> tests/checkasm/h264dsp.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/tests/checkasm/h264dsp.c b/tests/checkasm/h264dsp.c
> index f5f9650224..006532e08b 100644
> --- a/tests/checkasm/h264dsp.c
> +++ b/tests/checkasm/h264dsp.c
> @@ -328,7 +328,7 @@ static void check_idct_multiple(void)
> static void check_idct_dequant(void)
> {
> static const int depths[5] = { 8, 9, 10, 12, 14 };
> - LOCAL_ALIGNED_16(int16_t, src, [16]);
> + LOCAL_ALIGNED_16(int16_t, src, [16 * 2]);
> /* Ensure dst buffers are large enough to hold dctcoefs of all bit-depths. */
> LOCAL_ALIGNED_16(uint8_t, dst0, [16 * 16 * sizeof(int32_t)]);
Thanks for catching this! If the src buffer also is either int16_t or
int32_t, can we make it uint8_t and use sizeof(int32_t) there as well just
like dst, and move (and update) the comment above the src buffer too?
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".