Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Mark Thompson <sw@jkqxz.net>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 4/6] nvdec_av1: Use av1dec force_integer_mv value
Date: Mon, 6 May 2024 20:30:29 +0100
Message-ID: <9b7c67e3-78a0-42b6-b239-a22e9afa90b3@jkqxz.net> (raw)
In-Reply-To: <c9597162-dd13-495f-a932-6259bd50ae82@rothenpieler.org>

On 06/05/2024 18:19, Timo Rothenpieler wrote:
> On 27.04.2024 17:30, Mark Thompson wrote:
>> ---
>>   libavcodec/nvdec_av1.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/libavcodec/nvdec_av1.c b/libavcodec/nvdec_av1.c
>> index 4efa420e66..8a46db1ed5 100644
>> --- a/libavcodec/nvdec_av1.c
>> +++ b/libavcodec/nvdec_av1.c
>> @@ -106,9 +106,7 @@ static int nvdec_av1_start_frame(AVCodecContext *avctx, const uint8_t *buffer, u
>>               .show_frame                   = frame_header->show_frame,
>>               .disable_cdf_update           = frame_header->disable_cdf_update,
>>               .allow_screen_content_tools   = frame_header->allow_screen_content_tools,
>> -            .force_integer_mv             = frame_header->force_integer_mv ||
>> -                                            frame_header->frame_type == AV1_FRAME_INTRA_ONLY ||
>> -                                            frame_header->frame_type == AV1_FRAME_KEY,
>> +            .force_integer_mv             = s->cur_frame.force_integer_mv;
> 
> that ";" should be a ","
> 
> Works fine with that fixed.

Urgh, thank you for testing and catching that.

Fixed and pushed the set (with approval from Lynne).

Thanks,

- Mark
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-05-06 19:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-27 15:30 [FFmpeg-devel] [PATCH 1/6] av1dec: Add force_integer_mv derived field for decoder use Mark Thompson
2024-04-27 15:30 ` [FFmpeg-devel] [PATCH 2/6] dxva2_av1: Use av1dec force_integer_mv value Mark Thompson
2024-04-27 15:30 ` [FFmpeg-devel] [PATCH 3/6] vdpau_av1: " Mark Thompson
2024-04-27 15:30 ` [FFmpeg-devel] [PATCH 4/6] nvdec_av1: " Mark Thompson
2024-05-06 17:19   ` Timo Rothenpieler
2024-05-06 19:30     ` Mark Thompson [this message]
2024-04-27 15:30 ` [FFmpeg-devel] [PATCH 5/6] vaapi_av1: Fix " Mark Thompson
2024-04-30  6:03   ` Xiang, Haihao
2024-04-27 15:30 ` [FFmpeg-devel] [PATCH 6/6] vulkan_av1: " Mark Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b7c67e3-78a0-42b6-b239-a22e9afa90b3@jkqxz.net \
    --to=sw@jkqxz.net \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git