From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7E4384105D for ; Fri, 15 Apr 2022 01:37:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3D7AB68B4A7; Fri, 15 Apr 2022 04:37:30 +0300 (EEST) Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7F4B668B056 for ; Fri, 15 Apr 2022 04:37:23 +0300 (EEST) Received: by mail-qt1-f179.google.com with SMTP id z19so5222951qtw.2 for ; Thu, 14 Apr 2022 18:37:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=7dPofTz/L2/jy8aanPJFj+tAf0kHvua9mcglUsHMMnU=; b=cI+dLmG7r1B486hxToAQ1c9Dy2OfkCStQiAb5tKmE0HuGE9MAWk96mdQDfJn+Ea1SU YfKBVlCWe6cz2UIqS7yVdi07g3e2tFnbhNQZ2OWOmBdndp4hv6NY6eISksblRqnR00pb 0oXueiQdEjv64Zu/Rchq1TgvtOQi1WXcx6NefK/gQdTx92OV9zJud+EQ8ewg4uJGHA/f 5R89DXTZ+vfz69u/vxf/s3HhsnkCreyQc+3QHMhTUd9qo41KHgjf7K3U3fonfovTF5I5 n42jV692BiieD6bltanTMHrMF1CLK1WAv7ozBzWaFvYTaeN7Ld+k/7VanyFmrYbgs92I YqDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=7dPofTz/L2/jy8aanPJFj+tAf0kHvua9mcglUsHMMnU=; b=57sE6DBzrpd2K1FRIFWfyTVmBTWzcn9uile2YPjRUZjyipzgwEHywlktPeL6qo3mku 8yWfnQ0rGkgJsN2asXII5iLpw6x1D0D7Be40DuRmnabMmx/UBd6/vZc8eo6YRFtKJEac 2rq3wG0xBPujunkvn1uSrew4TM8fufEO8RoTxqR6XSKvLY3vDKaWW81EwmWh/VqH7iKS sU3LbBbraK/yrazv1pxxr2Egq09w26oU9RIxVkxI4T0KaZntEeBN0hiWWQm3QzG6YZ08 5cEl8vDWte+zZvuVxlmiDkoI+iShccjTQPlzwjylZ8sBeyJWvCeE+9R1h3hebBLrMvHo rL0w== X-Gm-Message-State: AOAM533aaqJr6EhwSsts9xaRF2ZoLlzQ0cWeCwfZlgRts+0GNCyrCyhT 4u4C8wu5JyVvqV1PIhTo9rbIWCLbzoo= X-Google-Smtp-Source: ABdhPJxKlCHlh7jH+ndWWoDWtns4+VduVfdTRQchfoF5pAZALjliINvJWyFCqLZC84QCmrtJZVxneQ== X-Received: by 2002:ac8:41c8:0:b0:2f1:e82a:4cba with SMTP id o8-20020ac841c8000000b002f1e82a4cbamr3042822qtm.98.1649986641609; Thu, 14 Apr 2022 18:37:21 -0700 (PDT) Received: from [192.168.1.35] (c-68-41-54-207.hsd1.mi.comcast.net. [68.41.54.207]) by smtp.gmail.com with ESMTPSA id p7-20020a05620a22a700b0069c37e2c473sm1723243qkh.94.2022.04.14.18.37.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Apr 2022 18:37:21 -0700 (PDT) Message-ID: <9b4c385d-6d26-ef40-de65-0896e4f3b38a@gmail.com> Date: Thu, 14 Apr 2022 21:37:20 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US-large To: FFmpeg development discussions and patches References: <20220412055333.62424-1-leo.izen@gmail.com> <20220412055333.62424-4-leo.izen@gmail.com> <164995854773.17571.4529122301029877169@lain.red.khirnov.net> From: Leo Izen In-Reply-To: <164995854773.17571.4529122301029877169@lain.red.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH v14 3/4] avcodec/libjxl: add Jpeg XL encoding via libjxl X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/14/22 13:49, Anton Khirnov wrote: > Quoting Leo Izen (2022-04-12 07:53:32) >> + >> + while (1) { >> + jret = JxlEncoderProcessOutput(ctx->encoder, &next_out, &available); >> + if (jret == JXL_ENC_ERROR) { >> + av_log(avctx, AV_LOG_ERROR, "Unspecified libjxl error occurred\n"); >> + return AVERROR_EXTERNAL; >> + } >> + bytes_written = ctx->buffer_size - available; >> + /* all data passed has been encoded */ >> + if (jret == JXL_ENC_SUCCESS) >> + break; >> + if (jret == JXL_ENC_NEED_MORE_OUTPUT) { > Is it possible for the encoder to return anything other than the three > codes you're handling? Won't you get into an infinite loop if it does? > It's just these three, according to the documentation. https://libjxl.readthedocs.io/en/latest/api_encoder.html -Leo Izen (thebombzen) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".