Re: [FFmpeg-devel] [PATCH v14 3/4] avcodec/libjxl: add Jpeg XL encoding via libjxl

From: Leo Izen <leo.izen@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v14 3/4] avcodec/libjxl: add Jpeg XL encoding via libjxl
Date: Thu, 14 Apr 2022 21:37:20 -0400
Message-ID: <9b4c385d-6d26-ef40-de65-0896e4f3b38a@gmail.com> (raw)
In-Reply-To: <164995854773.17571.4529122301029877169@lain.red.khirnov.net>

On 4/14/22 13:49, Anton Khirnov wrote:
> Quoting Leo Izen (2022-04-12 07:53:32)
>> +
>> +    while (1) {
>> +        jret = JxlEncoderProcessOutput(ctx->encoder, &next_out, &available);
>> +        if (jret == JXL_ENC_ERROR) {
>> +            av_log(avctx, AV_LOG_ERROR, "Unspecified libjxl error occurred\n");
>> +            return AVERROR_EXTERNAL;
>> +        }
>> +        bytes_written = ctx->buffer_size - available;
>> +        /* all data passed has been encoded */
>> +        if (jret == JXL_ENC_SUCCESS)
>> +            break;
>> +        if (jret == JXL_ENC_NEED_MORE_OUTPUT) {
> Is it possible for the encoder to return anything other than the three
> codes you're handling? Won't you get into an infinite loop if it does?
>
It's just these three, according to the documentation. 
https://libjxl.readthedocs.io/en/latest/api_encoder.html

-Leo Izen (thebombzen)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".