From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/3] x86/ac3dsp: add ff_float_to_fixed24_avx2()
Date: Thu, 23 Nov 2023 08:51:32 -0300
Message-ID: <9b27b56c-b272-435c-be87-80fd2ff25317@gmail.com> (raw)
In-Reply-To: <CAK+ULv4uFo7R5AsEbLVceY4KSU0-3dF1MTZ+diXbbCsgzo15KQ@mail.gmail.com>
On 11/23/2023 3:56 AM, Kieran Kunhya wrote:
> On Wed, 22 Nov 2023, 19:49 James Almer, <jamrial@gmail.com> wrote:
>
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>> libavcodec/ac3dsp.h | 4 ++--
>> libavcodec/ac3enc_template.c | 2 +-
>> libavcodec/x86/ac3dsp.asm | 28 ++++++++++++++++++++++++++--
>> libavcodec/x86/ac3dsp_init.c | 4 ++++
>> 4 files changed, 33 insertions(+), 5 deletions(-)
>>
>
> I think this is AVX, I might be wrong but I don't see any AVX2.
>
> Kieran
movdqa wiht ymm is avx2. I could change it to movaps, but technically
the registers contain floats and i don't know if any old AVX cpu has
penalties for changing domains.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-11-23 11:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 19:49 [FFmpeg-devel] [PATCH 1/3] x86/ac3dsp: reduce instruction count inside the float_to_fixed24 loop James Almer
2023-11-22 19:49 ` [FFmpeg-devel] [PATCH 2/3] x86/ac3dsp: add ff_float_to_fixed24_avx2() James Almer
2023-11-23 6:56 ` Kieran Kunhya
2023-11-23 11:51 ` James Almer [this message]
2023-11-23 15:19 ` Henrik Gramner via ffmpeg-devel
2023-11-22 19:49 ` [FFmpeg-devel] [PATCH 3/3] avcodec/ac3dsp: make len a size_t in float_to_fixed24 James Almer
2023-11-22 20:05 ` Rémi Denis-Courmont
2023-11-24 21:01 ` Michael Niedermayer
2023-11-24 21:03 ` James Almer
2023-11-24 23:49 ` Michael Niedermayer
2023-11-26 10:29 ` Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b27b56c-b272-435c-be87-80fd2ff25317@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git