From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/hevcdsp: Offset ff_hevc_.pel_filters to simplify addressing
Date: Tue, 13 Feb 2024 20:26:59 -0300
Message-ID: <9afe1db2-243a-4b5f-9b08-e6db34c8fc47@gmail.com> (raw)
In-Reply-To: <CAFXK13f_Lgh5Ejy=obondLRRiEzbzho5iR==KPO2x2YZjP3gtA@mail.gmail.com>
On 2/12/2024 11:54 PM, Nuo Mi wrote:
> On Sun, Feb 11, 2024 at 4:21 PM Andreas Rheinhardt <
> andreas.rheinhardt@outlook.com> wrote:
>
>> Besides simplifying address computations (it saves 432B of .text
>> in hevcdsp.o alone here) it also fixes undefined behaviour that
>> occurs if mx or my are 0 (happens when the filters are unused)
>> because they lead to an array index of -1 in the old code.
>> This happens in the checkasm-hevc_pel FATE-test.
>>
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
>>
>> Thank you, Andreas,
>
> Hi all,
> If there are no objections, I'll merge it tomorrow.
Just pushed it. Thanks Andreas for fixing this.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-02-13 23:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 8:23 Andreas Rheinhardt
2024-02-11 11:36 ` Nuo Mi
2024-02-11 21:48 ` Christophe Gisquet
2024-02-13 2:51 ` Nuo Mi
2024-02-11 11:47 ` Nuo Mi
2024-02-13 2:54 ` Nuo Mi
2024-02-13 23:26 ` James Almer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9afe1db2-243a-4b5f-9b08-e6db34c8fc47@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git