From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 6/6 v2] avformat/movenc: add support for Immersive Audio Model and Formats in ISOBMFF
Date: Mon, 5 Feb 2024 12:28:58 -0300
Message-ID: <9ae35670-f7bb-4f8d-ac4e-bb144883bbe6@gmail.com> (raw)
In-Reply-To: <AS8P250MB0744C56210D28C7098AFC51D8F472@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
On 2/5/2024 12:28 PM, Andreas Rheinhardt wrote:
> James Almer:
>> On 2/5/2024 12:12 PM, Andreas Rheinhardt wrote:
>>> James Almer:
>>>> On 2/3/2024 11:50 AM, Andreas Rheinhardt wrote:
>>>>>> diff --git a/libavformat/movenc.h b/libavformat/movenc.h
>>>>>> index 60363198c9..fee3e759e0 100644
>>>>>> --- a/libavformat/movenc.h
>>>>>> +++ b/libavformat/movenc.h
>>>>>> @@ -25,7 +25,9 @@
>>>>>> #define AVFORMAT_MOVENC_H
>>>>>> #include "avformat.h"
>>>>>> +#include "iamf.h"
>>>>>> #include "movenccenc.h"
>>>>>> +#include "libavcodec/bsf.h"
>>>>>
>>>>> There is no need to include these here, as you don't need complete
>>>>> types. This has the added benefit of forcing you to actually include
>>>>> the
>>>>> files where you are using them (namely in movenc.c, where you forgot to
>>>>> include bsf.h).
>>>>
>>>> Ok, fixed locally.
>>>>
>>>> Will push the set soon.
>>>
>>> It seems you have not noticed my objection to the first version of
>>> your set.
>>>
>>> - Andreas
>>
>> Can you link to it?
>
> Sorry, it was v2:
> https://ffmpeg.org/pipermail/ffmpeg-devel/2024-February/320722.html
>
> - Andreas
I removed the codec list from the split bsf like you asked, and
explained what the bsfs do in the documentation.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-05 15:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 17:26 [FFmpeg-devel] [PATCH 1/6 v3] avcodec: add an Immersive Audio Model and Formats frame split bsf James Almer
2024-01-31 17:26 ` [FFmpeg-devel] [PATCH 2/6 v3] avformat/demux: support inserting bitstream filters in demuxing scenarios James Almer
2024-01-31 17:26 ` [FFmpeg-devel] [PATCH 3/6 v3] avformat/mov: make MOVStreamContext refcounted James Almer
2024-01-31 17:26 ` [FFmpeg-devel] [PATCH 4/6 v3] avformat/mov: add support for Immersive Audio Model and Formats in ISOBMFF James Almer
2024-01-31 17:26 ` [FFmpeg-devel] [PATCH 5/6 v2] avcodec: add an Immersive Audio Model and Formats frame merge bsf James Almer
2024-01-31 17:26 ` [FFmpeg-devel] [PATCH 6/6 v2] avformat/movenc: add support for Immersive Audio Model and Formats in ISOBMFF James Almer
2024-02-03 14:50 ` Andreas Rheinhardt
2024-02-05 15:08 ` James Almer
2024-02-05 15:12 ` Andreas Rheinhardt
2024-02-05 15:12 ` James Almer
2024-02-05 15:28 ` Andreas Rheinhardt
2024-02-05 15:28 ` James Almer [this message]
2024-02-05 16:18 ` Andreas Rheinhardt
2024-02-05 16:51 ` James Almer
2024-02-05 17:06 ` Andreas Rheinhardt
2024-02-05 17:25 ` James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ae35670-f7bb-4f8d-ac4e-bb144883bbe6@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git