From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 97525478FA for ; Tue, 26 Dec 2023 19:21:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6AF6D68CBD7; Tue, 26 Dec 2023 21:21:37 +0200 (EET) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B82C368CA71 for ; Tue, 26 Dec 2023 21:21:30 +0200 (EET) Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-5cdfbd4e8caso2217507a12.0 for ; Tue, 26 Dec 2023 11:21:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703618488; x=1704223288; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UYf2q6Er/oMglQdQTSRCUB+Z3SkH5JeyIGIZujyENwY=; b=Ni4hVg//rLgi8/C4GtUeZUncmkYA0B1rMArVAhVaxdMJ4txixHr3kTOTVM9cGH4G8F SGyPybyaZSsPpDyCg07KlBYvDLFbLjY2Lf/P2nPUFBVj3j+YzRzok74iqn41mN7PoRnT wM19dn9mrwMOKUWTPTk0YxmR28z82lfen3pRXaZLUE5IC/BNAwnu9RHDhbBVi52hgb6q HSkS6OaKB4U+vwVsQ6X8ZctesCS8wKma1kIGmAwEdcG1PLt2LopoBZJURSC3Zn7B4Ib4 B6RSRDw2WUTpgBnizaEiVAfc9ByjX3mDsjjrHNFYNyR8fQo4lS8to/BixOwiUScfMx9F yMoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703618488; x=1704223288; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UYf2q6Er/oMglQdQTSRCUB+Z3SkH5JeyIGIZujyENwY=; b=fz4jQGmb5v0MavwDxilmPVskG+8AMB4yOOH39TDUpi2rMBIi961f6XVBG9cqebG3CC 1Y9dDOqAVRxWJFC/h1u7LzSYyDUBYN/dpl8M99HHzeSArI0uWrO7PZWeUfAXPp9n2yjP 9uWuwTU2276AhJRaV85QbI63fG182A3oBkhdMiJfLVdHEJ2So+pfuOkW6yGX0J/Dcg9D oqrUdO2mrDjbOv+JL3hB8PT5ok180m3Fkvr3QVadYkbBiJCvcN2v23m8Ffwne71FQrzf rwqTNGbzWR9+YV+8G4UWzkLqpSLehXWVky6ZYaX1HmK8JsBbDSmg7d+xRc+r0X2mH+dV xh2Q== X-Gm-Message-State: AOJu0YxFbP7V2Gx09S2UvQz7c5q6LKCl7N4eoid/7OlcnnHe3pvY32Ta xVC4mhqB5fP6cRkHkptwGVNu/L9aUTc= X-Google-Smtp-Source: AGHT+IFCYppPE3ZWPm+ZJuhbRqG0HnufGCw/ZqOr5xRejNm56rgZWvwk3JVSLS9jYq7W5M9MMNHhRw== X-Received: by 2002:a05:6a20:daa2:b0:195:db71:985 with SMTP id iy34-20020a056a20daa200b00195db710985mr2627531pzb.117.1703618487646; Tue, 26 Dec 2023 11:21:27 -0800 (PST) Received: from [192.168.0.13] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id oj14-20020a17090b4d8e00b0028bdc7e5a15sm10704856pjb.53.2023.12.26.11.21.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Dec 2023 11:21:27 -0800 (PST) Message-ID: <9aa042cb-da94-47b8-b2f6-71d0a81755c6@gmail.com> Date: Tue, 26 Dec 2023 16:21:55 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20231226162033.782945-1-stefasab@gmail.com> From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: <20231226162033.782945-1-stefasab@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] lavfi: add quirc filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/26/2023 1:20 PM, Stefano Sabatini wrote: > +static int filter_frame(AVFilterLink *inlink, AVFrame *frame) > +{ > + AVFilterContext *ctx = inlink->dst; > + AVFilterLink *outlink = ctx->outputs[0]; > + QuircContext *quirc = ctx->priv; > + int codes_count; > + int i, w, h; > + uint8_t *image, *imagep, *srcp; > + > + image = quirc_begin(quirc->quirc, &w, &h); Can't this fail? Or does the allocation take place in the quirc_resize() call? > + > + /* copy input image to quirc buffer */ > + imagep = image; > + srcp = frame->data[0]; > + for (i = 0; i < inlink->h; i++) { > + memcpy(imagep, srcp, w); Can w differ from inlink->w? > + imagep += w; > + srcp += frame->linesize[0]; > + } Maybe instead do av_image_copy_plane(image, w, frame->data[0], frame->linesize[0], w, inlink->h); _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".