From: "Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Cc: "Wu, Tong1" <tong1.wu@intel.com>
Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/mov: fix 2 compile errors
Date: Thu, 16 Mar 2023 05:48:39 +0000
Message-ID: <9a7dd2a341960bef08980e6931a377761e9bb1e9.camel@intel.com> (raw)
In-Reply-To: <20230316053258.265-1-tong1.wu@intel.com>
On Do, 2023-03-16 at 13:32 +0800, Tong Wu wrote:
> Compiler: MSVC 14.35.32215
> Error type: error C2059: syntax error: '}'
> Related commit: 9e1ffed fate/mov: add PCM in mp4 test
> d7e8643 avformat/mov: parse ISO-14496-12 ChannelLayout
>
> Signed-off-by: Tong Wu <tong1.wu@intel.com>
> ---
> libavformat/mov_chan.c | 2 +-
> libavformat/movenc.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/mov_chan.c b/libavformat/mov_chan.c
> index df17976e59..f3d51899e1 100644
> --- a/libavformat/mov_chan.c
> +++ b/libavformat/mov_chan.c
> @@ -555,7 +555,7 @@ int ff_mov_read_chan(AVFormatContext *s, AVIOContext *pb,
> AVStream *st,
> /* ISO/IEC 23001-8, 8.2 */
> static const AVChannelLayout iso_channel_configuration[] = {
> // 0: any setup
> - {},
> + {0},
>
> // 1: centre front
> AV_CHANNEL_LAYOUT_MONO,
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 2ec575c954..68e7f8222b 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -1194,7 +1194,7 @@ static int mov_write_chnl_tag(AVFormatContext *s,
> AVIOContext *pb, MOVTrack *tra
> ret = ff_mov_get_channel_positions_from_layout(layout,
> speaker_pos, layout->nb_channels);
> if (ret) {
> - char buf[128] = {};
> + char buf[128] = {0};
>
> av_freep(&speaker_pos);
> av_channel_layout_describe(layout, buf, sizeof(buf));
LGTM.
- Haihao
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-03-16 5:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 5:32 Tong Wu
2023-03-16 5:48 ` Xiang, Haihao [this message]
2023-03-16 7:01 ` "zhilizhao(赵志立)"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a7dd2a341960bef08980e6931a377761e9bb1e9.camel@intel.com \
--to=haihao.xiang-at-intel.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=tong1.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git