From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 353C549415 for ; Mon, 11 Mar 2024 12:29:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9319468D019; Mon, 11 Mar 2024 14:29:27 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 374D668C558 for ; Mon, 11 Mar 2024 14:29:21 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 42BCTJ0W024115-42BCTJ0X024115 for ; Mon, 11 Mar 2024 14:29:19 +0200 Received: from cone.home.martin.st (host-114-191.parnet.fi [77.234.114.191]) by mail9.parnet.fi (Postfix) with ESMTPS id D2B03A1467; Mon, 11 Mar 2024 14:29:19 +0200 (EET) Date: Mon, 11 Mar 2024 14:29:15 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches , FFmpeg development discussions and patches In-Reply-To: <171015983262.662.304106510805949905@lain.khirnov.net> Message-ID: <9a7a9c5f-f377-bca8-26e1-6bfe12589ed2@martin.st> References: <20240306110319.17339-1-anton@khirnov.net> <20240306110319.17339-2-anton@khirnov.net> <20240307203739.GI6420@pb2> <170987607651.7287.4766174024309496140@lain.khirnov.net> <20240310033629.GM6420@pb2> <171005119864.662.10837664362214202636@lain.khirnov.net> <20240310192147.GQ6420@pb2> <171010947057.7287.8642196154964262055@lain.khirnov.net> <7d011f1c-f131-412c-85ce-318c71efba0f@gmail.com> <171011095238.7287.16406128798977096207@lain.khirnov.net> <8e8947e3-b54b-4ce7-864a-13ccf4c4bfd3@noa-archive.com> <171015983262.662.304106510805949905@lain.khirnov.net> MIME-Version: 1.0 X-FEAS-Client-IP: 77.234.108.21 X-FE-Last-Public-Client-IP: 77.234.108.21 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 02/18] fftools/ffmpeg_filter: refactor setting input timebase X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 11 Mar 2024, Anton Khirnov wrote: > Quoting Tobias Rapp (2024-03-11 11:12:38) >> On 10/03/2024 23:49, Anton Khirnov wrote: >> >>> Quoting James Almer (2024-03-10 23:29:27) >>>> On 3/10/2024 7:24 PM, Anton Khirnov wrote: >>>>> Quoting Michael Niedermayer (2024-03-10 20:21:47) >>>>>> On Sun, Mar 10, 2024 at 07:13:18AM +0100, Anton Khirnov wrote: >>>>>>> Quoting Michael Niedermayer (2024-03-10 04:36:29) >>>>>>>> why not automatically choose a supported timebase ? >>>>>>>> "[mpeg4 @ 0x55973c869f00] timebase 1/1000000 not supported by MPEG 4 standard, the maximum admitted value for the timebase denominator is 65535" >>>>>>> Because I don't want ffmpeg CLI to have codec-specific code for a codec >>>>>>> that's been obsolete for 15+ years. One could also potentially do it >>>>>>> inside the encoder itself, but it is nontrivial since the computations >>>>>>> are spread across a number of places in mpeg4videoenc.c and >>>>>>> mpegvideo_enc.c. And again, it seems like a waste of time - there is no >>>>>>> reason to encode mpeg4 today. >>>>>> This is not mpeg4 specific, its just a new additional case that fails >>>>> The case you reported is mpeg4 specific. >>>>> >>>>>> ./ffmpeg -i mm-small.mpg test.dv >>>>>> [dvvideo @ 0x7f868800f100] Found no DV profile for 80x60 yuv420p video. Valid DV profiles are: >>>>> There is no mechanism for an encoder to export supported time bases. >>>> Could it be added as an extension to AVProfile, or AVCodec? >>> The two cases are actually pretty different: >>> * mpeg4 has a constraint on the range of timebases, and actually does >>> some perverted computations with the timestamps >>> * DV just needs your video to be CFR, with a list of supported >>> framerates; dvenc should probably read AVCodecContext.framerate >>> instead of time_base >>> >>> But most importantly, is there an actual current use case for either of >>> those encoders? They have both been obsolete for close to two decades. >>> It seems silly to add new API that won't actually be useful to anyone. >> >> Hardware doesn't get outdated as quickly as software. And there are >> people that do not switch their full environment to a new codec every >> decade just to be "in line". > > And your point is...? I think the point is, that one can't just dismiss that anybody would want to encode mpeg4 video any longer, even if it is obsolete. I also would like to keep being able to do that. That said, I haven't followed the discussion closely enough about what to do with the time bases. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".