From: Adrien Guinet <adrien@guinet.me>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: add support for multiple decryption keys
Date: Mon, 13 Nov 2023 09:35:29 +0100
Message-ID: <9a521257-3f8d-429e-824c-d0a1c7f15e39@guinet.me> (raw)
In-Reply-To: <20231112171846.GE3543730@pb2>
On 11/12/23 18:18, Michael Niedermayer wrote:
> On Sun, Nov 12, 2023 at 06:06:01PM +0100, Adrien Guinet wrote:
>> This commit introduces new options to support more than one decryption
>> keys:
>> * add a decryption_keys option to MOV, that supports a dictionnary of
>> KID=>key (in hex), using AV_OPT_TYPE_DICT
>> * add the corresponding cenc_decryption_keys option to DASH
>>
>> Signed-off-by: Adrien Guinet <adrien@guinet.me>
>> ---
>> doc/demuxers.texi | 12 +++-
>> libavformat/dashdec.c | 6 +-
>> libavformat/isom.h | 5 +-
>> libavformat/mov.c | 80 ++++++++++++++++++----
>> tests/fate/mov.mak | 12 ++++
>> tests/ref/fate/mov-3elist-encrypted-kid | 57 +++++++++++++++
>> tests/ref/fate/mov-frag-encrypted-kid | 57 +++++++++++++++
>> tests/ref/fate/mov-tenc-only-encrypted-kid | 57 +++++++++++++++
>> 8 files changed, 269 insertions(+), 17 deletions(-)
>> create mode 100644 tests/ref/fate/mov-3elist-encrypted-kid
>> create mode 100644 tests/ref/fate/mov-frag-encrypted-kid
>> create mode 100644 tests/ref/fate/mov-tenc-only-encrypted-kid
>>
>> diff --git a/doc/demuxers.texi b/doc/demuxers.texi
>> index ca1563abb0..9d0ab6025c 100644
>> --- a/doc/demuxers.texi
>> +++ b/doc/demuxers.texi
>> @@ -281,7 +281,11 @@ This demuxer accepts the following option:
>> @table @option
>> @item cenc_decryption_key
>> -16-byte key, in hex, to decrypt files encrypted using ISO Common Encryption
>> (CENC/AES-128 CTR; ISO/IEC 23001-7).
>> +Default 16-byte key, in hex, to decrypt files encrypted using ISO Common
>> Encryption (CENC/AES-128 CTR; ISO/IEC 23001-7).
>
> error: corrupt patch at line 51
>
> [...]
Erf.. I think thunderbird reformatted the whole thing. That's my first
patch ever sent to ffmpeg, sorry about this. Let me use git send-email
directly...
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-11-13 8:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-12 17:06 Adrien Guinet
2023-11-12 17:18 ` Michael Niedermayer
2023-11-13 8:35 ` Adrien Guinet [this message]
2023-11-13 8:40 Adrien Guinet
2024-08-01 0:53 ` Kacper Michajlow
2024-08-01 17:30 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a521257-3f8d-429e-824c-d0a1c7f15e39@guinet.me \
--to=adrien@guinet.me \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git