From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 072704B025 for ; Sun, 28 Jul 2024 00:29:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 871BE68D6F4; Sun, 28 Jul 2024 03:29:26 +0300 (EEST) Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D240368D562 for ; Sun, 28 Jul 2024 03:29:20 +0300 (EEST) Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3d9e13ef9aaso1486916b6e.1 for ; Sat, 27 Jul 2024 17:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722126559; x=1722731359; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=8mAZ8Pan7wJHZC5KeEbl9wnYtWv2ytRHRKWn7PhMDwU=; b=RvV6cvrYJD8uaoISOhkdal/C347lNxI26E1lyxVN8MbYfxh/ah7r6icUHzPFLFkcmw zHtU5G9vU6c3FH7P6SW1r3Uu3RRR7t6cmBpZlXgRmqnnprN1GBeWyAblTVDlKcOmfb2c q4GQM3trIJ9QiwkyHdf+YjX7gEAe+v+iT0oChX3+/4FFMNyAvUsQwr+pJdch2GqF99Yc ZnaMb27ldXmM6E3B2Mku3vfrMTqtj0+Jk1m60YfHsUZT0n9kX7Lqd0j70oP+XMb5RT2i NYpfse/K44S04aB5X04yWJW3tTTUaHwcYP4l1+Uuz8ZQRM5wMQ3FFGjGt3tqHu89UOpI pQ7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722126559; x=1722731359; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8mAZ8Pan7wJHZC5KeEbl9wnYtWv2ytRHRKWn7PhMDwU=; b=FJl01EqJ1H8sgE2m2L9z7Hz/kCtAIQmyFkgDDiBDxvS0FRozdwzxmmxgN7F+GpGBtG NOS5CGadpYpzN27+TIGyd2d20vSUsy0qZsyjNCVamSemUIXraVTchjkFik6Z4fa557zt aDYEhIJEL6PhccN7t9o07S/YSdSPzBzO8S7qOely+hjlPCeVyxZ85hHyVM6AP7qD4Wme PZvGBuZzjEebSD6G2sa/Q0pZ+AyDrzaQJTSdKgal/RE2PRhFlDXGQEBiOUrmLFKFYtUW d/W9SfQOaF21zxNfVnUR3jim9lSThtNXiR29ZDmQcwmIkUgdwSEFPNC4+StNQPbekufQ 7Thw== X-Gm-Message-State: AOJu0Yw28qRhpJ1nB7d9UWyhsHPLStBcK/zraZkThzY38AmL/zFw64yk Oi9ZxiA153jCiNeCz2mItLz0q1No+/KoEp0pefTOAEYQaJPmqEdUI8kU2Q== X-Google-Smtp-Source: AGHT+IFvNF1GLtlpRxkc9E3S0gLIurygBOC9qqDbgDwbdZyn1NhfdrlZVILmMsd1MxBIa7ig3/hIWA== X-Received: by 2002:a05:6808:1919:b0:3d9:232b:e275 with SMTP id 5614622812f47-3db239cdb0amr5624409b6e.25.1722126558739; Sat, 27 Jul 2024 17:29:18 -0700 (PDT) Received: from [192.168.0.12] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fed7fcd252sm56246515ad.285.2024.07.27.17.29.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 27 Jul 2024 17:29:18 -0700 (PDT) Message-ID: <9a42f115-24f9-43e6-9208-886a5ed1d729@gmail.com> Date: Sat, 27 Jul 2024 21:29:56 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240726210832.288597-1-michael@niedermayer.cc> <6c07cd82-77c0-43cb-a9bc-8f123226c059@gmail.com> <41048059-e345-4cf0-9bbd-d08616fd5c73@gmail.com> <20240727220644.GL4991@pb2> Content-Language: en-US From: James Almer In-Reply-To: <20240727220644.GL4991@pb2> Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Check sample_sizes before using it X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/27/2024 7:06 PM, Michael Niedermayer wrote: > Hi > > On Fri, Jul 26, 2024 at 07:24:38PM -0300, James Almer wrote: > [...] >>> Deja vu. Didn't you send something like this before? >>> >>> Also, can i get the sample? As with other issues, we shouldn't reach >> >> No, it was me: >> https://ffmpeg.org//pipermail/ffmpeg-devel/2024-June/330391.html > > Iam surprised we dont have more collisions There's a stsz atom after the iinf atom that tries to replace sc->sample_sizes. It's inside the same meta box structure as the items instead of inside an stsd structure, which is not spec compliant, so ideally we should stop parsing it if that's the case. I'll push my fix for now, but if such an stsz atom ends up allocating an array with a single entry, it will be accepted, so not exactly ideal. > either way i will drop this on my side > > >> >> Still, i want to check the sample because i'm not sure how this code is >> reached like this. > > sure, sent privatly > > thx > > [...] > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".