Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Check sample_sizes before using it

[James Almer <jamrial@gmail.com>]

On 7/27/2024 7:06 PM, Michael Niedermayer wrote:
> Hi
> 
> On Fri, Jul 26, 2024 at 07:24:38PM -0300, James Almer wrote:
> [...]
>>> Deja vu. Didn't you send something like this before?
>>>
>>> Also, can i get the sample? As with other issues, we shouldn't reach
>>
>> No, it was me:
>> https://ffmpeg.org//pipermail/ffmpeg-devel/2024-June/330391.html
> 
> Iam surprised we dont have more collisions

There's a stsz atom after the iinf atom that tries to replace 
sc->sample_sizes. It's inside the same meta box structure as the items 
instead of inside an stsd structure, which is not spec compliant, so 
ideally we should stop parsing it if that's the case.

I'll push my fix for now, but if such an stsz atom ends up allocating an 
array with a single entry, it will be accepted, so not exactly ideal.

> either way i will drop this on my side
> 
> 
>>
>> Still, i want to check the sample because i'm not sure how this code is
>> reached like this.
> 
> sure, sent privatly
> 
> thx
> 
> [...]
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".