From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1DECD4B456 for ; Wed, 5 Jun 2024 20:20:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A994E68D6B2; Wed, 5 Jun 2024 23:20:24 +0300 (EEST) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 49A8868D444 for ; Wed, 5 Jun 2024 23:20:18 +0300 (EEST) Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-7024d571d8eso170480b3a.0 for ; Wed, 05 Jun 2024 13:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717618815; x=1718223615; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=lA7LOYG4VlokMkX3Mct2P6TNEOSw773zCOY1ax6I9UE=; b=a8we8beSTQC8unQQ8/o/rbLz6D/qSZSs/kaFtBAmiE2rt9jnsKsxwKQbye4QE7cxbx BC/5AuAG1wnx8j+idKeJSWpBzbVnyc9eF8CWU7p6T9Bnn/J3Ls7sCmhFWm0MWYLPPRCY OrUCfPHd/MGXo0BAKReFHTBgSslC/ABQqBEmPGyN6ICpo3aiKIfORyv7bD7yCZ7FxeLA J7RWuPGiuZbtR61W3tmfpHmHD4qK8et93LGOFRZw/jHcBceJau65FGVy54cVXZ+ur/Cq Jo8c8NY9MAnxL9ZeGsGaDmEH8KXzlybTjImcDUUe+58uj5x1LDSRzE2fGM4ucuC40nl9 OInw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717618815; x=1718223615; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lA7LOYG4VlokMkX3Mct2P6TNEOSw773zCOY1ax6I9UE=; b=kXb9TqgukL0V9cX3wzV6AhH1t0hDeoYt1WaEPDPKT08zdIKXY2kaz2dKUhIFoIuuPW Hre79t9tjvmeQ+RbPRO/nlKqWWghrzdD5zL8CGRAkCxnUl4lInivrzOPUjCn3VPS77Pr TCE5jk7eyX+8e1l9h1ZsBpg4wAeaEmh+VvuiqkGEbQ0imSbZQihh4AsC0q2RAJ6Bp/7A GVzQp9AyyY4iDZSaA6UH5c/6EmABwEMzDECWuWltFZiTs7d0PI/ia+ZNfq1gTJrPjldK pmF6OQVeV17zsnU20LiMFXwRltlgpRugApZTjLEmRQgEPWRBz+zmVf6BeSyy2yQdxn8g yjBQ== X-Gm-Message-State: AOJu0YzhENDvTLvVGYA6Ytm5EqMqDzZxKO7byErQTdMchOxq+NtTyE50 T/LhmnzRaD0GKza+ZmHSh9MmzpBMHLnZo7dsA6/GzbWWh1c1HntevaDMVg== X-Google-Smtp-Source: AGHT+IF+7HWkmWCodkDCyzotx6BXhlfYVVJ2Y4ztfkxNyG1G+S49aIgCfLsFCN9cGMPT93Aqqj4rEQ== X-Received: by 2002:a05:6a20:3d8b:b0:1b2:b157:7619 with SMTP id adf61e73a8af0-1b2b6e2d035mr4885230637.2.1717618815408; Wed, 05 Jun 2024 13:20:15 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c28067ec6asm1895459a91.23.2024.06.05.13.20.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jun 2024 13:20:14 -0700 (PDT) Message-ID: <9a0e9ab7-abe5-437c-a489-58f87beb0e9c@gmail.com> Date: Wed, 5 Jun 2024 17:20:25 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240605183142.2831-1-jamrial@gmail.com> <20240605200803.2999-1-jamrial@gmail.com> Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] checkasm/sw_rgb: test rgb32/rgb32_1 to yuv X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/5/2024 5:10 PM, Andreas Rheinhardt wrote: > James Almer: >> Test all four pixel formats, but only bench the two native endian ones for a >> given target. >> >> Signed-off-by: James Almer >> --- >> tests/checkasm/sw_rgb.c | 22 ++++++++++++++++------ >> 1 file changed, 16 insertions(+), 6 deletions(-) >> >> diff --git a/tests/checkasm/sw_rgb.c b/tests/checkasm/sw_rgb.c >> index b51d0836c3..cba6b87add 100644 >> --- a/tests/checkasm/sw_rgb.c >> +++ b/tests/checkasm/sw_rgb.c >> @@ -187,11 +187,15 @@ static const int input_sizes[] = {8, 128, 1080, MAX_LINE_SIZE}; >> static const enum AVPixelFormat rgb_formats[] = { >> AV_PIX_FMT_RGB24, >> AV_PIX_FMT_BGR24, >> + AV_PIX_FMT_RGBA, >> + AV_PIX_FMT_BGRA, >> + AV_PIX_FMT_ABGR, >> + AV_PIX_FMT_ARGB, >> }; >> >> static void check_rgb_to_y(struct SwsContext *ctx) >> { >> - LOCAL_ALIGNED_32(uint8_t, src, [MAX_LINE_SIZE * 3]); >> + LOCAL_ALIGNED_32(uint8_t, src, [MAX_LINE_SIZE * 4]); >> LOCAL_ALIGNED_32(uint8_t, dst0_y, [MAX_LINE_SIZE * 2]); >> LOCAL_ALIGNED_32(uint8_t, dst1_y, [MAX_LINE_SIZE * 2]); >> >> @@ -199,7 +203,7 @@ static void check_rgb_to_y(struct SwsContext *ctx) >> const uint8_t *unused1, const uint8_t *unused2, int width, >> uint32_t *rgb2yuv, void *opq); >> >> - randomize_buffers(src, MAX_LINE_SIZE * 3); >> + randomize_buffers(src, MAX_LINE_SIZE * 4); >> >> for (int i = 0; i < FF_ARRAY_ELEMS(rgb_formats); i++) { >> const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(rgb_formats[i]); >> @@ -220,7 +224,10 @@ static void check_rgb_to_y(struct SwsContext *ctx) >> if (memcmp(dst0_y, dst1_y, w * 2)) >> fail(); >> >> - bench_new(dst1_y, src, NULL, NULL, w, ctx->input_rgb2yuv_table, NULL); >> + if (desc->nb_components == 3 || >> + // only bench native endian formats >> + (ctx->srcFormat == AV_PIX_FMT_RGB32 || ctx->srcFormat == AV_PIX_FMT_RGB32_1)) >> + bench_new(dst1_y, src, NULL, NULL, w, ctx->input_rgb2yuv_table, NULL); >> } >> } >> } >> @@ -228,7 +235,7 @@ static void check_rgb_to_y(struct SwsContext *ctx) >> >> static void check_rgb_to_uv(struct SwsContext *ctx) >> { >> - LOCAL_ALIGNED_32(uint8_t, src, [MAX_LINE_SIZE * 3]); >> + LOCAL_ALIGNED_32(uint8_t, src, [MAX_LINE_SIZE * 4]); > > Doesn't this make the test less strict wrt overreading for tests that > are only supposed to use MAX_LINE_SIZE * 3? Probably. Want me to add a second src buffer for this? > >> LOCAL_ALIGNED_32(uint8_t, dst0_u, [MAX_LINE_SIZE * 2]); >> LOCAL_ALIGNED_32(uint8_t, dst0_v, [MAX_LINE_SIZE * 2]); >> LOCAL_ALIGNED_32(uint8_t, dst1_u, [MAX_LINE_SIZE * 2]); >> @@ -238,7 +245,7 @@ static void check_rgb_to_uv(struct SwsContext *ctx) >> const uint8_t *src1, const uint8_t *src2, const uint8_t *src3, >> int width, uint32_t *pal, void *opq); >> >> - randomize_buffers(src, MAX_LINE_SIZE * 3); >> + randomize_buffers(src, MAX_LINE_SIZE * 4); >> >> for (int i = 0; i < 2 * FF_ARRAY_ELEMS(rgb_formats); i++) { >> enum AVPixelFormat src_fmt = rgb_formats[i / 2]; >> @@ -266,7 +273,10 @@ static void check_rgb_to_uv(struct SwsContext *ctx) >> if (memcmp(dst0_u, dst1_u, w * 2) || memcmp(dst0_v, dst1_v, w * 2)) >> fail(); >> >> - bench_new(dst1_u, dst1_v, NULL, src, src, w, ctx->input_rgb2yuv_table, NULL); >> + if (desc->nb_components == 3 || >> + // only bench native endian formats >> + (ctx->srcFormat == AV_PIX_FMT_RGB32 || ctx->srcFormat == AV_PIX_FMT_RGB32_1)) >> + bench_new(dst1_u, dst1_v, NULL, src, src, w, ctx->input_rgb2yuv_table, NULL); >> } >> } >> } > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".