From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id BADDF4C91B for ; Mon, 10 Feb 2025 01:13:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A740468BD36; Mon, 10 Feb 2025 03:13:12 +0200 (EET) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6E5F568BB43 for ; Mon, 10 Feb 2025 03:13:06 +0200 (EET) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-21f464b9a27so58565785ad.1 for ; Sun, 09 Feb 2025 17:13:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739149984; x=1739754784; darn=ffmpeg.org; h=message-id:in-reply-to:to:references:date:subject:mime-version:from :from:to:cc:subject:date:message-id:reply-to; bh=1N71DL8KccKcOF5CWz2hTRjSrr/Ss9e9Ytu4sfhfW8E=; b=jVo3C0EsoIjBhHD5ThTzR0oGpCDDw5leYeznLcN5YCMtyjnicWWOWOj/O/D1wEvTtm 8s8AQNDT65hPjLFXX5kiEzNRJBM52W5y+kg8xukqqTHPVIa0u8YYx8cxhrVtiJxOvhaJ /Qb8jt8KookYPQ7ez8R9Y7gBhm6WZ8yiMnS6mwKnfHVT386++DQaD7xWXrvuEouk4hBm uiHqXNkyEJugQ67atlT9XS67JlePDNxNYy1DRue35wojOAHaFnSUGMbEbojZNE5QHv44 h/4GoDYhXE7rWOCCqiDFR/hKtglQD1+3SKHUV6XrstGyfBF4utkSJQ8U9FKzQ5KvRKT7 lWoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739149984; x=1739754784; h=message-id:in-reply-to:to:references:date:subject:mime-version:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1N71DL8KccKcOF5CWz2hTRjSrr/Ss9e9Ytu4sfhfW8E=; b=HWncqYTY4xryeHbFMZYlVjDM5Nr0WuGCyXiW4EpspUaU2XUOSD55NWdiOrOvkJ+UMe JeBnqE78VbCbbT3DM8zI0FMR+UDgA78KdwCEji//qA5ml3SZTgFAE0LuN1CS7n9omAeb 1E7L3z7uxqjOR9jL1jjxKTJb3AH+gCmwuJipErkErhEKPEKLoFaaNEUfdWR697ZJs3qy 8oEUYcFhnq8pajR0nAnORjN2yptWyuay0tVIqynwxMUy3iDQDs/6nV73IfTrxU2ILxUM qfKiWesKTYnG8GEqE9CDDw/5hgJyxQY85YlrpOFe1IREF8i3kczfMxGDdkbbIQ0HjcpK c7ug== X-Gm-Message-State: AOJu0Ywzi8EeOIy0jixHtXU/H0E3DBFrvozF5HvUoJlq2dpusXXF+NqM Ap/NJ36WwF1sRehD0zgOQr7REJy6VGmoiPcr/+DPkAlxAxDk18e9qh+f0J4Wrg8= X-Gm-Gg: ASbGncs+eXeWAu9oZeGuBuIOuEDhS2FwZQBDKOdBvXU1cIDtO5PGWYrcFggmQt8h/2M auL+voILJt41L3neQ4+2ftAq+fRmXCQkY64tumHhlF0H6CZT/XQTECvr/oXi84+WdTb3n2A7gY9 Dq75Oq0YqosxcL0+SO+0CCCOLt1+uCwyjbcjbaThpkGYwJAhAqubwDGBnWTmmdOOxUw8LcmKIGk WRkAW1Grgp619ASArsCsmHPVTuX77yrSCvH+SFYg6pvNryg8+DEgbjZK68qI6vGqxhZc8cfuorg ouVP1Lex9PypxXVZQfJZQg== X-Google-Smtp-Source: AGHT+IG3so9aU1ChXTbHFC5wCD/7Ah2EGjpST34VAR7yy1q4l17UqiRw+1ZAk0CqHkqAdHn+cF+bYw== X-Received: by 2002:a17:902:e547:b0:215:5935:7eef with SMTP id d9443c01a7336-21f4e6b1204mr219777875ad.22.1739149984035; Sun, 09 Feb 2025 17:13:04 -0800 (PST) Received: from smtpclient.apple ([188.253.5.159]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f368cd38esm65237475ad.240.2025.02.09.17.13.02 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 09 Feb 2025 17:13:03 -0800 (PST) From: Jack Lau Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.1\)) Date: Mon, 10 Feb 2025 09:12:49 +0800 References: To: FFmpeg development discussions and patches In-Reply-To: Message-Id: <9AF64C0B-FBE2-4F93-83C4-040AFED59073@gmail.com> X-Mailer: Apple Mail (2.3776.700.51.11.1) X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an extra space in the original comment X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, Thanks for your reply. I'm trying to fix some issues with hls. I happened to see this typo. Since I saw in the ffmpeg documentation that cosmetic changes should be kept in separate patches, so i submitted it first. Thank you for your advice, I will try my best to submit more important patches. Best wishes Jack > On Feb 10, 2025, at 08:54, Soft Works wrote: > > > >> -----Original Message----- >> From: ffmpeg-devel > On Behalf Of >> Jack Lau via ffmpeg-devel >> Sent: Monday, February 10, 2025 1:34 AM >> To: ffmpeg-devel@ffmpeg.org >> Cc: Jack Lau > >> Subject: [FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an >> extra space in the original comment >> >> --- >> libavformat/hls.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavformat/hls.c b/libavformat/hls.c >> index 3bdc1bc848..c2130bb883 100644 >> --- a/libavformat/hls.c >> +++ b/libavformat/hls.c >> @@ -1993,7 +1993,7 @@ static int hls_read_header(AVFormatContext *s) >> return ret; >> >> /* XXX: Some HLS servers don't like being sent the range header, >> - in this case, need to setting http_seekable = 0 to disable >> + in this case, need to setting http_seekable = 0 to disable >> the range header */ >> av_dict_set_int(&c->avio_opts, "seekable", c->http_seekable, 0); >> >> -- >> 2.48.1 > > Hi Jack, > > you're not working on a proof of concept regarding the vulnerability of the GA, right? > (just kidding) > > As an idea, you might be able to give that patch a little bit more meaning by also fixing the grammar. > > Best wishes > sw > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".