Re: [FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an extra space in the original comment

[Jack Lau <jacklau1222gm@gmail.com>]

Hi,

Thanks for your reply.

I'm trying to fix some issues with hls. I happened to see this typo. Since I saw in the ffmpeg documentation that cosmetic changes should be kept in separate patches, so i submitted it first. 

Thank you for your advice, I will try my best to submit more important patches.

Best wishes
Jack


> On Feb 10, 2025, at 08:54, Soft Works <softworkz-at-hotmail.com@ffmpeg.org> wrote:
> 
> 
> 
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org <mailto:ffmpeg-devel-bounces@ffmpeg.org>> On Behalf Of
>> Jack Lau via ffmpeg-devel
>> Sent: Monday, February 10, 2025 1:34 AM
>> To: ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
>> Cc: Jack Lau <jacklau1222@qq.com <mailto:jacklau1222@qq.com>>
>> Subject: [FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an
>> extra space in the original comment
>> 
>> ---
>> libavformat/hls.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/libavformat/hls.c b/libavformat/hls.c
>> index 3bdc1bc848..c2130bb883 100644
>> --- a/libavformat/hls.c
>> +++ b/libavformat/hls.c
>> @@ -1993,7 +1993,7 @@ static int hls_read_header(AVFormatContext *s)
>>         return ret;
>> 
>>     /* XXX: Some HLS servers don't like being sent the range header,
>> -       in this case, need to  setting http_seekable = 0 to disable
>> +       in this case, need to setting http_seekable = 0 to disable
>>        the range header */
>>     av_dict_set_int(&c->avio_opts, "seekable", c->http_seekable, 0);
>> 
>> --
>> 2.48.1
> 
> Hi Jack,
> 
> you're not working on a proof of concept regarding the vulnerability of the GA, right? 
> (just kidding)
> 
> As an idea, you might be able to give that patch a little bit more meaning by also fixing the grammar.
> 
> Best wishes
> sw
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org <mailto:ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".