From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8480B4035A for ; Tue, 20 Dec 2022 09:21:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5029368B9BF; Tue, 20 Dec 2022 11:21:12 +0200 (EET) Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2094.outbound.protection.outlook.com [40.107.215.94]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A3DA46808AB for ; Tue, 20 Dec 2022 11:21:05 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j17nH1oia1fVinCvoS16yVFK1CMuWi/D2bumcojVM2GITcnf2UL/Lvb1meFVndt05JkipNwTPF/VBK1YiqTy1icSFfWlB3EAJ9rNv504WeXsbzF04903e8vsnWPL+Z1aUWNM/tLyCZqUAm6/kgPtkHkQSHnMHkqqE5EbUq132gzkWZCkni0MzAZW0Wx9WM11GcBFfaO/dO0kMuJsvfpIqhue3IdhGUSjlC5OXH3ke/bfGsbJpobFYZlaCnuC5rR5cha6z9jlCFcyuvPzPk3Bl24R4UScqPt+9yBixwUS20LRj7T8xbJ4fVc2t4Q7RMGv2O8zbbCm7BmzCJxacDVZZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8Zieysk4iQnvac2pCvL0MGRY3tsYq5y3BnUXjY6xHrA=; b=LONUbN2yjhE1LJeUNDeA+ExXOFtTVt6j3DBQ5ivldyXFEOnBtVqJfyW/tyEZPPs4FeKGljfr//a6/89lHsb24URiVBUMI6jG+ZvRvrPdEAEJh0PVFjHll9Yh9aSgpCTkh7gYCSio0yWFxhKz15/bwlW4iNaKcJ/nJvN6Pl4T01WIsH5cYdkFTNb1mb+BwluNWanWbPKNAyVzEagTRKsyG8oTs07Zvvfoc2Dsu0a4YvQnr6wcjcE6B2pTALGz0IDfMdkTmiKDbAoK/vEwMIcDXMfk2UYKT2Hw8wsxjQ0i/dht5ZFNvpjThuHAvzgdK9LwxohAOnIkmB/jgRwXpmU6Ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=agora.io; dmarc=pass action=none header.from=agora.io; dkim=pass header.d=agora.io; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agora.io; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8Zieysk4iQnvac2pCvL0MGRY3tsYq5y3BnUXjY6xHrA=; b=SA+XWLIUIa08oJuVvuvU1+AqqkdHM8RjpToKx6OcIzEz3xCCwKk7+eDAiZY++cu3aafiZQ4hK4sKiyIgMAotEgMg9ng3ZbkenF7qqiGpRXiTvqy1yGI9hyXkkr9dMquE8efvuKsTBFxAGPRkycklZypSCQ66Xpfh/3zx4KIrIux6MfkWvHp5ArYSyGdBcukUHUbFcoxB9UuYs8XWFUEyDhTYGWBDowhe9/1sWEDhCYmMSz9cinIzwSZvJN9HEY8CvWrvAjEc1iX7ZqiLwlJW2vmA2mBOxChYcl6PzRg19UosSzYuC/6+rc45DyiYRqST3vFfCVox0zdF1s61LYNtmw== Received: from TY0PR02MB5328.apcprd02.prod.outlook.com (2603:1096:400:144::8) by SI2PR02MB5148.apcprd02.prod.outlook.com (2603:1096:4:153::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Tue, 20 Dec 2022 09:20:59 +0000 Received: from TY0PR02MB5328.apcprd02.prod.outlook.com ([fe80::e82:3e95:b5ef:329f]) by TY0PR02MB5328.apcprd02.prod.outlook.com ([fe80::e82:3e95:b5ef:329f%8]) with mapi id 15.20.5924.016; Tue, 20 Dec 2022 09:20:58 +0000 From: "Chen, Jinkai" To: FFmpeg development discussions and patches Thread-Topic: [PATCH v2] avformat/mov: fix buffering issue for special HTTP(s) mp4. Thread-Index: AQHZFFRe8oH93D5eWkqU4W62SiUcxQ== Date: Tue, 20 Dec 2022 09:20:58 +0000 Message-ID: <9A8AE84C-B549-47E0-99FF-40AE6CB4F58A@agora.io> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=agora.io; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TY0PR02MB5328:EE_|SI2PR02MB5148:EE_ x-ms-office365-filtering-correlation-id: b1cab93d-7442-450b-7829-08dae26b815e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qoMqYNfXOTd+uDPBCLpvni9WYmDhXub/8EBS6KqN1KC7SSZPPw3iuCSdaNaHo+efRolUvKqhmnhWSKp91kfDcsfNyt/El3L/kRtiNuUR02dtWNztq7CKqhe+r0JXi3fytS5ZiMbQHa2Z7C51bhZH2J9Cjbu6bllHycawDDzSt/NvY1I6tMHC/a/FZQ1Phwrc8MJqWAlmMM4F5QjjFes7CteoFqssYQH8EJsLzyEra7eE5He4MO3InDujtfB71P15ZLkWqgmlG38aWMG30dJzwvwWZgbmdtVZ1oih16cVGiPFklVd1RZV0vrYKe6r/q6D9kaENxRAe/oRQdP07lJeof3bhQsFWgi7UtTvS+HixrOEJjqy3NiSLgeQFtKyFRHZKigQxyDqLXANoyyYHLrV/S8Y3yoLAyXv+g5gdMDx7hI/v3YTttEtGnRPexA/ayegIGrITp+IHhGdv1LhPB0hIRtb/3kehQm4wDTjqEUZKZ+rtKwOobUBpaaVwOhi5Xd66O0tfRi+LYy79waeoTZPRoNx2vdrlWfn5ZNefBRskU3lsQmDHExZkIiuIo8VYXR6Fmm7JVlA/HBCMUzgHk+F215kSh47fRF4eUZahBt2yz5MFwPrT7fCYngvW8+vSZjBV5lK8nym5+nS5g2a31/5gPcGIfgfdSCmcpDx4pY+hu/xOQxDEQG8vXWDn3MX9gRErpWFA1Spu+xzZSEMLvAEewaMuMKvKSPKne+YsUKGmS9pMWEYyGG3Lcn4oY02FHu9 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TY0PR02MB5328.apcprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(376002)(366004)(39850400004)(136003)(396003)(451199015)(86362001)(38070700005)(36756003)(26005)(33656002)(166002)(38100700002)(83380400001)(6506007)(186003)(478600001)(2616005)(71200400001)(6486002)(966005)(6916009)(66556008)(66476007)(66446008)(66946007)(64756008)(8676002)(76116006)(316002)(6512007)(41300700001)(8936002)(5660300002)(2906002)(122000001)(45980500001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FO5tycuLOBShY05S/qsHMYWt7Wk4DJrG0IPSZktVNe57+ovKK4qzuJJnNs8m?= =?us-ascii?Q?MwRlmDqvZA4NuyMK3dsvHF1SNsdrIjLPtw2tqbt9ylHdp/l5DjbbrhSCyOSJ?= =?us-ascii?Q?9GYQNJu4LBw+65WwiXsQ+oCKdh9B4gjw/Sdmr93pAqHP/fzFY2db63NWZokq?= =?us-ascii?Q?oM9uWnQ5prbCqzHBiCG+bhr4MR82cjYIRFQofD2rwrSBs4rkHZqnd+T5EQCE?= =?us-ascii?Q?T6NZ2xNOzYkEw3jcYbOUqfSI+1JKkRE/d2GBhCRbC0lDTPFo5rL5aw+iZTx2?= =?us-ascii?Q?l9VJjNtsyqN39dthl1z02UJUK1VFjtm2NDMM2g31TztxbmlNm9FbaHaNwe6L?= =?us-ascii?Q?z/LctmNH02wYvcZehWpYaoRqbLxI4YviV1+tSpTSa+GP9Ktof9yhHT/Ly77p?= =?us-ascii?Q?MjmkCSyEMrPw/F+Wmpupc0+qxRRr1mng47xguGCJLpTpwwZdFn+t0/dFaYwT?= =?us-ascii?Q?AtD+TGUoM8sRhwqNi5eFyBgUKbikZ/0Vu9fx7z7NwgZzVUAOWmlZw+M/gV+8?= =?us-ascii?Q?6wCmawYdBlXBoKc4/6FxOVzLxct82Ek3nXXGQbmKxKuZ1Tcg+kivUlqFFJb4?= =?us-ascii?Q?xmMf6Fa+rQ+gV/iKK5Pf3AdYCy9N9WlWZniezSVaYVOFhIlPYOWytDrvAaLx?= =?us-ascii?Q?6WSx8UhDGCeBIbExMW/ve5JfEsjcZAJVTgtqbqFembsXZPnaPto3Ck9ACr8s?= =?us-ascii?Q?woikoK41le8zDaqUXB7ykR7JIIJGUWRl6W46w+8v1eFyEx5MJXAHCZ9ltA3i?= =?us-ascii?Q?p8hnbsKE3jfakW8j4LFVURr8o/z1FxKcCrX9zdkNEJKUBaTbseNQ/m20qzhk?= =?us-ascii?Q?2pqsZGG92DzVBTqzxaGxxx1dhc21Cr4p1RMKDRqcKdWWaX2rBZXXq5qQnWRU?= =?us-ascii?Q?OXWSk5F6nQGQlj365MkIwy9ognFqZcz+JOtaSjHI+W++z8hHjJcJajA0bs1f?= =?us-ascii?Q?/4WarITCpORELDM307vMWFhMgHQn4718RDJIXn/1s5srg8Psjp13YWoWgDrL?= =?us-ascii?Q?seJ8mY6wtyilzB2hCBXYxXxLoUNDGwiJPyVJaYjj8zJq6lZc965V0p18RGKY?= =?us-ascii?Q?2YYo/aU55QNWvic4SHwfR/SJKSuSjOh7Z3YiCcPsvpNtYOUOsPhI3zNcb1eZ?= =?us-ascii?Q?iYrzr96sI3CeHtokfuDXQkttahiASAcuhJxnKpRbGA/WxUACRMyz794dK2gR?= =?us-ascii?Q?s3eqYRv9QTq9u5M9BAL0nmVIgzHEbwjYWBlxT9cxUj8d+Flxv0NwQ+1UoUNH?= =?us-ascii?Q?TY2ioy0qWbVyCbmCOfVWvzUVMEIHC8Su9SmRp839ji5aEaMV5aPqz6g7RdKp?= =?us-ascii?Q?e1bzNyfr+9Lf9uHekpTUKEfQP1uKnRG1k1SSwVtjFOLePj8JqJjeeRdXMhl0?= =?us-ascii?Q?LXu/xmyH8X1Ip5bjv0KM5zxdcdBktM83BNA7YI6dMrm+fWgN7qK8E56PsI3e?= =?us-ascii?Q?52R7TuEQB268bZtMJ6lKoR2//eyFkDEjQk7mChvY0TAz8X2clzimYnrViqfU?= =?us-ascii?Q?do50b/xZVXkCctmYp/GprJxfYpgG8VO4ZndhdrcHaOCzqZicAZl1oqdHc3+j?= =?us-ascii?Q?FQoEmjF3mshPOnybSFic87FkZ4wPg5yLgbj696EE?= MIME-Version: 1.0 X-OriginatorOrg: agora.io X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TY0PR02MB5328.apcprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1cab93d-7442-450b-7829-08dae26b815e X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2022 09:20:58.5550 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 60275374-3eaa-49c2-83c3-cc189d126981 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QiA6PF8edVp0W+e/c/mR2qoZn/P3xueSS+E/HiPHtJf7XqsLhDDB8XOwWTqw8Ly+/8buoVtrbJp/xD6ACXK88A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR02MB5148 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [FFmpeg-devel] [PATCH v2] avformat/mov: fix buffering issue for special HTTP(s) mp4. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Problem: Using ffplay play on these sources: https://ali-sprite-video.yyouwang.com/video/works/202211/1667997073624_73.mp4 https://images.voghion.com/productImages/04_01_C_30011_2020220106GiuseppeFanara0012.mp4 Solution: Add a private option, it will use separated IO context(HTTP connection) for each AVStream. Preventing from reading audio and video in long distance(offset), which cause seeking(HTTP request) frequently. Storing the user options when open input, and make sure that can be passed to demuxer context. Signed-off-by: Gamhoi Chan > --- libavformat/avformat.c | 1 + libavformat/demux.c | 5 ++++- libavformat/internal.h | 5 +++++ libavformat/isom.h | 1 + libavformat/mov.c | 14 +++++++++++++- 5 files changed, 24 insertions(+), 2 deletions(-) diff --git a/libavformat/avformat.c b/libavformat/avformat.c index 19c7219471..4453727f34 100644 --- a/libavformat/avformat.c +++ b/libavformat/avformat.c @@ -129,6 +129,7 @@ void avformat_free_context(AVFormatContext *s) av_freep(&s->chapters); av_dict_free(&s->metadata); av_dict_free(&si->id3v2_meta); + av_dict_free(&si->options); av_packet_free(&si->pkt); av_packet_free(&si->parse_pkt); av_freep(&s->streams); diff --git a/libavformat/demux.c b/libavformat/demux.c index 2dfd82a63c..2377bfdab0 100644 --- a/libavformat/demux.c +++ b/libavformat/demux.c @@ -237,8 +237,11 @@ int avformat_open_input(AVFormatContext **ps, const char *filename, if (fmt) s->iformat = fmt; - if (options) + if (options) { av_dict_copy(&tmp, *options, 0); + si->options = NULL; + av_dict_copy(&si->options, *options, 0); + } if (s->pb) // must be before any goto fail s->flags |= AVFMT_FLAG_CUSTOM_IO; diff --git a/libavformat/internal.h b/libavformat/internal.h index ce837fefc7..7caae8b93e 100644 --- a/libavformat/internal.h +++ b/libavformat/internal.h @@ -186,6 +186,11 @@ typedef struct FFFormatContext { * Contexts and child contexts do not contain a metadata option */ int metafree; + + /** + * options from avformat_open_input + */ + AVDictionary *options; } FFFormatContext; static av_always_inline FFFormatContext *ffformatcontext(AVFormatContext *s) diff --git a/libavformat/isom.h b/libavformat/isom.h index 64fb7065d5..dad049a2df 100644 --- a/libavformat/isom.h +++ b/libavformat/isom.h @@ -326,6 +326,7 @@ typedef struct MOVContext { int64_t extent_offset; } *avif_info; int avif_info_size; + int use_stream_pb; } MOVContext; int ff_mp4_read_descr_len(AVIOContext *pb); diff --git a/libavformat/mov.c b/libavformat/mov.c index 29bd3103e3..0d5818b327 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4519,6 +4519,18 @@ static int mov_read_trak(MOVContext *c, AVIOContext *pb, MOVAtom atom) st->index, dref->path, dref->dir, dref->filename, dref->volume, dref->nlvl_from, dref->nlvl_to); } + } else if (c->use_stream_pb) { + FFFormatContext *const si = ffformatcontext(c->fc); + AVDictionary *opts = NULL; + av_dict_copy(&opts, si->options, 0); + ret = c->fc->io_open(c->fc, &sc->pb, c->fc->url, AVIO_FLAG_READ, &opts); + av_dict_free(&opts); + if (ret < 0) { + av_log(c->fc, AV_LOG_ERROR, + "use_stream_pb, stream %d, error opening url %s.\n", + st->index, c->fc->url); + return ret; + } } else { sc->pb = c->fc->pb; sc->pb_is_copied = 1; @@ -9119,7 +9131,7 @@ static const AVOption mov_options[] = { { "enable_drefs", "Enable external track support.", OFFSET(enable_drefs), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, FLAGS }, { "max_stts_delta", "treat offsets above this value as invalid", OFFSET(max_stts_delta), AV_OPT_TYPE_INT, {.i64 = UINT_MAX-48000*10 }, 0, UINT_MAX, .flags = AV_OPT_FLAG_DECODING_PARAM }, - + { "use_stream_pb", "Each steam has its own AVIOContext.", OFFSET(use_stream_pb), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, FLAGS }, { NULL }, }; -- _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".