Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: arch1t3cht <arch1t3cht@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 0/3] avcodec/h264dec: Fix dropped frames when draining
Date: Wed, 3 Apr 2024 23:45:14 +0200
Message-ID: <99e07e67-188f-45b2-b39b-7ec7bc18df85@gmail.com> (raw)
In-Reply-To: <20240328015639.1425494-1-arch1t3cht@gmail.com>

On 28/03/2024 02:56, arch1t3cht wrote:
> Fix one or more frames being dropped when starting decoding at a SEI
> recovery point that is very close to the end of the stream
> (specifically, which is less than 2 * has_b_frames frames before the
> end of the stream in decoding order). One case of this was reported
> in ticket #10936.
> 
> Tested for regressions using FATE. If necessary I can also try to add
> a test for the previously broken behavior.
> 
> There's now a bit of code duplication between
> h264_select_output_frame and send_next_delayed_frame (or, rather,
> there was already some code duplication and this patch
> adds a bit more). But this probably cannot be avoided without a larger
> refactor to, say, also call h264_select_output_frame in
> send_next_delayed_frame instead of manually selecting a frame, which
> I don't feel confident enough to do myself.
> 
> arch1t3cht (3):
>    avcodec/h264dec: Properly mark frames as recovered when draining
>    avcodec/h264dec: Handle non-recovered frames when draining
>    avcodec/h264dec: Reindent after the previous commit
> 
>   libavcodec/h264dec.c | 44 ++++++++++++++++++++++++++------------------
>   1 file changed, 26 insertions(+), 18 deletions(-)
> 
Can I bump this? It's my first time sending a patch here so let me know
if I did something wrong.

-arch1t3cht
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2024-04-03 21:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28  1:56 arch1t3cht
2024-03-28  1:56 ` [FFmpeg-devel] [PATCH 1/3] avcodec/h264dec: Properly mark frames as recovered " arch1t3cht
2024-03-28  1:56 ` [FFmpeg-devel] [PATCH 2/3] avcodec/h264dec: Handle non-recovered frames " arch1t3cht
2024-03-28  1:56 ` [FFmpeg-devel] [PATCH 3/3] avcodec/h264dec: Reindent after the previous commit arch1t3cht
2024-04-03 21:45 ` arch1t3cht [this message]
2024-04-09 15:15   ` [FFmpeg-devel] [PATCH 0/3] avcodec/h264dec: Fix dropped frames when draining Derek Buitenhuis
2024-04-15 18:16     ` Derek Buitenhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99e07e67-188f-45b2-b39b-7ec7bc18df85@gmail.com \
    --to=arch1t3cht@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git